refactor: Remove unnecessary globbing from tsconfig files (#3287)

mondoreale · web-flow · commit c31dbcdd233c · 2025-12-12T00:54:52.000+01:00
This pull request standardizes the `include` patterns in various
`tsconfig` files across multiple packages. The main change is replacing
glob patterns like `"src/**/*"` with just `"src"` (and similar for other
folders), simplifying the TypeScript configuration and potentially
improving build performance and consistency.

### Changes

The most important changes are:

**Standardization of `include` patterns in tsconfig files:**

* Updated all `tsconfig.jest.json` and `tsconfig.node.json` files across
packages (such as `autocertifier-client`, `autocertifier-server`,
`cdn-location`, `cli-tools`, `dht`, `geoip-location`, `node`,
`proto-rpc`, `sdk`, `browser-test-runner`, and `test-utils`) to use
direct folder references (e.g., `"src"`, `"bin"`, `"test"`,
`"generated"`, `"data-generation"`) instead of recursive glob patterns
(e.g., `"src/**/*"`).

**Minor related adjustments:**

* Adjusted some `exclude` patterns and removed unnecessary file
references in the `sdk` package's `tsconfig` files for consistency.
diff --git a/packages/autocertifier-client/tsconfig.jest.json b/packages/autocertifier-client/tsconfig.jest.json
@@ -1,9 +1,9 @@
 {
   "extends": "../../tsconfig.jest.json",
   "include": [
-    "src/**/*",
-    "generated/**/*",
-    "test/**/*"
+    "src",
+    "generated",
+    "test"
   ],
   "references": [
     { "path": "../utils/tsconfig.node.json" }
diff --git a/packages/autocertifier-client/tsconfig.node.json b/packages/autocertifier-client/tsconfig.node.json
@@ -5,8 +5,8 @@
     "noImplicitOverride": false
   },
   "include": [
-    "src/**/*",
-    "generated/**/*"
+    "src",
+    "generated"
   ],
   "references": [
     { "path": "../utils/tsconfig.node.json" }
diff --git a/packages/autocertifier-server/tsconfig.jest.json b/packages/autocertifier-server/tsconfig.jest.json
@@ -1,9 +1,9 @@
 {
   "extends": "../../tsconfig.jest.json",
   "include": [
-    "src/**/*",
-    "bin/**/*",
-    "test/**/*"
+    "src",
+    "bin",
+    "test"
   ],
   "references": [
     { "path": "../utils/tsconfig.node.json" },
diff --git a/packages/autocertifier-server/tsconfig.node.json b/packages/autocertifier-server/tsconfig.node.json
@@ -5,8 +5,8 @@
     "noImplicitOverride": false
   },
   "include": [
-    "src/**/*",
-    "bin/**/*",
+    "src",
+    "bin"
   ],
   "references": [
     { "path": "../utils/tsconfig.node.json" },
diff --git a/packages/browser-test-runner/tsconfig.node.json b/packages/browser-test-runner/tsconfig.node.json
@@ -4,6 +4,6 @@
     "outDir": "dist"
   },
   "include": [
-    "src/**/*"
+    "src"
   ]
 }
diff --git a/packages/cdn-location/tsconfig.jest.json b/packages/cdn-location/tsconfig.jest.json
@@ -1,9 +1,9 @@
 {
   "extends": "../../tsconfig.jest.json",
   "include": [
-    "src/**/*",
-    "data-generation/**/*",
-    "test/**/*"
+    "src",
+    "data-generation",
+    "test"
   ],
   "references": [
     { "path": "../utils/tsconfig.node.json" },
diff --git a/packages/cdn-location/tsconfig.node.json b/packages/cdn-location/tsconfig.node.json
@@ -5,7 +5,7 @@
     "noImplicitOverride": false
   },
   "include": [
-    "src/**/*"
+    "src"
   ],
   "references": [
     { "path": "../utils/tsconfig.node.json" },
diff --git a/packages/cli-tools/tsconfig.jest.json b/packages/cli-tools/tsconfig.jest.json
@@ -6,8 +6,8 @@
     "noImplicitOverride": false
   },
   "include": [
-    "src/**/*",
-    "bin/**/*",
-    "test/**/*"
+    "src",
+    "bin",
+    "test"
   ]
 }
diff --git a/packages/cli-tools/tsconfig.node.json b/packages/cli-tools/tsconfig.node.json
@@ -6,8 +6,8 @@
   },
   "include": [
     "package.json",
-    "src/**/*",
-    "bin/**/*"
+    "src",
+    "bin"
   ],
   "references": [
     { "path": "../utils/tsconfig.node.json" },
diff --git a/packages/dht/tsconfig.jest.json b/packages/dht/tsconfig.jest.json
@@ -5,9 +5,9 @@
     "noImplicitOverride": false
   },
   "include": [
-    "src/**/*",
-    "generated/**/*",
-    "test/**/*",
+    "src",
+    "generated",
+    "test",
     "package.json",
     "scripts"
   ],
diff --git a/packages/dht/tsconfig.node.json b/packages/dht/tsconfig.node.json
@@ -5,8 +5,8 @@
     "noImplicitOverride": false
   },
   "include": [
-    "src/**/*",
-    "generated/**/*",
+    "src",
+    "generated",
     "package.json"
   ],
   "references": [
diff --git a/packages/geoip-location/tsconfig.jest.json b/packages/geoip-location/tsconfig.jest.json
@@ -1,8 +1,8 @@
 {
   "extends": "../../tsconfig.jest.json",
   "include": [
-    "src/**/*",
-    "test/**/*"
+    "src",
+    "test"
   ],
   "references": [
     { "path": "../utils/tsconfig.node.json" }
diff --git a/packages/geoip-location/tsconfig.node.json b/packages/geoip-location/tsconfig.node.json
@@ -5,7 +5,7 @@
     "noImplicitOverride": false
   },
   "include": [
-    "src/**/*"
+    "src"
   ],
   "references": [
     { "path": "../utils/tsconfig.node.json" },
diff --git a/packages/node/tsconfig.jest.json b/packages/node/tsconfig.jest.json
@@ -1,11 +1,11 @@
 {
   "extends": "../../tsconfig.jest.json",
   "include": [
-    "src/**/*",
+    "src",
     "src/**/*.json",
-    "bin/*.ts",
+    "bin",
     "package.json",
-    "test/**/*"
+    "test"
   ],
   "references": [
     { "path": "../utils/tsconfig.node.json" },
diff --git a/packages/node/tsconfig.node.json b/packages/node/tsconfig.node.json
@@ -4,9 +4,9 @@
     "outDir": "dist"
   },
   "include": [
-    "src/**/*",
+    "src",
     "src/**/*.json",
-    "bin/*.ts",
+    "bin",
     "package.json"
   ],
   "references": [
diff --git a/packages/proto-rpc/tsconfig.jest.json b/packages/proto-rpc/tsconfig.jest.json
@@ -5,9 +5,9 @@
     "noImplicitOverride": false
   },
   "include": [
-    "src/**/*",
-    "generated/**/*",
-    "test/**/*",
+    "src",
+    "generated",
+    "test"
   ],
   "references": [
     { "path": "../utils/tsconfig.node.json" },
diff --git a/packages/proto-rpc/tsconfig.node.json b/packages/proto-rpc/tsconfig.node.json
@@ -5,8 +5,8 @@
     "noImplicitOverride": false
   },
   "include": [
-    "src/**/*",
-    "generated/**/*"
+    "src",
+    "generated"
   ],
   "references": [
     { "path": "../utils/tsconfig.node.json" }
diff --git a/packages/sdk/tsconfig.jest.json b/packages/sdk/tsconfig.jest.json
@@ -10,18 +10,15 @@
   },
   "include": [
     "package.json",
-    "src/**/*",
+    "src",
     "src/**/*.json",
-    "bin/generate-config-validator.js",
-    "src/config.schema.json",
-    "test/**/*",
+    "bin",
+    "test",
     "test/**/*.json",
     "scripts"
   ],
   "exclude": [
-    "test/legacy/*",
-    "test/memory/*",
-    "test/exports/*",
+    "test/exports",
     "src/exports-esm.mjs"
   ],
   "references": [
diff --git a/packages/sdk/tsconfig.node.json b/packages/sdk/tsconfig.node.json
@@ -10,13 +10,11 @@
     "noImplicitOverride": false
   },
   "include": [
-    "src/**/*",
-    "src/**/*.json",
-    "src/config.schema.json"
+    "src",
+    "src/**/*.json"
   ],
   "exclude": [
-    "src/exports-esm.mjs",
-    "jest.config.ts"
+    "src/exports-esm.mjs"
   ],
   "references": [
     { "path": "../test-utils/tsconfig.node.json" },
diff --git a/packages/test-utils/tsconfig.jest.json b/packages/test-utils/tsconfig.jest.json
@@ -1,8 +1,8 @@
 {
   "extends": "../../tsconfig.jest.json",
   "include": [
-    "src/**/*",
-    "test/**/*"
+    "src",
+    "test"
   ],
   "references": [
     { "path": "../utils/tsconfig.node.json" }
diff --git a/packages/test-utils/tsconfig.node.json b/packages/test-utils/tsconfig.node.json
@@ -5,7 +5,7 @@
     "types": ["node", "jest"]
   },
   "include": [
-    "src/**/*"
+    "src"
   ],
   "references": [
     { "path": "../utils/tsconfig.node.json" }
diff --git a/packages/trackerless-network/tsconfig.jest.json b/packages/trackerless-network/tsconfig.jest.json
@@ -6,9 +6,9 @@
     "noImplicitOverride": false
   },
   "include": [
-    "src/**/*",
-    "generated/**/*",
-    "test/**/*",
+    "src",
+    "generated",
+    "test",
     "package.json"
   ],
   "references": [
diff --git a/packages/trackerless-network/tsconfig.node.json b/packages/trackerless-network/tsconfig.node.json
@@ -5,8 +5,8 @@
     "noImplicitOverride": false
   },
   "include": [
-    "src/**/*",
-    "generated/**/*",
+    "src",
+    "generated",
     "test/benchmark/first-message.ts",
     "test/utils/utils.ts",
     "package.json"
diff --git a/packages/utils/tsconfig.jest.json b/packages/utils/tsconfig.jest.json
@@ -1,7 +1,7 @@
 {
   "extends": "../../tsconfig.jest.json",
   "include": [
-    "src/**/*",
-    "test/**/*"
+    "src",
+    "test"
   ]
 }
diff --git a/packages/utils/tsconfig.node.json b/packages/utils/tsconfig.node.json
@@ -4,6 +4,6 @@
     "outDir": "dist"
   },
   "include": [
-    "src/**/*"
+    "src"
   ]
 }

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,6 @@`
`4`	`4`	`"outDir": "dist"`
`5`	`5`	`},`
`6`	`6`	`"include": [`
`7`		`- "src/*/"`
	`7`	`+ "src"`
`8`	`8`	`]`
`9`	`9`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6,8 +6,8 @@`
`6`	`6`	`"noImplicitOverride": false`
`7`	`7`	`},`
`8`	`8`	`"include": [`
`9`		`- "src/*/",`
`10`		`- "bin/*/",`
`11`		`- "test/*/"`
	`9`	`+ "src",`
	`10`	`+ "bin",`
	`11`	`+ "test"`
`12`	`12`	`]`
`13`	`13`	`}`