nodejs workers for validation

Author: juslesan

packages/sdk/src/signature/ServerSignatureValidation.ts

@@ -1,16 +1,28 @@
-/**
- * Node.js implementation of signature validation.
- * Runs on the main thread (worker threads can be added later if needed).
- */
+import * as Comlink from 'comlink'
+import nodeEndpoint from 'comlink/dist/umd/node-adapter'
+import { Worker } from "worker_threads"
 import { StreamMessage } from '../protocol/StreamMessage'
 import { SignatureValidationContext } from './SignatureValidationContext'
-import { SignatureValidationResult, validateSignatureData } from './signatureValidation'
+import { SignatureValidationWorkerApi } from './SignatureValidationWorker'
+import { SignatureValidationResult } from './signatureValidation'
+import { join } from 'path'
 
 export default class ServerSignatureValidation implements SignatureValidationContext {
 
-    // eslint-disable-next-line class-methods-use-this
+    private readonly worker: Worker
+    private readonly workerApi: Comlink.Remote<SignatureValidationWorkerApi>
+    constructor() {
+        const isRunningFromDist = __dirname.includes('/dist/')
+        const workerPath = isRunningFromDist
+            ? join(__dirname, 'SignatureValidationWorker.js')
+            : join(__dirname, '../../dist/src/signature/SignatureValidationWorker.js')
+        this.worker = new Worker(workerPath)
+        this.workerApi = Comlink.wrap<SignatureValidationWorkerApi>(nodeEndpoint(this.worker))
+    }
+
     async validateSignature(message: StreamMessage): Promise<SignatureValidationResult> {
-        return validateSignatureData(message)
+        console.log('validateSignature', message)
+        return this.workerApi.validateSignature(message)
     }
 
     // eslint-disable-next-line class-methods-use-this

packages/sdk/src/signature/SignatureValidationWorker.ts

@@ -10,4 +10,15 @@ const workerApi = {
 
 export type SignatureValidationWorkerApi = typeof workerApi
 
-Comlink.expose(workerApi)
+// Detect environment and expose accordingly
+if (typeof self !== 'undefined') {
+    // Browser Web Worker
+    Comlink.expose(workerApi)
+} else {
+    // Node.js Worker Thread
+    // eslint-disable-next-line @typescript-eslint/no-require-imports
+    const { parentPort } = require('worker_threads')
+    // eslint-disable-next-line @typescript-eslint/no-require-imports
+    const nodeEndpoint = require('comlink/dist/umd/node-adapter')
+    Comlink.expose(workerApi, nodeEndpoint(parentPort))
+}

packages/sdk/test/unit/SignatureValidator.test.ts

@@ -24,7 +24,7 @@ describe('SignatureValidator', () => {
 
     describe('SECP256K1', () => {
 
-        it('unencrypted message passes signature validation', async () => {
+        it.only('unencrypted message passes signature validation', async () => {
             const message = new StreamMessage({
                 messageId: new MessageID(
                     toStreamID('streamr.eth/foo/bar'),
@@ -43,6 +43,11 @@ describe('SignatureValidator', () => {
                 signature: hexToBinary('e53045adef4e01f7fe11d4b3073c6053688912e4db0ee780c189cd0d128c923457e1f6cbc1e47d9cd57e115afa9eb8524288887777c1056d638b193cae112dda1b'),
                 signatureType: SignatureType.ECDSA_SECP256K1_EVM
             })
+            try {
+                await signatureValidator.assertSignatureIsValid(message)
+            } catch (error) {
+                console.log(error)
+            }
             await expect(signatureValidator.assertSignatureIsValid(message)).toResolve()
         })