[GHA] ST execution actions wait only for artifacts and not for java + playwright (#2406)

Signed-off-by: jkalinic <jkalinic@redhat.com>

Author: jankalinic

.github/actions/systemtests/verify-workflow-run-succeeded.sh

@@ -8,20 +8,36 @@ source $SCRIPT_DIR/common.sh
 
 WORKFLOW_FILE=${1:-integration.yml}
 
-echo "Check workflow run succeeded"
+echo "Check build-images job succeeded"
 
 # Get branch from PR
 BRANCH=$(gh pr view "$PR_NUMBER" --repo "$REPO" --json headRefName -q '.headRefName')
 echo "Fetching latest Build workflow run for branch $BRANCH..."
 
-# Fetch latest workflow run conclusion
-BUILD_RUN=$(gh api "repos/$REPO/actions/workflows/$WORKFLOW_FILE/runs?branch=$BRANCH&per_page=1" \
-  --jq '.workflow_runs[0].conclusion')
+# Get the latest run ID for the workflow
+RUN_ID=$(gh api "repos/$REPO/actions/workflows/$WORKFLOW_FILE/runs?branch=$BRANCH&per_page=1" \
+  --jq '.workflow_runs[0].id')
 
-echo "Build workflow latest run conclusion: $BUILD_RUN"
-if [[ "$BUILD_RUN" != "success" ]]; then
-  # Comment workflow status
+echo "Latest workflow run ID: $RUN_ID"
+
+if [[ -z "$RUN_ID" || "$RUN_ID" == "null" ]]; then
+  deleteLastStatusComment
+  gh pr comment $PR_NUMBER --repo $REPO --body "❌ No workflow run found for branch $BRANCH. Cannot trigger systemtests"
+  exit 1
+fi
+
+# Check specifically the build-images job conclusion within that run
+BUILD_IMAGES_STATUS=$(gh api "repos/$REPO/actions/runs/$RUN_ID/jobs" \
+  --jq '.jobs[] | select(.name=="build-images") | .conclusion')
+
+echo "build-images job conclusion: $BUILD_IMAGES_STATUS"
+
+if [[ "$BUILD_IMAGES_STATUS" != "success" ]]; then
   deleteLastStatusComment
-  gh pr comment $PR_NUMBER --repo $REPO --body "❌ Build did not succeed. Cannot trigger systemtests"
+  gh pr comment $PR_NUMBER --repo $REPO --body "❌ build-images job did not succeed (status: $BUILD_IMAGES_STATUS). Cannot trigger systemtests"
   exit 1
 fi
+
+# Export run ID so systemtests workflow can download artifacts from it directly
+echo "ARTIFACTS_RUN_ID=$RUN_ID" >> $GITHUB_ENV
+echo "Build images succeeded, artifacts available from run $RUN_ID"

.github/workflows/pre-systemtest.yml

@@ -30,7 +30,7 @@ jobs:
         if: ${{ contains(github.event.comment.body, '--help') }}
         run: ./.github/actions/systemtests/pr-help.sh
 
-      - name: Check if Build workflow succeeded
+      - name: Check if build-images job succeeded
         run: ./.github/actions/systemtests/verify-workflow-run-succeeded.sh
 
       - name: Parse parameters from comment
@@ -40,14 +40,15 @@ jobs:
       - name: Comment start of the build
         run: ./.github/actions/systemtests/update-pr-systemtests-started.sh
 
-      - name: Invoke workflow in another repo with inputs
+      - name: Invoke workflow with inputs
         uses: benc-uk/workflow-dispatch@7a027648b88c2413826b6ddd6c76114894dc5ec4
         with:
           token: ${{ secrets.BOT_ORG_SCOPED_TOKEN }}
           workflow: systemtests.yml
           inputs: >
             {
               "commit_sha": "${{ env.COMMIT_SHA }}",
+              "artifacts_run_id": "${{ env.ARTIFACTS_RUN_ID }}",
               "testcase": "${{ env.TESTCASE }}",
               "profile": "${{ env.PROFILE }}",
               "install_type": "${{ env.INSTALL_TYPE }}",

.github/workflows/systemtests.yml

@@ -6,6 +6,9 @@ on:
       commit_sha:
         description: 'Commit sha'
         required: true
+      artifacts_run_id:
+        description: 'Run ID of the integration workflow to download artifacts from'
+        required: true
       testcase:
         description: 'Test case to run'
         required: false
@@ -65,6 +68,7 @@ jobs:
       TEST_CASE: ${{ matrix.testcase }}
       PROFILE: ${{ matrix.profile }}
       COMMIT_SHA: ${{ github.event.inputs.commit_sha }}
+      ARTIFACTS_RUN_ID: ${{ github.event.inputs.artifacts_run_id }}
       GH_TOKEN: ${{ secrets.BOT_ORG_SCOPED_TOKEN }}
       REPO: ${{ github.repository }}
       INSTALL_TYPE: ${{ github.event.inputs.install_type }}
@@ -80,11 +84,6 @@ jobs:
         with:
           ref: ${{ env.COMMIT_SHA }}
 
-      - name: Get previously built artifacts
-        run: |
-          ARTIFACTS_RUN_ID=$(gh run list --repo $REPO --commit $COMMIT_SHA --workflow integration.yml --status success --json databaseId --jq '.[0].databaseId')
-          echo "ARTIFACTS_RUN_ID=$ARTIFACTS_RUN_ID" >> $GITHUB_ENV
-
       - name: Download Image Artifacts
         uses: actions/download-artifact@v8
         with:
@@ -113,17 +112,14 @@ jobs:
           echo "PROJECT_VERSION=$(mvn help:evaluate -Dexpression=project.version -q -DforceStdout | tr '[:upper:]' '[:lower:]')" >> $GITHUB_ENV
           echo "CONSOLE_CLUSTER_DOMAIN=$(minikube ip).nip.io" >> $GITHUB_ENV
 
-      # YAML INSTALL PATH
       - name: Prepare YAML install
         if: ${{ env.INSTALL_TYPE == 'yaml' }}
         run: |
           set -x
           echo "Preparing YAML-based installation..."
 
-          # Download k8s-resources artifact (same run as images)
-          gh run download ${{ env.ARTIFACTS_RUN_ID }} --repo ${{ env.REPO }}  -n k8s-resources --dir ./k8s-resources
+          gh run download ${{ env.ARTIFACTS_RUN_ID }} --repo ${{ env.REPO }} -n k8s-resources --dir ./k8s-resources
 
-          # Merge YAML files
           mkdir -p ./k8s-resources/merged
           cat ./k8s-resources/kubernetes/consoles.console.streamshub.github.com-v1.yml \
               ./k8s-resources/kubernetes/kubernetes.yml \