cleanup, fix some links

sayhiben · sayhiben · commit 6ff08b5c6014 · 2025-07-10T11:12:13.000-07:00
diff --git a/CLAUDE.md b/CLAUDE.md
@@ -218,24 +218,16 @@ make logs HOST=your-droplet-ip
 
 ## Feature Flags
 
-Access at `/admin/feature_flags` when logged in as admin.
-
-### Stream Features
-- `analytics` - Advanced analytics
-- `bulk_import` - Bulk data import
-- `export` - Data export
-- `webhooks` - Webhook notifications
-
-### User Features
-- `two_factor_auth` - 2FA support
-- `api_keys` - API key management
-- `activity_log` - Audit logging
-
-### System Features
-- `maintenance_mode` - Maintenance page
-- `real_time_notifications` - Live alerts
-- `ai_stream_recommendations` - AI features
-- `collaborative_playlists` - Playlist sharing
+Access Flipper UI at `/admin/flipper` when logged in as admin (opens in new tab from sidebar).
+
+### Active Feature Flags
+- `stream_analytics` - Advanced analytics for streams
+- `stream_bulk_import` - Bulk importing of streams (enabled for editors)
+- `stream_export` - Data export functionality
+- `stream_tags` - Tagging system for streams (enabled for admins)
+- `advanced_search` - Enhanced search functionality (enabled by default)
+- `maintenance_mode` - Application maintenance mode (disabled by default)
+- `location_validation` - Validate stream locations against known cities
 
 ## API Quick Reference
 
diff --git a/app/controllers/admin/feature_flags_controller.rb b/app/controllers/admin/feature_flags_controller.rb
diff --git a/app/views/admin/feature_flags/index.html.erb b/app/views/admin/feature_flags/index.html.erb
diff --git a/app/views/layouts/admin.html.erb b/app/views/layouts/admin.html.erb
@@ -69,11 +69,14 @@
               <% end %>
             </li>
             <li>
-              <%= link_to admin_feature_flags_path, class: "flex items-center px-3 py-2 rounded hover:bg-gray-800 transition #{'bg-gray-800' if controller_name == 'feature_flags'}" do %>
+              <%= link_to "/admin/flipper", target: "_blank", rel: "noopener", class: "flex items-center px-3 py-2 rounded hover:bg-gray-800 transition" do %>
                 <svg class="w-5 h-5 mr-3" fill="none" stroke="currentColor" viewBox="0 0 24 24">
                   <path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M3 21v-4m0 0V5a2 2 0 012-2h6.5l1 1H21l-3 6 3 6h-8.5l-1-1H5a2 2 0 00-2 2zm9-13.5V9"></path>
                 </svg>
                 Feature Flags
+                <svg class="w-4 h-4 ml-auto" fill="none" stroke="currentColor" viewBox="0 0 24 24">
+                  <path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M10 6H6a2 2 0 00-2 2v10a2 2 0 002 2h10a2 2 0 002-2v-4M14 4h6m0 0v6m0-6L10 14"></path>
+                </svg>
               <% end %>
             </li>
           </ul>
@@ -149,11 +152,14 @@
               <% end %>
             </li>
             <li>
-              <%= link_to admin_feature_flags_path, class: "flex items-center px-3 py-2 rounded hover:bg-gray-800 transition #{'bg-gray-800' if controller_name == 'feature_flags'}" do %>
+              <%= link_to "/admin/flipper", target: "_blank", rel: "noopener", class: "flex items-center px-3 py-2 rounded hover:bg-gray-800 transition" do %>
                 <svg class="w-5 h-5 mr-3" fill="none" stroke="currentColor" viewBox="0 0 24 24">
                   <path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M3 21v-4m0 0V5a2 2 0 012-2h6.5l1 1H21l-3 6 3 6h-8.5l-1-1H5a2 2 0 00-2 2zm9-13.5V9"></path>
                 </svg>
                 Feature Flags
+                <svg class="w-4 h-4 ml-auto" fill="none" stroke="currentColor" viewBox="0 0 24 24">
+                  <path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M10 6H6a2 2 0 00-2 2v10a2 2 0 002 2h10a2 2 0 002-2v-4M14 4h6m0 0v6m0-6L10 14"></path>
+                </svg>
               <% end %>
             </li>
           </ul>
diff --git a/config/application_constants.rb b/config/application_constants.rb
@@ -74,33 +74,15 @@ module Messages
 
   # Feature Flags
   module Features
-    # Stream features
+    # Stream features (actively used)
     STREAM_ANALYTICS = :stream_analytics
     STREAM_BULK_IMPORT = :stream_bulk_import
     STREAM_EXPORT = :stream_export
-    STREAM_WEBHOOKS = :stream_webhooks
     STREAM_TAGS = :stream_tags
-    STREAM_SCHEDULING = :stream_scheduling
 
-    # User features
-    USER_PROFILE_CUSTOMIZATION = :user_profile_customization
-    USER_TWO_FACTOR_AUTH = :user_two_factor_auth
-    USER_API_KEYS = :user_api_keys
-    USER_ACTIVITY_LOG = :user_activity_log
-
-    # API features
-    API_GRAPHQL = :api_graphql
-    API_WEBSOCKETS = :api_websockets
-    API_V2 = :api_v2
-
-    # System features
+    # System features (actively used)
     ADVANCED_SEARCH = :advanced_search
-    REAL_TIME_NOTIFICATIONS = :real_time_notifications
     MAINTENANCE_MODE = :maintenance_mode
     LOCATION_VALIDATION = :location_validation
-
-    # Experimental features
-    AI_STREAM_RECOMMENDATIONS = :ai_stream_recommendations
-    COLLABORATIVE_PLAYLISTS = :collaborative_playlists
   end
 end
diff --git a/config/routes.rb b/config/routes.rb
@@ -78,12 +78,6 @@
     patch "users/:id/toggle_admin", to: "users#toggle_admin", as: "toggle_admin_user"
     resources :users, only: %i[index show create update destroy]
 
-    resources :feature_flags, only: [:index] do
-      member do
-        patch :update
-      end
-    end
-
     # Timestamps routes
     resources :timestamps, only: %i[index show new edit create update destroy] do
       member do
@@ -93,10 +87,8 @@
       end
     end
 
-    # Define locations routes with new and edit
-    get "locations/new", to: "locations#new", as: "new_location"
-    get "locations/:id/edit", to: "locations#edit", as: "edit_location"
-    resources :locations, only: %i[index show create update destroy]
+    # Locations
+    resources :locations, only: %i[index show new edit create update destroy]
 
     root to: "streams#index"
   end
diff --git a/db/seeds/feature_flags.rb b/db/seeds/feature_flags.rb
@@ -18,9 +18,7 @@
 Flipper.enable_group(ApplicationConstants::Features::STREAM_TAGS, :admins)
 Rails.logger.debug "Enabled STREAM_TAGS for admins group"
 
-# Enable for percentage of actors
-Flipper.enable_percentage_of_actors(ApplicationConstants::Features::AI_STREAM_RECOMMENDATIONS, 10)
-Rails.logger.debug "Enabled AI_STREAM_RECOMMENDATIONS for 10% of users"
+# All used feature flags are set above - no experimental features enabled
 
 # Disable maintenance mode by default
 Flipper.disable(ApplicationConstants::Features::MAINTENANCE_MODE)
diff --git a/docker-compose.yml b/docker-compose.yml
@@ -8,7 +8,7 @@ services:
       POSTGRES_PASSWORD: streamsource_password
       POSTGRES_DB: streamsource_development
     ports:
-      - "5432:5432"
+      - "5433:5432"
     healthcheck:
       test: ["CMD-SHELL", "pg_isready -U streamsource -d streamsource_development"]
       interval: 5s
@@ -18,7 +18,7 @@ services:
   redis:
     image: redis:7-alpine
     ports:
-      - "6379:6379"
+      - "6380:6379"
     healthcheck:
       test: ["CMD", "redis-cli", "ping"]
       interval: 5s
@@ -32,7 +32,7 @@ services:
       - .:/rails:cached
       - bundle_cache:/usr/local/bundle
     ports:
-      - "3000:3000"
+      - "3001:3000"
     depends_on:
       db:
         condition: service_healthy
diff --git a/spec/requests/admin/feature_flags_spec.rb b/spec/requests/admin/feature_flags_spec.rb
