fix: resolve issue with migrations and unsigned int columns in aurora-data-api (typeorm#9478)

* fix: resolve issue with migrations and unsigned int columns in aurora-data-api

Closes: typeorm#9477

* refactor: fix prettier

* refactor: fix prettier again

Author: mkilp

src/driver/aurora-mysql/AuroraMysqlQueryRunner.ts

@@ -2144,6 +2144,12 @@ export class AuroraMysqlQueryRunner
                         tableColumn.name = dbColumn["COLUMN_NAME"]
                         tableColumn.type = dbColumn["DATA_TYPE"].toLowerCase()
 
+                        // Unsigned columns are handled differently when it comes to width.
+                        // Hence, we need to set the unsigned attribute before we check the width.
+                        tableColumn.unsigned = tableColumn.zerofill
+                            ? true
+                            : dbColumn["COLUMN_TYPE"].indexOf("unsigned") !== -1
+
                         if (
                             this.driver.withWidthColumnTypes.indexOf(
                                 tableColumn.type as ColumnType,
@@ -2212,9 +2218,6 @@ export class AuroraMysqlQueryRunner
                         )
                         tableColumn.zerofill =
                             dbColumn["COLUMN_TYPE"].indexOf("zerofill") !== -1
-                        tableColumn.unsigned = tableColumn.zerofill
-                            ? true
-                            : dbColumn["COLUMN_TYPE"].indexOf("unsigned") !== -1
                         tableColumn.isGenerated =
                             dbColumn["EXTRA"].indexOf("auto_increment") !== -1
                         if (tableColumn.isGenerated)
@@ -2796,8 +2799,24 @@ export class AuroraMysqlQueryRunner
             this.connection.driver.dataTypeDefaults[column.type].width
 
         if (defaultWidthForType) {
-            return defaultWidthForType === width
+            // In MariaDB & MySQL 5.7, the default widths of certain numeric types are 1 less than
+            // the usual defaults when the column is unsigned.
+            // This also applies to Aurora MySQL.
+            const typesWithReducedUnsignedDefault = [
+                "int",
+                "tinyint",
+                "smallint",
+                "mediumint",
+            ]
+            const needsAdjustment =
+                typesWithReducedUnsignedDefault.indexOf(column.type) !== -1
+            if (column.unsigned && needsAdjustment) {
+                return defaultWidthForType - 1 === width
+            } else {
+                return defaultWidthForType === width
+            }
         }
+
         return false
     }
 }

test/github-issues/9477/entity/Test.ts

@@ -0,0 +1,7 @@
+import { Entity, PrimaryGeneratedColumn } from "../../../../src"
+
+@Entity()
+export class Test {
+    @PrimaryGeneratedColumn({ unsigned: true })
+    id: number
+}

test/github-issues/9477/issue-9477.ts

@@ -0,0 +1,33 @@
+import "reflect-metadata"
+import { expect } from "chai"
+import { DataSource } from "../../../src"
+import {
+    closeTestingConnections,
+    createTestingConnections,
+    reloadTestingDatabases,
+} from "../../utils/test-utils"
+import { Test } from "./entity/Test"
+
+describe("github issues > #9477 Unsigned Integers Columns constantly dropped and recreated", () => {
+    let connections: DataSource[]
+    before(async () => {
+        connections = await createTestingConnections({
+            entities: [Test],
+            schemaCreate: true,
+            dropSchema: true,
+        })
+    })
+    beforeEach(() => reloadTestingDatabases(connections))
+    after(() => closeTestingConnections(connections))
+
+    it("should not create migrations for unsigned indices", () =>
+        Promise.all(
+            connections.map(async (connection) => {
+                const sqlInMemory = await connection.driver
+                    .createSchemaBuilder()
+                    .log()
+                expect(sqlInMemory.upQueries).to.eql([])
+                expect(sqlInMemory.downQueries).to.eql([])
+            }),
+        ))
+})