fix: always use day icons

Ryuno-Ki · Ryuno-Ki · commit cb5ef827d006 · 2025-01-13T08:24:50.000+01:00
The API response did not contain an is_day flag for the summary.
Therefore the code always opted for using the night icon. Doesn't make
sense.

Signed-off-by: André Jaenisch &lt;andre.jaenisch@posteo.de&gt;
diff --git a/weather-api-widget/weather.lua b/weather-api-widget/weather.lua
@@ -321,10 +321,6 @@ local function worker(user_args)
             for i, day in ipairs(forecast) do
                 -- Free plan allows forecast for up to three days, each with hours
                 if i > 3 then break end
-                local day_night_extension = ""
-                if not day.is_day then
-                    day_night_extension = "-night"
-                end
 
                 local day_forecast = wibox.widget {
                     {
@@ -336,9 +332,9 @@ local function worker(user_args)
                     {
                         {
                             {
+                                -- No extension to decide between day and night
                                 image = ICONS_DIR
                                     .. icon_map[day.day.condition.code]
-                                    .. day_night_extension
                                     .. icons_extension,
                                 resize = true,
                                 forced_width = 48,

Original file line number	Diff line number	Diff line change
`@@ -321,10 +321,6 @@ local function worker(user_args)`
`321`	`321`	`for i, day in ipairs(forecast) do`
`322`	`322`	`-- Free plan allows forecast for up to three days, each with hours`
`323`	`323`	`if i > 3 then break end`
`324`		`- local day_night_extension = ""`
`325`		`- if not day.is_day then`
`326`		`- day_night_extension = "-night"`
`327`		`- end`
`328`	`324`
`329`	`325`	`local day_forecast = wibox.widget {`
`330`	`326`	`{`
`@@ -336,9 +332,9 @@ local function worker(user_args)`
`336`	`332`	`{`
`337`	`333`	`{`
`338`	`334`	`{`
	`335`	`+ -- No extension to decide between day and night`
`339`	`336`	`image = ICONS_DIR`
`340`	`337`	`.. icon_map[day.day.condition.code]`
`341`		`- .. day_night_extension`
`342`	`338`	`.. icons_extension,`
`343`	`339`	`resize = true,`
`344`	`340`	`forced_width = 48,`