fix: crash when resizing render window and at the same time creating textures in a background thread (#2842)

A relevant lock statement on the internal GraphicsDevice.Resources collection was missing.

Author: azeno

sources/engine/Stride.Graphics/Direct3D/SwapChainGraphicsPresenter.Direct3D.cs

@@ -336,13 +336,17 @@ protected override void ResizeDepthStencilBuffer(int width, int height, PixelFor
         private FastList<Texture> DestroyChildrenTextures(Texture parentTexture)
         {
             var fastList = new FastList<Texture>();
-            foreach (var resource in GraphicsDevice.Resources)
+            var resources = GraphicsDevice.Resources;
+            lock (resources)
             {
-                var texture = resource as Texture;
-                if (texture != null && texture.ParentTexture == parentTexture)
+                foreach (var resource in resources)
                 {
-                    texture.OnDestroyed();
-                    fastList.Add(texture);
+                    var texture = resource as Texture;
+                    if (texture != null && texture.ParentTexture == parentTexture)
+                    {
+                        texture.OnDestroyed();
+                        fastList.Add(texture);
+                    }
                 }
             }
 

sources/engine/Stride.Graphics/ResumeManager.cs

@@ -41,22 +41,28 @@ public void OnRender()
 
         public void Pause()
         {
-            foreach (var resource in graphicsDevice.Resources)
+            lock (graphicsDevice.Resources)
             {
-                if (resource.OnPause())
-                    resource.LifetimeState = GraphicsResourceLifetimeState.Paused;
+                foreach (var resource in graphicsDevice.Resources)
+                {
+                    if (resource.OnPause())
+                        resource.LifetimeState = GraphicsResourceLifetimeState.Paused;
+                } 
             }
         }
 
         public void OnResume()
         {
-            foreach (var resource in graphicsDevice.Resources)
+            lock (graphicsDevice.Resources)
             {
-                if (resource.LifetimeState == GraphicsResourceLifetimeState.Paused)
+                foreach (var resource in graphicsDevice.Resources)
                 {
-                    resource.OnResume();
-                    resource.LifetimeState = GraphicsResourceLifetimeState.Active;
-                }
+                    if (resource.LifetimeState == GraphicsResourceLifetimeState.Paused)
+                    {
+                        resource.OnResume();
+                        resource.LifetimeState = GraphicsResourceLifetimeState.Active;
+                    }
+                } 
             }
         }
 
@@ -68,47 +74,53 @@ public void OnRecreate()
             bool wasSomethingRecreated = true;
             bool hasDestroyedObjects = true;
 
-            // Only continue if we made some progress, otherwise that means we reached something that could not be solved
-            // This allows for dependencies to still be handled without some complex system
-            // (we don't really care of recreation performance/complexity).
-            while (wasSomethingRecreated && hasDestroyedObjects)
+            lock (graphicsDevice.Resources)
             {
-                // Let's track if something happened during this loop
-                wasSomethingRecreated = false;
-                hasDestroyedObjects = false;
-
-                foreach (var resource in graphicsDevice.Resources)
+                // Only continue if we made some progress, otherwise that means we reached something that could not be solved
+                // This allows for dependencies to still be handled without some complex system
+                // (we don't really care of recreation performance/complexity).
+                while (wasSomethingRecreated && hasDestroyedObjects)
                 {
-                    if (resource.LifetimeState == GraphicsResourceLifetimeState.Destroyed)
+                    // Let's track if something happened during this loop
+                    wasSomethingRecreated = false;
+                    hasDestroyedObjects = false;
+
+                    foreach (var resource in graphicsDevice.Resources)
                     {
-                        if (resource.OnRecreate())
-                        {
-                            wasSomethingRecreated = true;
-                            resource.LifetimeState = GraphicsResourceLifetimeState.Active;
-                        }
-                        else
+                        if (resource.LifetimeState == GraphicsResourceLifetimeState.Destroyed)
                         {
-                            // Couldn't be recreated?
-                            hasDestroyedObjects = true;
+                            if (resource.OnRecreate())
+                            {
+                                wasSomethingRecreated = true;
+                                resource.LifetimeState = GraphicsResourceLifetimeState.Active;
+                            }
+                            else
+                            {
+                                // Couldn't be recreated?
+                                hasDestroyedObjects = true;
+                            }
                         }
                     }
                 }
-            }
 
-            if (hasDestroyedObjects)
-            {
-                // Attach the list of objects that could not be recreated to the exception.
-                var destroyedObjects = graphicsDevice.Resources.Where(x => x.LifetimeState == GraphicsResourceLifetimeState.Destroyed).ToList();
-                throw new InvalidOperationException("Could not recreate all objects.") { Data = { { "DestroyedObjects", destroyedObjects } } };
+                if (hasDestroyedObjects)
+                {
+                    // Attach the list of objects that could not be recreated to the exception.
+                    var destroyedObjects = graphicsDevice.Resources.Where(x => x.LifetimeState == GraphicsResourceLifetimeState.Destroyed).ToList();
+                    throw new InvalidOperationException("Could not recreate all objects.") { Data = { { "DestroyedObjects", destroyedObjects } } };
+                } 
             }
         }
 
         public void OnDestroyed()
         {
-            foreach (var resource in graphicsDevice.Resources)
+            lock (graphicsDevice.Resources)
             {
-                resource.OnDestroyed();
-                resource.LifetimeState = GraphicsResourceLifetimeState.Destroyed;
+                foreach (var resource in graphicsDevice.Resources)
+                {
+                    resource.OnDestroyed();
+                    resource.LifetimeState = GraphicsResourceLifetimeState.Destroyed;
+                } 
             }
 
             // Clear various graphics device internal states (input layouts, FBOs, etc...)
@@ -117,16 +129,19 @@ public void OnDestroyed()
 
         public void OnReload()
         {
-            foreach (var resource in graphicsDevice.Resources)
+            lock (graphicsDevice.Resources)
             {
-                if (resource.LifetimeState == GraphicsResourceLifetimeState.Destroyed)
+                foreach (var resource in graphicsDevice.Resources)
                 {
-                    if (resource.Reload != null)
+                    if (resource.LifetimeState == GraphicsResourceLifetimeState.Destroyed)
                     {
-                        resource.Reload(resource, services);
-                        resource.LifetimeState = GraphicsResourceLifetimeState.Active;
+                        if (resource.Reload != null)
+                        {
+                            resource.Reload(resource, services);
+                            resource.LifetimeState = GraphicsResourceLifetimeState.Active;
+                        }
                     }
-                }
+                } 
             }
         }
     }