Game: add option to control whether to show window or not. This prevents graphics unit tests to disrupt user computer.

Author: xen2

sources/engine/Stride.Games/Desktop/WindowsMessageLoop.cs

@@ -212,7 +212,6 @@ public static void Run(Control form, RenderCallback renderCallback, bool useAppl
             if (form == null) throw new ArgumentNullException("form");
             if (renderCallback == null) throw new ArgumentNullException("renderCallback");
 
-            form.Show();
             using (var renderLoop = new WindowsMessageLoop(form) { UseApplicationDoEvents = useApplicationDoEvents })
             {
                 while (renderLoop.NextFrame())

sources/engine/Stride.Games/GameBase.cs

@@ -218,6 +218,12 @@ protected GameBase()
         /// <value><c>true</c> if this instance forces one update step per one draw step; otherwise, <c>false</c>.</value>
         protected internal bool ForceOneUpdatePerDraw { get; set; }
 
+        /// <summary>
+        /// Specifies if <see cref="GameWindow.Visible"/> is set to true during <see cref="Run(GameContext)"/>.
+        /// Only valid when <see cref="GameContext.IsUserManagingRun"/> is false.
+        /// </summary>
+        protected bool MakeWindowVisibleOnRun { get; set; } = true;
+
         /// <summary>
         /// When <see cref="IsFixedTimeStep"/> is set, is it allowed to render frames between two steps when we have time to do so.
         /// </summary>
@@ -891,6 +897,8 @@ protected virtual void OnWindowCreated()
         private void GamePlatformOnWindowCreated(object sender, EventArgs eventArgs)
         {
             Window.IsMouseVisible = isMouseVisible;
+            if (MakeWindowVisibleOnRun && !Context.IsUserManagingRun)
+                Window.Visible = true;
             OnWindowCreated();
         }
 

sources/engine/Stride.Games/SDL/SDLMessageLoop.cs

@@ -137,7 +137,6 @@ public static void Run(Window form, RenderCallback renderCallback)
             if (form == null) throw new ArgumentNullException(nameof(form));
             if (renderCallback == null) throw new ArgumentNullException(nameof(renderCallback));
 
-            form.Show();
             using (var renderLoop = new SDLMessageLoop(form))
             {
                 while (renderLoop.NextFrame())

sources/engine/Stride.Graphics.Regression/GameTestBase.cs

@@ -163,6 +163,10 @@ protected GameTestBase()
 
             // by default we want the same size for the back buffer on mobiles and windows.
             BackBufferSizeMode = BackBufferSizeMode.FitToDesiredValues;
+
+            // Only make window visible in interactive mode,
+            // otherwise it's quite disrupting for user: new window might display on top and steal focus
+            MakeWindowVisibleOnRun = ForceInteractiveMode;
         }
 
         /// <inheritdoc />
@@ -189,7 +193,6 @@ protected override void Initialize()
             SceneSystem.SplashScreenEnabled = false;
         }
 
-
         /// <summary>
         ///   Saves a Texture locally or on the test server.
         /// </summary>
@@ -366,6 +369,16 @@ private void FitPresentationParametersToWindowRatio(int windowWidth, int windowH
         }
 #endif
 
+        protected override void OnWindowCreated()
+        {
+            base.OnWindowCreated();
+
+            // Disabled for SDL as a position of (0,0) actually means that the client area of the
+            // window will be at (0,0) not the top left corner of the non-client area of the window.
+            if (Context.ContextType != AppContextType.DesktopSDL)
+                Window.Position = Int2.Zero; // avoid possible side effects due to position of the window in the screen.
+        }
+
         /// <inheritdoc/>
         protected override async Task LoadContent()
         {
@@ -388,12 +401,6 @@ protected override async Task LoadContent()
             if (!ForceInteractiveMode)
                 InitializeSimulatedInputSource();
 
-#if !STRIDE_UI_SDL
-            // Disabled for SDL as a position of (0,0) actually means that the client area of the
-            // window will be at (0,0) not the top left corner of the non-client area of the window.
-            Window.Position = Int2.Zero; // avoid possible side effects due to position of the window in the screen.
-#endif
-
             Script.AddTask(RegisterTestsInternal);
 
             //