Tidy up IGNORABLE_PROPERTIES and logging #12054
Open
+19
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12054 +/- ##
============================================
- Coverage 74.91% 74.80% -0.11%
- Complexity 6454 6616 +162
============================================
Files 343 376 +33
Lines 24336 25325 +989
Branches 3207 3389 +182
============================================
+ Hits 18231 18945 +714
- Misses 4832 4994 +162
- Partials 1273 1386 +113
🚀 New features to boost your workflow:
|
tinaselenge
commented
Oct 21, 2025
| LOGGER.traceCr(reconciliation, "Current Kafka Broker Config path {} has value {}", pathValueWithoutSlash, lookupPath(source, pathValue)); | ||
| LOGGER.traceCr(reconciliation, "Desired Kafka Broker Config path {} has value {}", pathValueWithoutSlash, lookupPath(target, pathValue)); | ||
| } else { | ||
| LOGGER.debugCr(reconciliation, "Kafka Broker {} Config Differs : {}", brokerNodeRef.nodeId(), d); |
There was a problem hiding this comment.
The alternative is to move these logs into removeProperty and updateOrAdd methods providing all the necessary parameters.
Signed-off-by: Gantigmaa Selenge <[email protected]>
scholzj
reviewed
Oct 22, 2025
Comment on lines
171
to
173
| LOGGER.traceCr(reconciliation, "Kafka Broker {} Config Differs : {}", brokerNodeRef.nodeId(), d); | ||
| LOGGER.traceCr(reconciliation, "Current Kafka Broker Config path {} has value {}", pathValueWithoutSlash, lookupPath(source, pathValue)); | ||
| LOGGER.traceCr(reconciliation, "Desired Kafka Broker Config path {} has value {}", pathValueWithoutSlash, lookupPath(target, pathValue)); |
There was a problem hiding this comment.
So, with this improvement, can we now move these back to debug? They are on trace because there were too many default values. But if they should be filtered out now, maybe we can make the actual removes more visible?
There was a problem hiding this comment.
Good point! I have made the suggested change along with another improvement.
Signed-off-by: Gantigmaa Selenge <[email protected]>
When logging an entry, isReadOnly field is always to set false, which makes confusing as to why it cannot be dynamically updated Signed-off-by: Gantigmaa Selenge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Select the type of your PR
Description
Remove the custom properties that are in IGNORABLE_PROPERTIES as they get skipped using KafkaConfiguration.isCustomConfigurationOption() anyway.
The debug logs for the configuration difference include the properties that are ignorable or custom even though they are not included in the final update. The current and desired values for these properties are always different as they contain placeholders or are custom, which results in logging them all the time:
But these get skipped from the update since they are ignorable or custom.
This PR changes the condition of the logs so that properties with different desired and current values get logged only if they are not ignored or not custom, in another word, if it is a property we intend to update. So it would look like this:
The logs will no longer include ignorable or custom properties.
Checklist
Please go through this checklist and make sure all applicable tasks have been done