Skip to content

Commit 38dfcac

Browse files
committed
Do not render null if title is nil
Newsflash on Gnome and some other apps really don't like if a title is null and crash. This prevents this.
1 parent 3318d29 commit 38dfcac

File tree

2 files changed

+21
-1
lines changed

2 files changed

+21
-1
lines changed

app/models/feed.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ def as_fever_json
3030
{
3131
id:,
3232
favicon_id: 0,
33-
title: name,
33+
title: name || "",
3434
url:,
3535
site_url: url,
3636
is_spark: 0,

spec/models/feed_spec.rb

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,5 +81,25 @@
8181
last_updated_on_time: last_fetched.to_i
8282
)
8383
end
84+
85+
it "should replace a null title with an empty string" do
86+
last_fetched = 1.day.ago
87+
feed = Feed.new(
88+
id: 52,
89+
name: nil,
90+
url: "wat url",
91+
last_fetched:
92+
)
93+
94+
expect(feed.as_fever_json).to eq(
95+
id: 52,
96+
favicon_id: 0,
97+
title: "",
98+
url: "wat url",
99+
site_url: "wat url",
100+
is_spark: 0,
101+
last_updated_on_time: last_fetched.to_i
102+
)
103+
end
84104
end
85105
end

0 commit comments

Comments
 (0)