Squashed 'depend/bitcoin/' changes from fdc9f98cae..7bcb122e6e

7bcb122e6e kernel: Fix bitcoin-chainstate for windows
11ee368897 kernel: Add Purpose section to header documentation
97b95e882d kernel: Allowing reducing exports
8d9a0d084e kernel: Add pure kernel bitcoin-chainstate
cfd60cce20 kernel: Add functions to get the block hash from a block
53d1f4d41e kernel: Add block index utility functions to C header
9107931eac kernel: Add function to read block undo data from disk to C header
f9a0874d05 kernel: Add functions to read block from disk to C header
57a40f9cb0 kernel: Add function for copying block data to C header
caef1a99b8 kernel: Add functions for the block validation state to C header
4222f094ad kernel: Add validation interface to C header
f7d1d13cdd kernel: Add interrupt function to C header
0a9569d877 kernel: Add import blocks function to C header
3c626eff1f kernel: Add chainstate load options for in-memory dbs in C header
26feeed52a kernel: Add options for reindexing in C header
52de33e178 kernel: Add block validation to C header
f2e65149d5 kernel: Add chainstate loading when instantiating a ChainstateManager
956a76341d kernel: Add chainstate manager option for setting worker threads
bd00646958 kernel: Add chainstate manager object to C header
7fb35504c3 kernel: Add notifications context option to C header
521b5d918c kernel: Add chain params context option to C header
c752672060 kernel: Add kernel library context object
ff4979b22d kernel: Add logging to kernel library C header
b41eaedf91 kernel: Introduce initial kernel C header API
REVERT: fdc9f98cae kernel: Fix bitcoin-chainstate for windows
REVERT: 23d43c4e79 kernel: Add Purpose section to header documentation
REVERT: 7924a86ccf kernel: Allowing reducing exports
REVERT: 98234b1443 kernel: Add pure kernel bitcoin-chainstate
REVERT: bcacaf9f7d kernel: Add functions to get the block hash from a block
REVERT: 69d457909f kernel: Add block index utility functions to C header
REVERT: 15ab14d841 kernel: Add function to read block undo data from disk to C header
REVERT: f156e36930 kernel: Add functions to read block from disk to C header
REVERT: ec46b7d770 kernel: Add function for copying block data to C header
REVERT: 91d9e14286 kernel: Add functions for the block validation state to C header
REVERT: 41b77072d3 kernel: Add validation interface to C header
REVERT: 96bdab979e kernel: Add interrupt function to C header
REVERT: 2989cb0fa4 kernel: Add import blocks function to C header
REVERT: 1063846417 kernel: Add chainstate load options for in-memory dbs in C header
REVERT: 809e0c2441 kernel: Add options for reindexing in C header
REVERT: a1b6632702 kernel: Add block validation to C header
REVERT: 35d1e2dfbf kernel: Add chainstate loading when instantiating a ChainstateManager
REVERT: 824a5d549e kernel: Add chainstate manager option for setting worker threads
REVERT: c3bb19aaf4 kernel: Add chainstate manager object to C header
REVERT: 0d2cbf47d6 kernel: Add notifications context option to C header
REVERT: df43fd0151 kernel: Add chain params context option to C header
REVERT: 02e0874a91 kernel: Add kernel library context object
REVERT: de9bc8e47b kernel: Add logging to kernel library C header
REVERT: a771ea573b kernel: Introduce initial kernel C header API

git-subtree-dir: depend/bitcoin
git-subtree-split: 7bcb122e6e55339f25238a44433cc5aadc4526f1

Author: stringintech

src/kernel/bitcoinkernel.cpp

@@ -413,18 +413,18 @@ btck_Transaction* btck_transaction_create(const void* raw_transaction, size_t ra
     }
 }
 
-uint64_t btck_transaction_count_outputs(const btck_Transaction* transaction)
+size_t btck_transaction_count_outputs(const btck_Transaction* transaction)
 {
     return transaction->m_tx->vout.size();
 }
 
-btck_TransactionOutput* btck_transaction_get_output_at(const btck_Transaction* transaction, uint64_t output_index)
+btck_TransactionOutput* btck_transaction_get_output_at(const btck_Transaction* transaction, size_t output_index)
 {
     assert(output_index < transaction->m_tx->vout.size());
     return new btck_TransactionOutput{&transaction->m_tx->vout[output_index], false};
 }
 
-uint64_t btck_transaction_count_inputs(const btck_Transaction* transaction)
+size_t btck_transaction_count_inputs(const btck_Transaction* transaction)
 {
     return transaction->m_tx->vin.size();
 }
@@ -935,12 +935,12 @@ btck_Block* btck_block_copy(const btck_Block* block)
     return new btck_Block{block->m_block};
 }
 
-uint64_t btck_block_count_transactions(const btck_Block* block)
+size_t btck_block_count_transactions(const btck_Block* block)
 {
     return block->m_block->vtx.size();
 }
 
-btck_Transaction* btck_block_get_transaction_at(const btck_Block* block, uint64_t index)
+btck_Transaction* btck_block_get_transaction_at(const btck_Block* block, size_t index)
 {
     assert(index < block->m_block->vtx.size());
     return new btck_Transaction{block->m_block->vtx[index]};
@@ -1043,12 +1043,12 @@ btck_BlockSpentOutputs* btck_block_spent_outputs_copy(const btck_BlockSpentOutpu
     return new btck_BlockSpentOutputs{block_spent_outputs->m_block_undo};
 }
 
-uint64_t btck_block_spent_outputs_size(const btck_BlockSpentOutputs* block_spent_outputs)
+size_t btck_block_spent_outputs_count(const btck_BlockSpentOutputs* block_spent_outputs)
 {
     return block_spent_outputs->m_block_undo->vtxundo.size();
 }
 
-btck_TransactionSpentOutputs* btck_block_spent_outputs_get_transaction_spent_outputs_at(const btck_BlockSpentOutputs* block_spent_outputs, uint64_t transaction_index)
+btck_TransactionSpentOutputs* btck_block_spent_outputs_get_transaction_spent_outputs_at(const btck_BlockSpentOutputs* block_spent_outputs, size_t transaction_index)
 {
     assert(transaction_index < block_spent_outputs->m_block_undo->vtxundo.size());
     const auto* tx_undo{&block_spent_outputs->m_block_undo->vtxundo.at(transaction_index)};
@@ -1067,7 +1067,7 @@ btck_TransactionSpentOutputs* btck_transaction_spent_outputs_copy(const btck_Tra
     return new btck_TransactionSpentOutputs{new CTxUndo{*transaction_spent_outputs->m_tx_undo}, true};
 }
 
-uint64_t btck_transaction_spent_outputs_size(const btck_TransactionSpentOutputs* transaction_spent_outputs)
+size_t btck_transaction_spent_outputs_count(const btck_TransactionSpentOutputs* transaction_spent_outputs)
 {
     return transaction_spent_outputs->m_tx_undo->vprevout.size();
 }
@@ -1082,7 +1082,7 @@ void btck_transaction_spent_outputs_destroy(btck_TransactionSpentOutputs* transa
     transaction_spent_outputs = nullptr;
 }
 
-btck_Coin* btck_transaction_spent_outputs_get_coin_at(const btck_TransactionSpentOutputs* transaction_spent_outputs, uint64_t coin_index)
+btck_Coin* btck_transaction_spent_outputs_get_coin_at(const btck_TransactionSpentOutputs* transaction_spent_outputs, size_t coin_index)
 {
     assert(coin_index < transaction_spent_outputs->m_tx_undo->vprevout.size());
     const Coin* coin{&transaction_spent_outputs->m_tx_undo->vprevout.at(coin_index)};
@@ -1151,10 +1151,7 @@ btck_BlockTreeEntry* btck_chain_get_genesis(const btck_Chain* chain)
 btck_BlockTreeEntry* btck_chain_get_by_height(const btck_Chain* chain, int height)
 {
     LOCK(::cs_main);
-    if (height < 0 || height > chain->m_chain->Height()) {
-        LogDebug(BCLog::KERNEL, "Block height is out of range.");
-        return nullptr;
-    }
+    assert(height >= 0 && height <= chain->m_chain->Height());
     return new btck_BlockTreeEntry{(*chain->m_chain)[height]};
 }
 

src/kernel/bitcoinkernel.h

@@ -478,7 +478,7 @@ BITCOINKERNEL_API int btck_transaction_to_bytes(
  * @param[in] transaction Non-null.
  * @return                The number of outputs.
  */
-BITCOINKERNEL_API uint64_t BITCOINKERNEL_WARN_UNUSED_RESULT btck_transaction_count_outputs(
+BITCOINKERNEL_API size_t BITCOINKERNEL_WARN_UNUSED_RESULT btck_transaction_count_outputs(
     const btck_Transaction* transaction
 ) BITCOINKERNEL_ARG_NONNULL(1);
 
@@ -492,7 +492,7 @@ BITCOINKERNEL_API uint64_t BITCOINKERNEL_WARN_UNUSED_RESULT btck_transaction_cou
  * @return                 The transaction output
  */
 BITCOINKERNEL_API btck_TransactionOutput* BITCOINKERNEL_WARN_UNUSED_RESULT btck_transaction_get_output_at(
-    const btck_Transaction* transaction, uint64_t output_index
+    const btck_Transaction* transaction, size_t output_index
 ) BITCOINKERNEL_ARG_NONNULL(1);
 
 /**
@@ -501,7 +501,7 @@ BITCOINKERNEL_API btck_TransactionOutput* BITCOINKERNEL_WARN_UNUSED_RESULT btck_
  * @param[in] transaction Non-null.
  * @return                The number of inputs.
  */
-BITCOINKERNEL_API uint64_t BITCOINKERNEL_WARN_UNUSED_RESULT btck_transaction_count_inputs(
+BITCOINKERNEL_API size_t BITCOINKERNEL_WARN_UNUSED_RESULT btck_transaction_count_inputs(
     const btck_Transaction* transaction
 ) BITCOINKERNEL_ARG_NONNULL(1);
 
@@ -1079,7 +1079,7 @@ BITCOINKERNEL_API btck_Block* BITCOINKERNEL_WARN_UNUSED_RESULT btck_block_copy(
  * @param[in] block Non-null.
  * @return          The number of transactions in the block.
  */
-BITCOINKERNEL_API uint64_t BITCOINKERNEL_WARN_UNUSED_RESULT btck_block_count_transactions(
+BITCOINKERNEL_API size_t BITCOINKERNEL_WARN_UNUSED_RESULT btck_block_count_transactions(
     const btck_Block* block
 ) BITCOINKERNEL_ARG_NONNULL(1);
 
@@ -1092,7 +1092,7 @@ BITCOINKERNEL_API uint64_t BITCOINKERNEL_WARN_UNUSED_RESULT btck_block_count_tra
  * @return                      The transaction.
  */
 BITCOINKERNEL_API btck_Transaction* BITCOINKERNEL_WARN_UNUSED_RESULT btck_block_get_transaction_at(
-    const btck_Block* block, uint64_t transaction_index
+    const btck_Block* block, size_t transaction_index
 ) BITCOINKERNEL_ARG_NONNULL(1);
 
 /*
@@ -1207,8 +1207,7 @@ BITCOINKERNEL_API btck_BlockTreeEntry* BITCOINKERNEL_WARN_UNUSED_RESULT btck_cha
  *
  * @param[in] chain        Non-null.
  * @param[in] block_height Height in the chain of the to be retrieved block tree entry.
- * @return                 The block tree entry at a certain height in the currently active chain,
- *                         or null if the height is out of bounds.
+ * @return                 The block tree entry at a certain height in the currently active chain.
  */
 BITCOINKERNEL_API btck_BlockTreeEntry* BITCOINKERNEL_WARN_UNUSED_RESULT btck_chain_get_by_height(
     const btck_Chain* chain,
@@ -1285,7 +1284,7 @@ BITCOINKERNEL_API btck_BlockSpentOutputs* BITCOINKERNEL_WARN_UNUSED_RESULT btck_
  * @param[in] block_spent_outputs Non-null.
  * @return                        The number of transaction spent outputs data in the block spent outputs.
  */
-BITCOINKERNEL_API uint64_t BITCOINKERNEL_WARN_UNUSED_RESULT btck_block_spent_outputs_size(
+BITCOINKERNEL_API size_t BITCOINKERNEL_WARN_UNUSED_RESULT btck_block_spent_outputs_count(
     const btck_BlockSpentOutputs* block_spent_outputs
 ) BITCOINKERNEL_ARG_NONNULL(1);
 
@@ -1300,7 +1299,7 @@ BITCOINKERNEL_API uint64_t BITCOINKERNEL_WARN_UNUSED_RESULT btck_block_spent_out
  */
 BITCOINKERNEL_API btck_TransactionSpentOutputs* BITCOINKERNEL_WARN_UNUSED_RESULT btck_block_spent_outputs_get_transaction_spent_outputs_at(
     const btck_BlockSpentOutputs* block_spent_outputs,
-    uint64_t transaction_spent_outputs_index) BITCOINKERNEL_ARG_NONNULL(1);
+    size_t transaction_spent_outputs_index) BITCOINKERNEL_ARG_NONNULL(1);
 
 /**
  * Destroy the block spent outputs.
@@ -1331,7 +1330,7 @@ BITCOINKERNEL_API btck_TransactionSpentOutputs* BITCOINKERNEL_WARN_UNUSED_RESULT
  * @param[in] transaction_spent_outputs Non-null
  * @return                              The number of spent transaction outputs for the transaction.
  */
-BITCOINKERNEL_API uint64_t BITCOINKERNEL_WARN_UNUSED_RESULT btck_transaction_spent_outputs_size(
+BITCOINKERNEL_API size_t BITCOINKERNEL_WARN_UNUSED_RESULT btck_transaction_spent_outputs_count(
     const btck_TransactionSpentOutputs* transaction_spent_outputs
 ) BITCOINKERNEL_ARG_NONNULL(1);
 
@@ -1347,7 +1346,7 @@ BITCOINKERNEL_API uint64_t BITCOINKERNEL_WARN_UNUSED_RESULT btck_transaction_spe
  */
 BITCOINKERNEL_API btck_Coin* BITCOINKERNEL_WARN_UNUSED_RESULT btck_transaction_spent_outputs_get_coin_at(
     const btck_TransactionSpentOutputs* transaction_spent_outputs,
-    uint64_t coin_index) BITCOINKERNEL_ARG_NONNULL(1);
+    size_t coin_index) BITCOINKERNEL_ARG_NONNULL(1);
 
 /**
  * Destroy the transaction spent outputs.