Add SetLoggingOptions() to configure options globally

Also adapt `NewLoggingConnection()` and its usages

Author: stringintech

kernel/logging_connection.go

@@ -51,21 +51,12 @@ func go_log_callback_bridge(user_data unsafe.Pointer, message *C.char, message_l
 //
 // Parameters:
 //   - callback: Function that will receive log messages
-//   - options: Formatting options for log messages (timestamps, thread names, etc.)
 //
 // Returns an error if the logging connection cannot be created.
-func NewLoggingConnection(callback LogCallback, options LoggingOptions) (*LoggingConnection, error) {
-	cOptions := C.btck_LoggingOptions{
-		log_timestamps:               boolToInt(options.LogTimestamps),
-		log_time_micros:              boolToInt(options.LogTimeMicros),
-		log_threadnames:              boolToInt(options.LogThreadNames),
-		log_sourcelocations:          boolToInt(options.LogSourceLocations),
-		always_print_category_levels: boolToInt(options.AlwaysPrintCategoryLevel),
-	}
-
+func NewLoggingConnection(callback LogCallback) (*LoggingConnection, error) {
 	callbackHandle := cgo.NewHandle(callback)
 	ptr := C.btck_logging_connection_create((C.btck_LogCallback)(C.go_log_callback_bridge),
-		unsafe.Pointer(callbackHandle), C.btck_DestroyCallback(C.go_delete_handle), cOptions)
+		unsafe.Pointer(callbackHandle), C.btck_DestroyCallback(C.go_delete_handle))
 	if ptr == nil {
 		callbackHandle.Delete()
 		return nil, &InternalError{"Failed to create logging connection"}
@@ -74,6 +65,23 @@ func NewLoggingConnection(callback LogCallback, options LoggingOptions) (*Loggin
 	return &LoggingConnection{uniqueHandle: h}, nil
 }
 
+// SetLoggingOptions configures the formatting options for the global internal logger.
+//
+// This changes global settings and affects all existing LoggingConnection instances.
+//
+// Parameters:
+//   - options: Formatting options for log messages (timestamps, thread names, etc.)
+func SetLoggingOptions(options LoggingOptions) {
+	cOptions := C.btck_LoggingOptions{
+		log_timestamps:               boolToInt(options.LogTimestamps),
+		log_time_micros:              boolToInt(options.LogTimeMicros),
+		log_threadnames:              boolToInt(options.LogThreadNames),
+		log_sourcelocations:          boolToInt(options.LogSourceLocations),
+		always_print_category_levels: boolToInt(options.AlwaysPrintCategoryLevel),
+	}
+	C.btck_logging_set_options(cOptions)
+}
+
 // DisableLogging permanently disables the global internal logger.
 //
 // No log messages will be buffered internally after this is called, and the buffer

kernel/logging_connection_test.go

@@ -44,7 +44,8 @@ func TestLoggingOptions(t *testing.T) {
 
 	for _, tc := range testCases {
 		t.Run(tc.name, func(t *testing.T) {
-			conn, err := NewLoggingConnection(func(_ string) {}, tc.options)
+			SetLoggingOptions(tc.options)
+			conn, err := NewLoggingConnection(func(_ string) {})
 			if err != nil {
 				t.Fatalf("NewLoggingConnection() error = %v", err)
 			}

utils/logger.go

@@ -27,8 +27,11 @@ func NewLogger(handler slog.Handler, options kernel.LoggingOptions) (*Logger, er
 		parser: parser,
 	}
 
+	// Set global logging options
+	kernel.SetLoggingOptions(options)
+
 	// Create logging connection with our message handler
-	conn, err := kernel.NewLoggingConnection(viewer.handleMessage, options)
+	conn, err := kernel.NewLoggingConnection(viewer.handleMessage)
 	if err != nil {
 		return nil, fmt.Errorf("failed to create logging connection: %w", err)
 	}