Add Transaction

Author: stringintech

TODO.md

@@ -19,7 +19,6 @@ This document lists the remaining C API functions and data structures from `bitc
 ## Missing Data Structures
 
 ### Core Transaction Types
-- **`kernel_Transaction`** - Transaction handling
 - **`kernel_ScriptPubkey`** - Script public key operations  
 - **`kernel_TransactionOutput`** - Transaction output operations
 - **`kernel_BlockPointer`** - Non-owned block pointers (from callbacks)
@@ -28,10 +27,6 @@ This document lists the remaining C API functions and data structures from `bitc
 
 ## Missing Functions by Category
 
-### Transaction Operations
-- [ ] `kernel_transaction_create()` - Create transaction from serialized data
-- [ ] `kernel_transaction_destroy()` - Cleanup transaction
-
 ### Script Operations
 - [ ] `kernel_script_pubkey_create()` - Create script pubkey
 - [ ] `kernel_script_pubkey_destroy()` - Cleanup script pubkey  
@@ -56,9 +51,6 @@ This document lists the remaining C API functions and data structures from `bitc
 - [ ] `kernel_get_undo_output_by_index()` - Get specific undo output
 - [ ] `kernel_block_undo_destroy()` - Cleanup undo data
 
-### Utility Operations
-- [ ] `kernel_byte_array_destroy()` - Cleanup byte arrays
-
 ### Callback Support
 - [ ] **Notification callbacks** - Full integration of kernel notification system
 - [ ] **Validation interface callbacks** - Block validation event handling

kernel/errors.go

@@ -19,4 +19,6 @@ var (
 	ErrBlockRead                        = errors.New("failed to read block from disk")
 	ErrInvalidCallback                  = errors.New("invalid callback function")
 	ErrLoggingConnectionCreation        = errors.New("failed to create logging connection")
+	ErrTransactionCreation              = errors.New("failed to create transaction from raw data")
+	ErrInvalidTransactionData           = errors.New("invalid transaction data")
 )

kernel/transaction.go

@@ -0,0 +1,43 @@
+package kernel
+
+/*
+#include "kernel/bitcoinkernel.h"
+*/
+import "C"
+import (
+	"runtime"
+	"unsafe"
+)
+
+// Transaction wraps the C kernel_Transaction
+type Transaction struct {
+	ptr *C.kernel_Transaction
+}
+
+// NewTransactionFromRaw creates a new transaction from raw serialized data
+func NewTransactionFromRaw(rawTransaction []byte) (*Transaction, error) {
+	if len(rawTransaction) == 0 {
+		return nil, ErrInvalidTransactionData
+	}
+
+	ptr := C.kernel_transaction_create((*C.uchar)(unsafe.Pointer(&rawTransaction[0])), C.size_t(len(rawTransaction)))
+	if ptr == nil {
+		return nil, ErrTransactionCreation
+	}
+
+	transaction := &Transaction{ptr: ptr}
+	runtime.SetFinalizer(transaction, (*Transaction).destroy)
+	return transaction, nil
+}
+
+func (t *Transaction) destroy() {
+	if t.ptr != nil {
+		C.kernel_transaction_destroy(t.ptr)
+		t.ptr = nil
+	}
+}
+
+func (t *Transaction) Destroy() {
+	runtime.SetFinalizer(t, nil)
+	t.destroy()
+}

kernel/transaction_test.go

@@ -0,0 +1,42 @@
+package kernel
+
+import (
+	"encoding/hex"
+	"errors"
+	"testing"
+)
+
+func TestInvalidTransactionData(t *testing.T) {
+	// Test with empty data
+	_, err := NewTransactionFromRaw([]byte{})
+	if !errors.Is(err, ErrInvalidTransactionData) {
+		t.Errorf("Expected ErrInvalidTransactionData, got %v", err)
+	}
+
+	// Test with invalid data
+	_, err = NewTransactionFromRaw([]byte{0x00, 0x01, 0x02})
+	if !errors.Is(err, ErrTransactionCreation) {
+		t.Errorf("Expected ErrTransactionCreation, got %v", err)
+	}
+}
+
+func TestTransactionFromRaw(t *testing.T) {
+	txHex := "01000000010000000000000000000000000000000000000000000000000000000000000000ffffffff08044c86041b020602ffffffff0100f2052a010000004341041b0e8c2567c12536aa13357b79a073dc4444acb83c4ec7a0e2f99dd7457516c5817242da796924ca4e99947d087fedf9ce467cb9f7c6287078f801df276fdf84ac00000000"
+	txBytes, err := hex.DecodeString(txHex)
+	if err != nil {
+		t.Fatalf("Failed to decode transaction hex: %v", err)
+	}
+
+	tx, err := NewTransactionFromRaw(txBytes)
+	if err != nil {
+		t.Fatalf("NewTransactionFromRaw() error = %v", err)
+	}
+	if tx == nil {
+		t.Fatal("Transaction is nil")
+	}
+	defer tx.Destroy()
+
+	if tx.ptr == nil {
+		t.Error("Transaction pointer is nil")
+	}
+}