Use pgx escape identifier (#256)

bplunkett-stripe · web-flow · commit 82998c34f797 · 2025-12-30T15:34:28.000-05:00
diff --git a/internal/schema/schema.go b/internal/schema/schema.go
@@ -9,6 +9,7 @@ import (
 	"sort"
 	"strings"
 
+	"github.com/jackc/pgx/v4"
 	"github.com/mitchellh/hashstructure/v2"
 	"github.com/stripe/pg-schema-diff/internal/concurrent"
 	"github.com/stripe/pg-schema-diff/internal/queries"
@@ -1519,7 +1520,7 @@ func FQEscapedColumnName(table SchemaQualifiedName, columnName string) string {
 }
 
 func EscapeIdentifier(name string) string {
-	return fmt.Sprintf("\"%s\"", name)
+	return pgx.Identifier{name}.Sanitize()
 }
 
 // relOptionsToMap converts pg_catalog.pg_class.reloptions to a map.

Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,7 @@ import (`
`9`	`9`	`"sort"`
`10`	`10`	`"strings"`
`11`	`11`
	`12`	`+ "github.com/jackc/pgx/v4"`
`12`	`13`	`"github.com/mitchellh/hashstructure/v2"`
`13`	`14`	`"github.com/stripe/pg-schema-diff/internal/concurrent"`
`14`	`15`	`"github.com/stripe/pg-schema-diff/internal/queries"`
`@@ -1519,7 +1520,7 @@ func FQEscapedColumnName(table SchemaQualifiedName, columnName string) string {`
`1519`	`1520`	`}`
`1520`	`1521`
`1521`	`1522`	`func EscapeIdentifier(name string) string {`
`1522`		`- return fmt.Sprintf("\"%s\"", name)`
	`1523`	`+ return pgx.Identifier{name}.Sanitize()`
`1523`	`1524`	`}`
`1524`	`1525`
`1525`	`1526`	`// relOptionsToMap converts pg_catalog.pg_class.reloptions to a map.`