Add basic view support (#226)

Author: bplunkett-stripe

.sqlfluff

@@ -1,6 +1,7 @@
 [sqlfluff]
 dialect = postgres
 templater = placeholder
+large_file_skip_byte_limit = 0
 
 [sqlfluff:templater:placeholder]
 param_regex = sqlc.arg\(.*\)

README.md

@@ -176,7 +176,7 @@ Unsupported: <= 13  are not supported. Use at your own risk.
 
 # Unsupported migrations
 An abridged list of unsupported migrations:
-- Views (Planned)
+- Materialized Views (Planned); Views **are** supported
 - Privileges (Planned)
 - Types (Only enums are currently supported)
 - Renaming. The diffing library relies on names to identify the old and new versions of a table, index, etc. If you rename

cmd/pg-schema-diff/datastructs.go

@@ -3,6 +3,8 @@ package main
 import (
 	"fmt"
 	"sort"
+
+	"github.com/stripe/pg-schema-diff/internal/util"
 )
 
 func mustGetAndDeleteKey(m map[string]string, key string) (string, error) {
@@ -15,10 +17,7 @@ func mustGetAndDeleteKey(m map[string]string, key string) (string, error) {
 }
 
 func keys(m map[string]string) []string {
-	var vals []string
-	for k := range m {
-		vals = append(vals, k)
-	}
+	vals := util.Keys(m)
 	sort.Strings(vals)
 	return vals
 }

cmd/pg-schema-diff/datastructs_test.go

@@ -89,6 +89,16 @@ var schemaAcceptanceTests = []acceptanceTestCase{
                             RAISE NOTICE 'foobar';
                     END;
             $$ LANGUAGE plpgsql;
+
+            CREATE VIEW schema_1.foobar_view AS
+                SELECT id, foo, fizz 
+                FROM schema_1.foobar
+                WHERE LENGTH(foo) > 10;
+
+            CREATE VIEW public_bar_view AS
+                SELECT bar, foo, fizz, buzz
+                FROM bar
+                WHERE buzz > 0.5;
 			`,
 		},
 		newSchemaDDL: []string{
@@ -170,6 +180,16 @@ var schemaAcceptanceTests = []acceptanceTestCase{
                             RAISE NOTICE 'foobar';
                     END;
             $$ LANGUAGE plpgsql;
+
+            CREATE VIEW schema_1.foobar_view AS
+                SELECT id, foo, fizz 
+                FROM schema_1.foobar
+                WHERE LENGTH(foo) > 10;
+
+            CREATE VIEW public_bar_view AS
+                SELECT bar, foo, fizz, buzz
+                FROM bar
+                WHERE buzz > 0.5;
 			`,
 		},
 		expectEmptyPlan: true,
@@ -360,6 +380,16 @@ var schemaAcceptanceTests = []acceptanceTestCase{
                 BEFORE UPDATE ON schema_2.bar
                 FOR EACH ROW
                 EXECUTE FUNCTION check_content();
+
+            CREATE VIEW schema_2.new_table_view AS
+                SELECT id, version, new_foo, new_bar
+                FROM "New_table"
+                WHERE version > 0;
+
+            CREATE VIEW schema_3.bar_summary AS
+                SELECT fizz, buzz, COUNT(*) as count
+                FROM schema_2.bar
+                GROUP BY fizz, buzz;
 			`,
 		},
 		expectedHazardTypes: []diff.MigrationHazardType{