fix: match api urls with version path (#1297)

Author: charliecruzan-stripe

pkg/stripe/url.go

@@ -8,6 +8,7 @@ import (
 const (
 	// DefaultAPIBaseURL is the default base URL for API requests
 	DefaultAPIBaseURL   = "https://api.stripe.com"
+	APIBaseURLRegexp    = `^https:\/\/api\.stripe\.com\/v\d+$`
 	qaAPIBaseURL        = "https://qa-api.stripe.com"
 	devAPIBaseURLRegexp = `http(s)?:\/\/[A-Za-z0-9\-]+api-mydev.dev.stripe.me`
 
@@ -46,7 +47,7 @@ func isValid(url string, exactStrings []string, regexpStrings []string) bool {
 // ValidateAPIBaseURL returns an error if apiBaseURL isn't allowed
 func ValidateAPIBaseURL(apiBaseURL string) error {
 	exactStrings := []string{DefaultAPIBaseURL, qaAPIBaseURL}
-	regexpStrings := []string{devAPIBaseURLRegexp, localhostURLRegexp}
+	regexpStrings := []string{APIBaseURLRegexp, devAPIBaseURLRegexp, localhostURLRegexp}
 	if isValid(apiBaseURL, exactStrings, regexpStrings) {
 		return nil
 	}

pkg/stripe/url_test.go

@@ -8,6 +8,9 @@ import (
 
 func TestValidateAPIBaseURLWorks(t *testing.T) {
 	assert.Nil(t, ValidateAPIBaseURL("https://api.stripe.com"))
+	assert.Nil(t, ValidateAPIBaseURL("https://api.stripe.com/v1"))
+	assert.Nil(t, ValidateAPIBaseURL("https://api.stripe.com/v2"))
+	assert.Nil(t, ValidateAPIBaseURL("https://api.stripe.com/v100"))
 	assert.Nil(t, ValidateAPIBaseURL("https://qa-api.stripe.com"))
 	assert.Nil(t, ValidateAPIBaseURL("http://foo-api-mydev.dev.stripe.me"))
 	assert.Nil(t, ValidateAPIBaseURL("https://foo-lv5r9y--api-mydev.dev.stripe.me/"))
@@ -18,6 +21,7 @@ func TestValidateAPIBaseURLWorks(t *testing.T) {
 	assert.ErrorIs(t, ValidateAPIBaseURL("https://unknowndomain"), errInvalidAPIBaseURL)
 	assert.ErrorIs(t, ValidateAPIBaseURL("localhost"), errInvalidAPIBaseURL)
 	assert.ErrorIs(t, ValidateAPIBaseURL("anything_else"), errInvalidAPIBaseURL)
+	assert.ErrorIs(t, ValidateAPIBaseURL("https://api.stripe.com/v1.1"), errInvalidAPIBaseURL)
 }
 
 func TestValidateDashboardBaseURLWorks(t *testing.T) {