Fix update on Embedded Android (#2260)

* Add a switch to test updating

* Make updating nicer looking

* Fix update on Android

* Fix build on Android old arch

* Add update test

Author: porter-stripe

CHANGELOG.md

@@ -1,5 +1,10 @@
 # CHANGELOG
 
+## x.x.x - x-x-x
+
+**Fixes**
+- Fixed `update()` not working on Android for EmbeddedPaymentElement. The intent configuration is now properly passed to the native side when calling `update()`.
+
 ## 0.57.1 - 2025-12-11
 **Fixes**
 - Fixed Android crash `NoSuchKeyException: customFlow` when initializing PaymentSheet without explicitly setting the `customFlow` parameter.

android/src/main/java/com/reactnativestripesdk/EmbeddedPaymentElementView.kt

@@ -54,6 +54,10 @@ class EmbeddedPaymentElementView(
       val intentConfiguration: PaymentSheet.IntentConfiguration,
     ) : Event
 
+    data class Update(
+      val intentConfiguration: PaymentSheet.IntentConfiguration,
+    ) : Event
+
     data object Confirm : Event
 
     data object ClearPaymentOption : Event
@@ -322,6 +326,47 @@ class EmbeddedPaymentElementView(
             }
           }
 
+          is Event.Update -> {
+            val elemConfig = latestElementConfig
+            if (elemConfig == null) {
+              val payload =
+                Arguments.createMap().apply {
+                  putString("message", "Cannot update: no element configuration exists")
+                }
+              requireStripeSdkModule().eventEmitter.emitEmbeddedPaymentElementLoadingFailed(payload)
+              requireStripeSdkModule().eventEmitter.emitEmbeddedPaymentElementUpdateComplete(null)
+              return@collect
+            }
+
+            val result =
+              embedded.configure(
+                intentConfiguration = ev.intentConfiguration,
+                configuration = elemConfig,
+              )
+
+            when (result) {
+              is EmbeddedPaymentElement.ConfigureResult.Succeeded -> {
+                val payload =
+                  Arguments.createMap().apply {
+                    putString("status", "succeeded")
+                  }
+                requireStripeSdkModule().eventEmitter.emitEmbeddedPaymentElementUpdateComplete(payload)
+              }
+              is EmbeddedPaymentElement.ConfigureResult.Failed -> {
+                val err = result.error
+                val msg = err.localizedMessage ?: err.toString()
+                val failPayload =
+                  Arguments.createMap().apply {
+                    putString("message", msg)
+                  }
+                requireStripeSdkModule().eventEmitter.emitEmbeddedPaymentElementLoadingFailed(failPayload)
+                requireStripeSdkModule().eventEmitter.emitEmbeddedPaymentElementUpdateComplete(null)
+              }
+            }
+
+            latestIntentConfig = ev.intentConfiguration
+          }
+
           is Event.Confirm -> {
             embedded.confirm()
           }
@@ -412,6 +457,10 @@ class EmbeddedPaymentElementView(
     events.trySend(Event.Configure(config, intentConfig))
   }
 
+  fun update(intentConfig: PaymentSheet.IntentConfiguration) {
+    events.trySend(Event.Update(intentConfig))
+  }
+
   fun confirm() {
     events.trySend(Event.Confirm)
   }

android/src/main/java/com/reactnativestripesdk/EmbeddedPaymentElementViewManager.kt

@@ -2,8 +2,11 @@ package com.reactnativestripesdk
 
 import android.annotation.SuppressLint
 import android.content.Context
+import com.facebook.react.bridge.Arguments
 import com.facebook.react.bridge.Dynamic
 import com.facebook.react.bridge.ReadableMap
+import com.facebook.react.bridge.WritableArray
+import com.facebook.react.bridge.WritableMap
 import com.facebook.react.module.annotations.ReactModule
 import com.facebook.react.uimanager.ThemedReactContext
 import com.facebook.react.uimanager.ViewGroupManager
@@ -23,6 +26,8 @@ import com.stripe.android.ExperimentalAllowsRemovalOfLastSavedPaymentMethodApi
 import com.stripe.android.paymentelement.EmbeddedPaymentElement
 import com.stripe.android.paymentelement.ExperimentalCustomPaymentMethodsApi
 import com.stripe.android.paymentsheet.PaymentSheet
+import org.json.JSONArray
+import org.json.JSONObject
 
 @ReactModule(name = EmbeddedPaymentElementViewManager.NAME)
 class EmbeddedPaymentElementViewManager :
@@ -178,6 +183,62 @@ class EmbeddedPaymentElementViewManager :
   override fun clearPaymentOption(view: EmbeddedPaymentElementView) {
     view.clearPaymentOption()
   }
+
+  override fun update(
+    view: EmbeddedPaymentElementView,
+    intentConfigurationJson: String?,
+  ) {
+    intentConfigurationJson?.let { json ->
+      try {
+        val jsonObject = JSONObject(json)
+        val cfg = jsonToWritableMap(jsonObject)
+        val intentConfig = buildIntentConfiguration(cfg)
+        if (intentConfig != null) {
+          view.update(intentConfig)
+        }
+      } catch (e: Exception) {
+        android.util.Log.e("EmbeddedPaymentElement", "Failed to parse intent config JSON", e)
+      }
+    }
+  }
+
+  private fun jsonToWritableMap(json: JSONObject): WritableMap {
+    val map = Arguments.createMap()
+    val keys = json.keys()
+    while (keys.hasNext()) {
+      val key = keys.next()
+      when (val value = json.get(key)) {
+        is Boolean -> map.putBoolean(key, value)
+        is Int -> map.putInt(key, value)
+        is Double -> map.putDouble(key, value)
+        is Long -> map.putDouble(key, value.toDouble())
+        is String -> map.putString(key, value)
+        is JSONObject -> map.putMap(key, jsonToWritableMap(value))
+        is JSONArray -> map.putArray(key, jsonToWritableArray(value))
+        JSONObject.NULL -> map.putNull(key)
+        else -> map.putString(key, value.toString())
+      }
+    }
+    return map
+  }
+
+  private fun jsonToWritableArray(json: JSONArray): WritableArray {
+    val array = Arguments.createArray()
+    for (i in 0 until json.length()) {
+      when (val value = json.get(i)) {
+        is Boolean -> array.pushBoolean(value)
+        is Int -> array.pushInt(value)
+        is Double -> array.pushDouble(value)
+        is Long -> array.pushDouble(value.toDouble())
+        is String -> array.pushString(value)
+        is JSONObject -> array.pushMap(jsonToWritableMap(value))
+        is JSONArray -> array.pushArray(jsonToWritableArray(value))
+        JSONObject.NULL -> array.pushNull()
+        else -> array.pushString(value.toString())
+      }
+    }
+    return array
+  }
 }
 
 internal fun mapToRowSelectionBehaviorType(map: ReadableMap?): RowSelectionBehaviorType {

android/src/main/java/com/reactnativestripesdk/EventEmitterCompat.kt

@@ -84,6 +84,10 @@ class EventEmitterCompat(
     invoke("embeddedPaymentElementLoadingFailed", value)
   }
 
+  fun emitEmbeddedPaymentElementUpdateComplete(value: ReadableMap?) {
+    invoke("embeddedPaymentElementUpdateComplete", value)
+  }
+
   fun emitOnCustomPaymentMethodConfirmHandlerCallback(value: ReadableMap?) {
     invoke("onCustomPaymentMethodConfirmHandlerCallback", value)
   }

android/src/oldarch/java/com/facebook/react/viewmanagers/EmbeddedPaymentElementViewManagerDelegate.java

@@ -44,6 +44,9 @@ public void receiveCommand(T view, String commandName, @Nullable ReadableArray a
       case "clearPaymentOption":
         mViewManager.clearPaymentOption(view);
         break;
+      case "update":
+        mViewManager.update(view, args != null ? args.getString(0) : null);
+        break;
     }
   }
 }

android/src/oldarch/java/com/facebook/react/viewmanagers/EmbeddedPaymentElementViewManagerInterface.java

@@ -10,11 +10,13 @@
 package com.facebook.react.viewmanagers;
 
 import android.view.View;
+import androidx.annotation.Nullable;
 import com.facebook.react.bridge.Dynamic;
 
 public interface EmbeddedPaymentElementViewManagerInterface<T extends View>  {
   void setConfiguration(T view, Dynamic value);
   void setIntentConfiguration(T view, Dynamic value);
   void confirm(T view);
   void clearPaymentOption(T view);
+  void update(T view, @Nullable String intentConfigurationJson);
 }

e2e-tests/embedded-discount-toggle.yml

@@ -0,0 +1,48 @@
+# Test embedded payment element with discount toggle
+appId: ${APP_ID}
+---
+- launchApp:
+    clearState: true
+- tapOn: "Accept a payment"
+- tapOn: "Prebuilt UI (EmbeddedPaymentElement)"
+- extendedWaitUntil:
+    visible: "Card"
+    timeout: 150000
+# Toggle the discount switch
+- tapOn:
+    id: "discount_toggle_switch"
+# Wait for update to complete (updating overlay disappears)
+- extendedWaitUntil:
+    notVisible: "Updating..."
+    timeout: 30000
+- tapOn:
+    text: "Card"
+- tapOn:
+    text: "Card number"
+- inputText: "4242424242424242"
+- inputText: "0145"
+- inputText: "123"
+- scrollUntilVisible:
+    element:
+      id: primary_button # Android
+    optional: true
+- scrollUntilVisible:
+    element:
+      text: "Continue" # iOS
+    optional: true
+
+- tapOn:
+    id: primary_button # Android
+    optional: true
+- tapOn:
+    text: "Continue" # iOS
+    optional: true
+
+- scrollUntilVisible:
+    element:
+      text: "Complete payment"
+    timeout: 30000
+- tapOn: "Complete payment"
+- assertVisible:
+    text: "Success"
+- tapOn: "OK"

e2e-tests/embedded.yml

@@ -20,16 +20,21 @@ appId: ${APP_ID}
     optional: true
 - scrollUntilVisible:
     element:
-      text: "Pay $60.99" # iOS
+      text: "Continue" # iOS
     optional: true
 
 - tapOn:
     id: primary_button # Android
     optional: true
 - tapOn:
-    text: "Pay $60.99" # iOS
+    text: "Continue" # iOS
     optional: true
 
+- scrollUntilVisible:
+    element:
+      text: "Complete payment"
+    timeout: 30000
+- tapOn: "Complete payment"
 - assertVisible:
     text: "Success"
 - tapOn: "OK"

example/ios/Podfile.lock

@@ -1826,7 +1826,7 @@ PODS:
     - StripePayments (= 25.0.1)
     - StripePaymentsUI (= 25.0.1)
     - StripeUICore (= 25.0.1)
-  - stripe-react-native (0.57.0):
+  - stripe-react-native (0.57.1):
     - hermes-engine
     - RCTRequired
     - RCTTypeSafety
@@ -1847,10 +1847,10 @@ PODS:
     - ReactCommon/turbomodule/bridging
     - ReactCommon/turbomodule/core
     - ReactNativeDependencies
-    - stripe-react-native/Core (= 0.57.0)
-    - stripe-react-native/NewArch (= 0.57.0)
+    - stripe-react-native/Core (= 0.57.1)
+    - stripe-react-native/NewArch (= 0.57.1)
     - Yoga
-  - stripe-react-native/Core (0.57.0):
+  - stripe-react-native/Core (0.57.1):
     - hermes-engine
     - RCTRequired
     - RCTTypeSafety
@@ -1878,7 +1878,7 @@ PODS:
     - StripePaymentSheet (~> 25.0.1)
     - StripePaymentsUI (~> 25.0.1)
     - Yoga
-  - stripe-react-native/NewArch (0.57.0):
+  - stripe-react-native/NewArch (0.57.1):
     - hermes-engine
     - RCTRequired
     - RCTTypeSafety
@@ -1900,7 +1900,7 @@ PODS:
     - ReactCommon/turbomodule/core
     - ReactNativeDependencies
     - Yoga
-  - stripe-react-native/Onramp (0.57.0):
+  - stripe-react-native/Onramp (0.57.1):
     - hermes-engine
     - RCTRequired
     - RCTTypeSafety
@@ -1924,7 +1924,7 @@ PODS:
     - stripe-react-native/Core
     - StripeCryptoOnramp (~> 25.0.1)
     - Yoga
-  - stripe-react-native/Tests (0.57.0):
+  - stripe-react-native/Tests (0.57.1):
     - hermes-engine
     - RCTRequired
     - RCTTypeSafety
@@ -2306,7 +2306,7 @@ SPEC CHECKSUMS:
   RNCPicker: c8a3584b74133464ee926224463fcc54dfdaebca
   RNScreens: 61c18865ab074f4d995ac8d7cf5060522a649d05
   Stripe: 4728e3e0dd8df134e4a420ab504e929a93a815f0
-  stripe-react-native: 9045e39ccb93b1c7a4e442d22dcbb6754ed1950c
+  stripe-react-native: 366d481c8572dcc8a93f6401d8de31de6a5cce04
   StripeApplePay: 43997281ace138a1c75a8f2d7be11925ea28644c
   StripeCameraCore: e61d13cf270c450e699b12857dc75edc55a8455c
   StripeCore: 457c30e2fd3a7c4b274a5ad53d1ff03661eef2a0
@@ -2317,8 +2317,8 @@ SPEC CHECKSUMS:
   StripePaymentSheet: 3f93ce6ea84afde770d3c7e18a9b8f99aed63896
   StripePaymentsUI: 626726a01255a6458c35436f7f6431dacee82684
   StripeUICore: 30f8352fd7a5cf1541b7777a57b3ad1133bf6763
-  Yoga: 5934998fbeaef7845dbf698f698518695ab4cd1a
+  Yoga: 3fd22c2cae22d7a2b0f0b538f55f7c2a17dc94d5
 
 PODFILE CHECKSUM: 605f3cad878b7c0eee93ebb4a78a8141d34cd328
 
-COCOAPODS: 1.15.2
+COCOAPODS: 1.16.2