Skip to content

Commit 56d5017

Browse files
authored
Merge pull request #1754 from stripe/jar/explicit-install-in-ci
2 parents f267344 + 9bb3ecf commit 56d5017

File tree

3 files changed

+17
-4
lines changed

3 files changed

+17
-4
lines changed

.github/workflows/ci.yml

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,17 @@ jobs:
4444
name: Test (${{ matrix.ruby-version }})
4545
# this version of jruby isn't available in the new latest (24.04) so we have to pin (or update jruby)
4646
runs-on: ubuntu-22.04
47+
continue-on-error: ${{ matrix.dev-build }}
4748
strategy:
4849
matrix:
4950
# following https://docs.stripe.com/sdks/versioning?lang=ruby#stripe-sdk-language-version-support-policy
50-
ruby-version: [2.6, 2.7, '3.0', 3.1, 3.2, 3.3, 3.4, jruby-9.4.0.0, truffleruby-head]
51+
ruby-version: [2.6, 2.7, '3.0', 3.1, 3.2, 3.3, 3.4, jruby-9.4.0.0, truffleruby-25.0.0]
52+
dev-build: [false]
53+
include:
54+
# truffleruby-head refers to a dev build which could cause breakage between releases
55+
- ruby-version: truffleruby-head
56+
dev-build: true
57+
5158
steps:
5259
- uses: extractions/setup-just@v2
5360
- uses: actions/checkout@v3
@@ -57,7 +64,13 @@ jobs:
5764
ruby-version: ${{ matrix.ruby-version }}
5865
- uses: stripe/openapi/actions/stripe-mock@master
5966
- name: test
60-
run: just test typecheck
67+
run: |
68+
if ! just test typecheck 2> /dev/null; then
69+
if [[ ${{ matrix.ruby-version }} == "truffleruby-head" ]]; then
70+
echo "just test typecheck FAILED on truffleruby-head. intermittent failures may happen with this dev build, but we should keep an eye on this"
71+
fi
72+
exit 1
73+
fi
6174
env:
6275
GITHUB_TOKEN: ${{ secrets.github_token }}
6376

CODEGEN_VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
88aa59022b32620f4d66d6196e3b42d5a0f86bbb
1+
5abe0e44caedb3474ee672265284096ec89e0fa3

justfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ _default:
66
just --list --unsorted
77

88
install *args:
9-
bundle install {{ if is_dependency() == "true" {"--quiet"} else {""} }} {{ args }}
9+
bundle install {{ if is_dependency() == "true" {"--quiet"} else {"--verbose"} }} {{ args }}
1010

1111
# ⭐ run all unit tests
1212
test: install

0 commit comments

Comments
 (0)