fix: Image upload works when mixed within links

The image handling code for uploading was written in a way such that if
there were links _after_ the image, the image handling wouldn't work.

Author: stroiman

README.md

@@ -180,26 +180,27 @@ I need to explain more about [medialinks](http://example.com/medialink).
 p.s. I have not tested how this works, if you have configured Obsidian to use
 markdown links instead of medialinks.
 
-## Missing features
+> [!WARNING] 
+> This feature does not work for medialinks in a footnote due to a [bug in the
+> Obsidian API](https://github.com/obsidianmd/obsidian-api/issues/166).
+
+## Desired features
 
 ### Essential
 
-- Handle images.
-- Allows the user to specify tags (the DEV tags would probably be kept separate
-  from Obsidian tags initially, but perhaps user configurable over time).
-- Securely handle API keys through system keychain/secure storage (although some
+* Securely handle API keys through system keychain/secure storage (although some
   research seems to indicate that this is not possible).
+* Better image handling. DEV doesn't support image upload through the API,
+  requiring you to upload them manually, and configure the mapping in the
+  frontmatter.
+  * One possibility is to upload to another site, or AWS S3 instead.
+* Control published state from Obsidian. Right now, new articles are created as
+  draft, allowing you to control everything before publishing.
+* Suggestion from @Rooyca: Autopublish - configurable by the user
 
 So unfortunately, one essential feature seems to be impossible, let me know if
 you happen to know how a way to securely handle secrets from Obsidian plugins.
 
-### Nice to have
-
-- Control published state from Obsidian. Right now, new articles are created as
-  draft, allowing you to control everything before publishing.
-- Suggestion from @Rooyca: Autopublish - configurable by the user
-
-
 ## Filing a bug report
 
 If creating a note doesn't work, first check, and double check that the

src/publisher.ts

@@ -92,6 +92,8 @@ export default class Publisher<TFile extends { path: string }> {
     const flattened = replaceInstructions.filter(
       (x) => !replaceInstructions.find((y) => x.from > y.from && x.to < y.to),
     );
+    flattened.sort((a, b) => a.from - b.from);
+    // console.log("Replace instructions", flattened);
 
     const result = flattened.reduce(
       (prev, curr) => {

test/markdown-processing.test.ts

@@ -135,7 +135,7 @@ describe("Image resolution", () => {
     const gateway = createGatewayStubWithDefaults();
     const publisher = createPublisher(fakeApp, gateway);
     const file = fakeApp.fileManager.createFakeFile({
-      contents: "A file with ![[embedded-image.png]] in it",
+      contents: "A file with ![[embedded-image.png|an embedded image]] in it",
       frontmatter: {
         "dev-article-id": 42,
         "dev-image-map": [
@@ -150,7 +150,7 @@ describe("Image resolution", () => {
     gateway.updateArticle.should.have.been.calledOnce;
     const data = gateway.updateArticle.firstCall.args[0];
     data.article.markdown.should.equal(
-      "A file with ![embedded-image.png](https://example.com/image.png) in it",
+      "A file with ![an embedded image](https://example.com/image.png) in it",
     );
   });
 });