x/exp/schema/resolved: move sumtype linter out of golangci-lint

When running go-check-sumtype in golangci-lint, sum types can only be checked in the package in which they're defined (see golangci/golangci-lint#4158). Bummer.

This change makes it so that we now run the linter explicitly in CI.

Signed-Off-By: Patrick Jakubowski <patrick.jakubowski@strongdm.com>

Author: patjakdev

.github/workflows/build_and_test.yml

@@ -24,6 +24,9 @@ jobs:
       - name: Lint
         uses: golangci/golangci-lint-action@v7
 
+      - name: Sum type linter
+        run: go install github.com/alecthomas/go-check-sumtype/cmd/go-check-sumtype@latest && go-check-sumtype -default-signifies-exhaustive=false ./...
+
       - name: Fuzz
         run: mkdir -p testdata && go test -fuzz=FuzzParse -fuzztime 60s && go test -fuzz=FuzzTokenize -fuzztime 60s
 

.golangci.yml

@@ -10,7 +10,6 @@ linters:
   enable:
     - errcheck
     - errname
-    - gochecksumtype
     - govet
     - ineffassign
     - revive

x/exp/schema/resolved/resolve.go

@@ -377,7 +377,7 @@ func (r *resolverState) resolveType(ns types.Path, t ast.IsType) (IsType, error)
 	case ast.TypeRef:
 		return r.resolveTypeRef(ns, t)
 	default:
-		return nil, fmt.Errorf("unknown AST type: %T", t)
+		panic(fmt.Sprintf("unknown AST type: %T", t))
 	}
 }
 
@@ -593,8 +593,10 @@ func collectTypeRefs(t ast.IsType) []ast.TypeRef {
 			refs = append(refs, collectTypeRefs(attr.Type)...)
 		}
 		return refs
-	default:
+	case ast.BoolType, ast.EntityTypeRef, ast.ExtensionType, ast.LongType, ast.StringType:
 		return nil
+	default:
+		panic(fmt.Sprintf("unknown AST type: %T", t))
 	}
 }
 

x/exp/schema/resolved/resolve_internal_test.go

@@ -15,8 +15,9 @@ func TestResolveTypeDefault(t *testing.T) {
 		enumTypes:   make(map[types.EntityType]bool),
 		commonTypes: make(map[types.Path]ast.IsType),
 	}
-	_, err := r.resolveType("", nil)
-	testutil.Error(t, err)
+	testutil.Panic(t, func() {
+		_, _ = r.resolveType("", nil)
+	})
 }
 
 func TestResolveTypePath(t *testing.T) {
@@ -55,9 +56,14 @@ func TestResolveActionParentRef(t *testing.T) {
 }
 
 func TestCollectTypeRefsDefault(t *testing.T) {
-	// Exercise the default branch (non-TypeRef, non-Set, non-Record).
+	// Exercise the non-container type branch
 	refs := collectTypeRefs(ast.StringType{})
 	testutil.Equals(t, len(refs), 0)
+
+	// Exercise the impossible to hit branch
+	testutil.Panic(t, func() {
+		collectTypeRefs(nil)
+	})
 }
 
 func TestDetectCommonTypeCyclesBuiltinRef(t *testing.T) {