Merge pull request #2822 from strongloop/fix/promise-remote-hooks-2x

Fix support for remote hooks returning a Promise

Author: bajtos

lib/model.js

@@ -202,7 +202,7 @@ module.exports = function(registry) {
       this._runWhenAttachedToApp(function(app) {
         var remotes = app.remotes();
         remotes.before(className + '.' + name, function(ctx, next) {
-          fn(ctx, ctx.result, next);
+          return fn(ctx, ctx.result, next);
         });
       });
     };
@@ -213,7 +213,7 @@ module.exports = function(registry) {
       this._runWhenAttachedToApp(function(app) {
         var remotes = app.remotes();
         remotes.after(className + '.' + name, function(ctx, next) {
-          fn(ctx, ctx.result, next);
+          return fn(ctx, ctx.result, next);
         });
       });
     };

test/model.test.js

@@ -10,6 +10,7 @@ var loopback = require('../');
 var ACL = loopback.ACL;
 var defineModelTestsWithDataSource = require('./util/model-tests');
 var PersistedModel = loopback.PersistedModel;
+var Promise = require('bluebird');
 var sinonChai = require('sinon-chai');
 chai.use(sinonChai);
 
@@ -308,6 +309,32 @@ describe.onServer('Remote Methods', function() {
           done();
         });
     });
+
+    it('Does not stop the hook chain after returning a promise', function(done) {
+      var hooksCalled = [];
+
+      User.beforeRemote('create', function() {
+        hooksCalled.push('first');
+        return Promise.resolve();
+      });
+
+      User.beforeRemote('create', function(ctx, user, next) {
+        hooksCalled.push('second');
+        next();
+      });
+
+      // invoke save
+      request(app)
+        .post('/users')
+        .send({ data: { first: 'foo', last: 'bar' }})
+        .expect('Content-Type', /json/)
+        .expect(200)
+        .end(function(err, res) {
+          if (err) return done(err);
+          expect(hooksCalled).to.eql(['first', 'second']);
+          done();
+        });
+    });
   });
 
   describe('Model.afterRemote(name, fn)', function() {