-
Notifications
You must be signed in to change notification settings - Fork 8
Open
Description
On line 100 in logger.js there is this:
function appendNewline(line) {
this.emit('data', line + '\n');
}
This is a bug, since '\n' isn't converted to the newline character. This should be changed to:
function appendNewline(line) {
this.emit('data', line + os.EOL);
}
It causes this issue in Lerna which is streaming through strong-log-transformer:
lerna/lerna#994
Additionally, on line 77 or logger.js there is this regexp to split lines:
var list = last.split(/\r\n|[\n\v\f\r\x85\u2028\u2029]/g);
This regex is suspect and probably should just split on whatever os.EOL is set to and nothing else.
Metadata
Metadata
Assignees
Labels
No labels