Merge pull request moodlehq#149 from paulholden/php-73

Increase default PHP version to 7.3.

Author: stronk7

.travis.yml

@@ -6,10 +6,10 @@ env:
     # PostgreSQL highest, lowest php supported
     # We have set the "phpunit-full" to run against master
     - "PHP=7.4 DB=pgsql   GIT=master SUITE=phpunit-full"
-    - "PHP=7.2 DB=pgsql   GIT=master SUITE=phpunit-full"
+    - "PHP=7.3 DB=pgsql   GIT=master SUITE=phpunit-full"
     # Other dev branches, also "phpunit-full"
     - "PHP=7.4 DB=pgsql   GIT=MOODLE_311_STABLE SUITE=phpunit-full"
-    - "PHP=7.2 DB=pgsql   GIT=MOODLE_311_STABLE SUITE=phpunit-full"
+    - "PHP=7.3 DB=pgsql   GIT=MOODLE_311_STABLE SUITE=phpunit-full"
     # Simpler "phpunit" for stables
     - "PHP=7.4 DB=pgsql   GIT=v3.10.0 SUITE=phpunit"
     - "PHP=7.2 DB=pgsql   GIT=v3.10.0 SUITE=phpunit"
@@ -41,12 +41,12 @@ env:
     # PostgreSQL highest, lowest (2 browsers)
     - "PHP=7.4 DB=pgsql   GIT=master SUITE=behat BROWSER=chrome"
     - "PHP=7.4 DB=pgsql   GIT=master SUITE=behat BROWSER=firefox"
-    - "PHP=7.2 DB=pgsql   GIT=master SUITE=behat BROWSER=chrome"
-    - "PHP=7.2 DB=pgsql   GIT=master SUITE=behat BROWSER=firefox"
+    - "PHP=7.3 DB=pgsql   GIT=master SUITE=behat BROWSER=chrome"
+    - "PHP=7.3 DB=pgsql   GIT=master SUITE=behat BROWSER=firefox"
     - "PHP=7.4 DB=pgsql   GIT=MOODLE_311_STABLE SUITE=behat BROWSER=chrome"
     - "PHP=7.4 DB=pgsql   GIT=MOODLE_311_STABLE SUITE=behat BROWSER=firefox"
-    - "PHP=7.2 DB=pgsql   GIT=MOODLE_311_STABLE SUITE=behat BROWSER=chrome"
-    - "PHP=7.2 DB=pgsql   GIT=MOODLE_311_STABLE SUITE=behat BROWSER=firefox"
+    - "PHP=7.3 DB=pgsql   GIT=MOODLE_311_STABLE SUITE=behat BROWSER=chrome"
+    - "PHP=7.3 DB=pgsql   GIT=MOODLE_311_STABLE SUITE=behat BROWSER=firefox"
     - "PHP=7.4 DB=pgsql   GIT=v3.10.0 SUITE=behat BROWSER=chrome"
     - "PHP=7.4 DB=pgsql   GIT=v3.10.0 SUITE=behat BROWSER=firefox"
     - "PHP=7.2 DB=pgsql   GIT=v3.10.0 SUITE=behat BROWSER=chrome"

README.md

@@ -172,7 +172,7 @@ You can change the configuration of the docker images by setting various environ
 |-------------------------------------------|-----------|---------------------------------------|---------------|------------------------------------------------------------------------------|
 | `MOODLE_DOCKER_DB`                        | yes       | pgsql, mariadb, mysql, mssql, oracle  | none          | The database server to run against                                           |
 | `MOODLE_DOCKER_WWWROOT`                   | yes       | path on your file system              | none          | The path to the Moodle codebase you intend to test                           |
-| `MOODLE_DOCKER_PHP_VERSION`               | no        | 7.4, 7.3, 7.2, 7.1, 7.0, 5.6          | 7.2           | The php version to use                                                       |
+| `MOODLE_DOCKER_PHP_VERSION`               | no        | 7.4, 7.3, 7.2, 7.1, 7.0, 5.6          | 7.3           | The php version to use                                                       |
 | `MOODLE_DOCKER_BROWSER`                   | no        | firefox, chrome                       | firefox       | The browser to run Behat against                                             |
 | `MOODLE_DOCKER_PHPUNIT_EXTERNAL_SERVICES` | no        | any value                             | not set       | If set, dependencies for memcached, redis, solr, and openldap are added      |
 | `MOODLE_DOCKER_WEB_HOST`                  | no        | any valid hostname                    | localhost     | The hostname for web                                |

bin/moodle-docker-compose

@@ -29,7 +29,7 @@ dockercompose="docker-compose -f ${basedir}/base.yml"
 dockercompose="${dockercompose} -f ${basedir}/service.mail.yml"
 
 # PHP Version.
-export MOODLE_DOCKER_PHP_VERSION=${MOODLE_DOCKER_PHP_VERSION:-7.2}
+export MOODLE_DOCKER_PHP_VERSION=${MOODLE_DOCKER_PHP_VERSION:-7.3}
 
 # Database flavour
 if [ "$MOODLE_DOCKER_DB" != 'pgsql' ];

bin/moodle-docker-compose.cmd

@@ -22,7 +22,7 @@ SET DOCKERCOMPOSE=docker-compose -f "%BASEDIR%\base.yml"
 SET DOCKERCOMPOSE=%DOCKERCOMPOSE% -f "%BASEDIR%\service.mail.yml"
 
 IF "%MOODLE_DOCKER_PHP_VERSION%"=="" (
-    SET MOODLE_DOCKER_PHP_VERSION=7.2
+    SET MOODLE_DOCKER_PHP_VERSION=7.3
 )
 
 IF NOT "%MOODLE_DOCKER_DB%"=="pgsql" (