Skip to content

Commit 53f3a2c

Browse files
committed
README: Improvement ideas section
1 parent ce814e9 commit 53f3a2c

File tree

2 files changed

+5
-10
lines changed

2 files changed

+5
-10
lines changed

README-legacy.md

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,3 @@ let hook = try testObj.hook(
1717
InterposeKit can hook classes and object. Class hooking is similar to swizzling, but object-based hooking offers a variety of new ways to set hooks. This is achieved via creating a dynamic subclass at runtime.
1818

1919
Caveat: Hooking will fail with an error if the object uses KVO. The KVO machinery is fragile and it's to easy to cause a crash. Using KVO after a hook was created is supported and will not cause issues.
20-
21-
## Improvement Ideas
22-
23-
- Write proposal to allow to [convert the calling convention of existing types](https://twitter.com/steipete/status/1266799174563041282?s=21).
24-
- Use the C block struct to perform type checking between Method type and C type (I do that in [Aspects library](https://github.com/steipete/Aspects)), it's still a runtime crash but could be at hook time, not when we call it.
25-
- Add a way to get all current hooks from an object/class.
26-
- Switch to Trampolines to manage cases where other code overrides super, so we end up with a super call that's [not on top of the class hierarchy](https://github.com/steipete/InterposeKit/pull/15#discussion_r439871752).

README.md

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -177,9 +177,11 @@ That said, InterposeKit is designed to be safe for production use. It includes g
177177

178178
## Improvement Ideas
179179

180-
- Support for hooking KVO-enabled objects
181-
- Signature type checking at hook construction
182-
- Support for reverting multiple hooks on a class in an arbitrary order
180+
- Support for hooking KVO-enabled objects ([#19](https://github.com/structuredpath/InterposeKit/issues/19))
181+
- Correct super lookup when injecting a trampoline into classes with overridden methods ([#21](https://github.com/structuredpath/InterposeKit/issues/21))
182+
- Signature type checking at hook construction ([#20](https://github.com/structuredpath/InterposeKit/issues/20))
183+
- A way for retrieving all hooks on an object/class
184+
- Support for reverting multiple hooks on a class in an arbitrary order ([#12](https://github.com/structuredpath/InterposeKit/issues/12))
183185

184186
## References
185187

0 commit comments

Comments
 (0)