-
-
Notifications
You must be signed in to change notification settings - Fork 59
Images from markdown documentation, are imported into workspace.json, but never removed. #160
Description
Expected
When linking to markdown documentation of a software system with images, the documentation is rendered correctly in structurizr.
A side effect is, that the image gets copied and embedded as base64 into the workspace.json file.
Expectation: When removing the image-link from the documentation, I would expect structurizr to also remove the embedded image from the workspace.json.
Alternative Expectation: Not embedd the image into workspace.json at all. I suspect, it is needed "on the wire" between the structurizr server and the browser, but at least not the workspace.json that is stored on disk could be cleaned up.
Actual
The image stays embedded as base64 string in the workspace.json
Steps to reproduce
Create a workspace.dsl and link the software system documentation
...
mysystem = softwareSystem "My Software System" {
!docs ../../arc42/mysystem
...
Create a the documentation file ../../arc42/mysystem/architecture.md that contains an image link like this:
...

...
Place some-image.png in ../../arc42/mysystem/images/
Open workspace with structurizr lite (if you use the container, make sure you do not bind-mount the directory where workspace.dsl lies, but its grand-parent directory and use STRUCTURIZR_WORKSPACE_PATH=dir1/dir2 )
Version/build information
Structurizr Lite
- build: 2024.07.02 (2024-07-02T12:09:42Z)
- structurizr-java: v2.2.0
- structurizr-dsl: v2.2.0
- structurizr-import: v2.2.0
- structurizr-graphviz: v2.2.0
Severity
Minor
Priority
I have no budget and there's no rush, please fix this for free
More information
No response