feat: move to ESLint v9 👏 (#250)

BREAKING CHANGE: Projects must now use ESLint v9 in order to use these
rulesets.

Author: robertrossmann

eslint.config.js

@@ -2,24 +2,24 @@ import node from './packages/eslint-config-node/index.mjs'
 import optional from './packages/eslint-config-node/optional.mjs'
 import style from './packages/eslint-config-node/style.mjs'
 
-/** @type {Array<import("eslint").Linter.FlatConfig>} */
-const configs = [{
+/** @type {Array<import("eslint").Linter.Config>} */
+const config = [{
   linterOptions: {
     reportUnusedDisableDirectives: true,
   },
   ignores: [
     'node_modules',
     '!.*.js',
   ],
+  settings: {
+    'import/resolver': { typescript: {} },
+  },
 },
 node,
 optional,
 style,
-{ files: ['**/*.js', '**/*.mjs'], languageOptions: { sourceType: 'module' } },
-{ files: ['**/*.cjs'], languageOptions: { sourceType: 'commonjs' } },
-{ rules: {
-  // TODO: Figure out why ESLint cannot resolve the @typescript-eslint packages
-  'import/no-unresolved': 'off',
-} }]
+{
+  rules: {},
+}]
 
-export default configs
+export default config

package-lock.json

@@ -11,8 +11,8 @@
     "Korneliusz Dubieniecki <[email protected]>"
   ],
   "devDependencies": {
-    "@commitlint/cli": "^18.6.0",
-    "eslint": "^8.57.0",
+    "@commitlint/cli": "^19",
+    "eslint": "^9",
     "lerna": "^8.1.2",
     "remark-cli": "^12.0.0",
     "remark-preset-lint-consistent": "^5",

package.json

@@ -3,6 +3,30 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [5.0.0-alpha.1](https://github.com/strvcom/code-quality-tools/compare/@strv/[email protected]...@strv/[email protected]) (2025-01-24)
+
+**Note:** Version bump only for package @strv/eslint-config-base
+
+
+
+
+
+# [5.0.0-alpha.0](https://github.com/strvcom/code-quality-tools/compare/@strv/[email protected]...@strv/[email protected]) (2025-01-24)
+
+
+### Features
+
+* move to ESLint v9 👏 ([4de1c1f](https://github.com/strvcom/code-quality-tools/commit/4de1c1f7543898cddc4178afc7222e369b6ea018))
+
+
+### BREAKING CHANGES
+
+* Projects must now use ESLint v9 in order to use these rulesets.
+
+
+
+
+
 # [4.0.0](https://github.com/strvcom/code-quality-tools/compare/@strv/[email protected]...@strv/[email protected]) (2024-02-16)
 
 

packages/eslint-config-base/CHANGELOG.md

@@ -1,7 +1,7 @@
 import imports from 'eslint-plugin-import'
 import stylistic from '@stylistic/eslint-plugin'
 
-/** @type {import("eslint").Linter.FlatConfig} */
+/** @type {import("eslint").Linter.Config} */
 const config = {
   plugins: {
     import: imports,
@@ -590,9 +590,7 @@ const config = {
     'vars-on-top': 'warn',
 
     // Ensure an imported module can be resolved to a module on the local filesystem
-    'import/no-unresolved': ['error', {
-      commonjs: true,
-    }],
+    'import/no-unresolved': ['error'],
 
     // Verifies that all named imports are part of the set of named exports in the referenced module
     'import/named': 'error',
@@ -605,8 +603,7 @@ const config = {
     'import/first': 'error',
 
     // Enforces names exist at the time they are dereferenced, when imported as a full namespace
-    // TODO: Re-enable when eslint-plugin-import gets ESLint flat config support
-    // 'import/namespace': 'error',
+    'import/namespace': 'error',
 
     // Forbid import of modules using absolute paths
     // Node.js allows the import of modules using an absolute path such as */home/xyz/file.js*. That

packages/eslint-config-base/index.mjs

@@ -1,6 +1,6 @@
 import imports from 'eslint-plugin-import'
 
-/** @type {import("eslint").Linter.FlatConfig} */
+/** @type {import("eslint").Linter.Config} */
 const config = {
   plugins: {
     import: imports,

packages/eslint-config-base/optional.mjs

@@ -1,7 +1,7 @@
 {
   "name": "@strv/eslint-config-base",
   "description": "STRV's ESLint configuration preset",
-  "version": "4.0.0",
+  "version": "5.0.0-alpha.1",
   "author": "Pavel Prichodko <[email protected]>",
   "bugs": {
     "url": "https://github.com/strvcom/code-quality-tools/issues"
@@ -11,8 +11,8 @@
     "Danny Kijkov <[email protected]>"
   ],
   "dependencies": {
-    "@stylistic/eslint-plugin": "^1.6.0",
-    "eslint-plugin-import": "^2.27.0"
+    "@stylistic/eslint-plugin": "^2.13.0",
+    "eslint-plugin-import": "^2.31.0"
   },
   "engines": {
     "node": ">=20"
@@ -30,7 +30,7 @@
     "./style": "./style.mjs"
   },
   "peerDependencies": {
-    "eslint": "^8"
+    "eslint": "^9"
   },
   "publishConfig": {
     "access": "public"

packages/eslint-config-base/package.json

@@ -1,7 +1,7 @@
 import imports from 'eslint-plugin-import'
 import stylistic from '@stylistic/eslint-plugin'
 
-/** @type {import("eslint").Linter.FlatConfig} */
+/** @type {import("eslint").Linter.Config} */
 const config = {
   plugins: {
     import: imports,
@@ -166,6 +166,8 @@ const config = {
         'R',
         // jQuery 🤮
         '$',
+        // vitest in-test context: `it('works', t => { t.expect(1).toBe(1) })`
+        't',
       ],
     }],
 
@@ -227,7 +229,7 @@ const config = {
 
     // Enforce a particular style for multiline comments
     // Prefer consecutive line comments for multiline comment block
-    'multiline-comment-style': ['warn', 'separate-lines'],
+    '@stylistic/multiline-comment-style': ['warn', 'separate-lines'],
 
     // Enforce newlines between operands of ternary expressions
     // Enforce either the whole ternary on a single line or each part of the ternary on its own line

packages/eslint-config-base/style.mjs

@@ -3,6 +3,30 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [3.0.0-alpha.1](https://github.com/strvcom/code-quality-tools/compare/@strv/[email protected]...@strv/[email protected]) (2025-01-24)
+
+**Note:** Version bump only for package @strv/eslint-config-graphql
+
+
+
+
+
+# [3.0.0-alpha.0](https://github.com/strvcom/code-quality-tools/compare/@strv/[email protected]...@strv/[email protected]) (2025-01-24)
+
+
+### Features
+
+* move to ESLint v9 👏 ([4de1c1f](https://github.com/strvcom/code-quality-tools/commit/4de1c1f7543898cddc4178afc7222e369b6ea018))
+
+
+### BREAKING CHANGES
+
+* Projects must now use ESLint v9 in order to use these rulesets.
+
+
+
+
+
 # [2.0.0](https://github.com/strvcom/code-quality-tools/compare/@strv/[email protected]...@strv/[email protected]) (2024-02-16)
 
 

packages/eslint-config-graphql/CHANGELOG.md

@@ -1,7 +1,7 @@
 // TODO: Deprecated. Move to https://github.com/dimaMachina/graphql-eslint
 import graphql from 'eslint-plugin-graphql'
 
-/** @type {import("eslint").Linter.FlatConfig} */
+/** @type {import("eslint").Linter.Config} */
 const config = {
   plugins: {
     graphql,