Skip to content
This repository was archived by the owner on Mar 7, 2019. It is now read-only.

Commit 59bdf7b

Browse files
Move no-console rule to shared env
1 parent 523d58f commit 59bdf7b

File tree

3 files changed

+14
-17
lines changed

3 files changed

+14
-17
lines changed

environments/nodejs/optional.js

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -14,19 +14,7 @@ module.exports = {
1414

1515
extends: '../shared/optional.js',
1616

17-
rules: {
18-
// Disallow Use of console
19-
// In general, you should use a logging library which offers more flexibility in terms of log
20-
// level configuration and log destinations (i.e. sending logs to external storage/monitoring
21-
// service), such as `debug` or `bunyan`.
22-
// Feel free to turn this rule off in your project-level ruleset if you are ok with logging to
23-
// console only.
24-
//
25-
// @see https://www.npmjs.com/package/debug
26-
// @see https://www.npmjs.com/package/pino
27-
// @see https://www.npmjs.com/package/bunyan
28-
'no-console': 'warn',
29-
},
17+
rules: {},
3018

3119
overrides: {
3220
files: globs.test,

environments/react/optional.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,6 @@ module.exports = {
1818
// that should be replaced with less obtrusive, custom UIs.
1919
'no-alert': 'warn',
2020

21-
// Custom logging logic should be implemented, everything else will be considered as debugging
22-
// statement developer forget to remove
23-
'no-console': 'warn',
24-
2521
// Enforce propTypes declarations alphabetical sorting
2622
'react/sort-prop-types': ['warn', {
2723
ignoreCase: true,

environments/shared/optional.js

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,19 @@ module.exports = {
3131
// depth blocks can be nested in a function.
3232
'max-depth': ['warn', 5],
3333

34+
// Disallow Use of console
35+
// In general, you should use a logging library which offers more flexibility in terms of log
36+
// level configuration and log destinations (i.e. sending logs to external storage/monitoring
37+
// service), such as `debug` or `bunyan`.
38+
// Feel free to turn this rule off in your project-level ruleset if you are ok with logging to
39+
// console only.
40+
// On frontend, custom logging logic should be implemented.
41+
//
42+
// @see https://www.npmjs.com/package/debug
43+
// @see https://www.npmjs.com/package/pino
44+
// @see https://www.npmjs.com/package/bunyan
45+
'no-console': 'warn',
46+
3447
// Require Function Expressions to have a Name
3548
// If you provide the optional name for a function expression then you will get the name of the
3649
// function expression in the stack trace.

0 commit comments

Comments
 (0)