Create new type correctly

In the past there have been multiple ways how to create a new type.
Apparently they are not all working anymore so we switch to
`Puppet::Type.newtype`

Author: stschulte

lib/puppet/provider/oratab/parsed.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'puppet/provider/parsedfile'
 
 oratab = case Facter.value(:operatingsystem)

lib/puppet/type/oratab.rb

@@ -1,56 +1,56 @@
+# frozen_string_literal: true
+
 require 'puppet/provider/parsedfile'
 
-module Puppet
-  newtype(:oratab) do
+Puppet::Type.newtype(:oratab) do
 
-    @doc = "Define database instaces in /etc/oratab with instance name
-      home directory and a flag which indicates if the instance should
-      be started together with the database"
+  @doc = "Define database instaces in /etc/oratab with instance name
+    home directory and a flag which indicates if the instance should
+    be started together with the database"
 
-    newparam(:name) do
-      desc "The instance's name"
+  newparam(:name) do
+    desc "The instance's name"
 
-      isnamevar
+    isnamevar
 
-      validate do |value|
-        raise Puppet::Error, "Name must not contain whitespace: #{value}" if value =~ /\s/
-        raise Puppet::Error, "Name must not be empty" if value.empty?
-      end
+    validate do |value|
+      raise Puppet::Error, "Name must not contain whitespace: #{value}" if value =~ /\s/
+      raise Puppet::Error, "Name must not be empty" if value.empty?
     end
+  end
 
-    ensurable
+  ensurable
 
-    newproperty(:home) do
-      desc "The home directory of the instance. This must be an absolute
-        path"
+  newproperty(:home) do
+    desc "The home directory of the instance. This must be an absolute
+      path"
 
-      validate do |value|
-         raise Puppet::Error, "Home must be an absolute path: #{value}" unless value =~ /^\//
-      end
+    validate do |value|
+        raise Puppet::Error, "Home must be an absolute path: #{value}" unless value =~ /^\//
     end
+  end
 
-    newproperty(:atboot) do
-      desc "If the instance should start together with the database itself
-        set this property to `yes` otherwise to `no`"
+  newproperty(:atboot) do
+    desc "If the instance should start together with the database itself
+      set this property to `yes` otherwise to `no`"
 
-      newvalues :yes, :no
-      aliasvalue :Y, :yes
-      aliasvalue :N, :no
-    end
+    newvalues :yes, :no
+    aliasvalue :Y, :yes
+    aliasvalue :N, :no
+  end
 
-    newproperty(:description) do
-      desc "An optional description that will be added as an inline comment
-        in the target file"
+  newproperty(:description) do
+    desc "An optional description that will be added as an inline comment
+      in the target file"
 
-    end
+  end
 
-    newproperty(:target) do
-      desc "The path of the target file to store the instance information in"
+  newproperty(:target) do
+    desc "The path of the target file to store the instance information in"
 
-      defaultto do
-        if @resource.class.defaultprovider.ancestors.include?(Puppet::Provider::ParsedFile)
-          @resource.class.defaultprovider.default_target
-        end
+    defaultto do
+      if @resource.class.defaultprovider.ancestors.include?(Puppet::Provider::ParsedFile)
+        @resource.class.defaultprovider.default_target
       end
     end
   end