Fix flow bug

Author: stslex

app/build.gradle

@@ -74,6 +74,7 @@ dependencies {
     def lifecycleVersion = '2.4.0-rc01'
     implementation "androidx.lifecycle:lifecycle-runtime-ktx:$lifecycleVersion"
     implementation "androidx.lifecycle:lifecycle-viewmodel-compose:$lifecycleVersion"
+    implementation 'androidx.compose.runtime:runtime-livedata:1.0.3'
 
     //Coroutines
     api 'org.jetbrains.kotlinx:kotlinx-coroutines-core:1.5.1'

app/src/main/java/st/slex/csplashscreen/ui/MainActivity.kt

@@ -75,13 +75,16 @@ fun NavigationComponent(navController: NavHostController, viewModel: MainViewMod
                 navArgument("imageId") { type = NavType.StringType }
             )
         ) {
+
             val imageId = it.arguments?.getString("imageId").toString()
             val url = it.arguments?.getString("url").toString()
+
+            viewModel.getCurrentPhoto(imageId)
+
             ImageDetailScreen(
                 url = url,
-                imageId = imageId,
-                viewModel = viewModel,
-                navController = navController
+                navController = navController,
+                viewModel::currentPhoto
             )
         }
 

app/src/main/java/st/slex/csplashscreen/ui/MainViewModel.kt

@@ -5,6 +5,7 @@ import androidx.lifecycle.viewModelScope
 import androidx.paging.*
 import kotlinx.coroutines.ExperimentalCoroutinesApi
 import kotlinx.coroutines.flow.*
+import kotlinx.coroutines.launch
 import st.slex.csplashscreen.data.core.Mapper
 import st.slex.csplashscreen.data.model.remote.download.RemoteDownloadModel
 import st.slex.csplashscreen.data.model.remote.image.RemoteImageModel
@@ -30,9 +31,13 @@ class MainViewModel @Inject constructor(
 ) : ViewModel() {
 
 
-    fun getCurrentPhoto(id: String): Flow<UIResult<ImageModel>> = flow {
+    private val _currentPhoto = MutableStateFlow<UIResult<ImageModel>>(UIResult.Loading)
+    val currentPhoto: StateFlow<UIResult<ImageModel>>
+        get() = _currentPhoto.asStateFlow()
+
+    fun getCurrentPhoto(id: String) = viewModelScope.launch {
         repository.getCurrentPhoto(id).collect {
-            emit(it.map(mapper = photoMapper))
+            _currentPhoto.value = it.map(mapper = photoMapper)
         }
     }
 

app/src/main/java/st/slex/csplashscreen/ui/detail/ImageDetailScreen.kt

@@ -1,62 +1,66 @@
 package st.slex.csplashscreen.ui.detail
 
-import android.annotation.SuppressLint
 import android.util.Log
+import androidx.compose.foundation.Image
+import androidx.compose.foundation.clickable
+import androidx.compose.foundation.layout.Column
+import androidx.compose.foundation.layout.fillMaxWidth
+import androidx.compose.foundation.layout.height
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.collectAsState
-import androidx.compose.runtime.rememberCoroutineScope
+import androidx.compose.ui.Modifier
+import androidx.compose.ui.unit.dp
 import androidx.navigation.NavController
 import coil.annotation.ExperimentalCoilApi
+import coil.compose.rememberImagePainter
+import coil.transform.RoundedCornersTransformation
 import kotlinx.coroutines.ExperimentalCoroutinesApi
-import st.slex.csplashscreen.ui.MainViewModel
+import kotlinx.coroutines.flow.StateFlow
+import st.slex.csplashscreen.data.model.ui.image.ImageModel
+import st.slex.csplashscreen.ui.core.UIResult
+import java.net.URLEncoder
+import java.nio.charset.StandardCharsets
 
-@SuppressLint("CoroutineCreationDuringComposition")
 @ExperimentalCoroutinesApi
 @ExperimentalCoilApi
 @Composable
 fun ImageDetailScreen(
     url: String,
-    imageId: String,
-    viewModel: MainViewModel,
     navController: NavController,
+    imageFlow: () -> StateFlow<UIResult<ImageModel>>
 ) {
-    val stateFlow = viewModel.getCurrentPhoto(imageId)
-    val viewState =
-        viewModel.getCurrentPhoto(imageId).collectAsState(rememberCoroutineScope().coroutineContext)
-    Log.i("THisIsResult", viewState.toString())
-    val result = viewState.value
-    /*when (val result = viewState.value) {
-        is UIResult.Success -> {
-            viewState.wait().notifyAll()
-            Column {
-                Image(
-                    modifier = Modifier
-                        .fillMaxWidth()
-                        .height(300.dp)
-                        .clickable {
-                            val encodedUrl =
-                                URLEncoder.encode(url, StandardCharsets.UTF_8.toString())
-                            navController.navigate("raw_image/$encodedUrl")
-                        },
-                    painter = rememberImagePainter(
-                        data = result.data.urls.regular,
-                        builder = {
-                            transformations(RoundedCornersTransformation())
-                            allowHardware(false)
-                            crossfade(500)
-                        }
-                    ),
-                    contentDescription = "TestImage"
-                )
-            }
-        }
-        is UIResult.Loading -> {
-
-        }
-        is UIResult.Failure -> {
+    val imageModel = imageFlow().collectAsState().value
 
+    when (imageModel) {
+        is UIResult.Success -> {
+            BindImage(navController, url, imageModel.data)
         }
-    }*/
+    }
 
+    Log.i("imageModel", imageModel.toString())
+}
 
+@Composable
+fun BindImage(navController: NavController, url: String, imageModel: ImageModel) {
+    Column {
+        Image(
+            modifier = Modifier
+                .fillMaxWidth()
+                .height(300.dp)
+                .clickable {
+                    val encodedUrl =
+                        URLEncoder.encode(url, StandardCharsets.UTF_8.toString())
+                    navController.navigate("raw_image/$encodedUrl")
+                },
+            painter = rememberImagePainter(
+                data = imageModel.urls.regular,
+                builder = {
+                    transformations(RoundedCornersTransformation())
+                    allowHardware(false)
+                    crossfade(500)
+                }
+            ),
+            contentDescription = "TestImage"
+        )
+    }
 }