Skip to content

Commit 7ecd5e2

Browse files
authored
Merge pull request #21 from stslex/dev
fix fastlane
2 parents 4bb6103 + adeb692 commit 7ecd5e2

File tree

18 files changed

+111
-22
lines changed

18 files changed

+111
-22
lines changed

.github/workflows/android.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,10 @@ jobs:
2020
echo "${{ secrets.KEYSTORE }}" > keystore.jks.asc
2121
gpg -d --passphrase "${{ secrets.KEYSTORE_PASSPHRASE }}" --batch keystore.jks.asc > keystore.jks
2222
23-
- name: set up JDK 17
23+
- name: set up JDK 21
2424
uses: actions/setup-java@v3
2525
with:
26-
java-version: '17'
26+
java-version: '21'
2727
distribution: 'temurin'
2828
cache: gradle
2929

.github/workflows/android_deploy_beta.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,10 @@ jobs:
3333
restore-keys: |
3434
${{ runner.os }}-gems-
3535
36-
- name: set up JDK 17
36+
- name: set up JDK 21
3737
uses: actions/setup-java@v3
3838
with:
39-
java-version: '17'
39+
java-version: '21'
4040
distribution: 'temurin'
4141
cache: gradle
4242

.github/workflows/android_deploy_prod.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,10 @@ jobs:
3131
restore-keys: |
3232
${{ runner.os }}-gems-
3333
34-
- name: set up JDK 17
34+
- name: set up JDK 21
3535
uses: actions/setup-java@v3
3636
with:
37-
java-version: '17'
37+
java-version: '21'
3838
distribution: 'temurin'
3939
cache: gradle
4040

@@ -81,7 +81,7 @@ jobs:
8181
echo "$PLAY_CONFIG_JSON" > play_config.json.b64
8282
base64 -d -i play_config.json.b64 > play_config.json
8383
84-
- name: Distribute app to Beta track 🚀
84+
- name: Distribute app to Prod track 🚀
8585
run: bundle exec fastlane deploy
8686

8787
- name: Commit files

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,3 +12,4 @@ local.properties
1212
play_config.*
1313
keystore.*
1414
build
15+
/fastlane/report.xml

Gemfile

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
11
source "https://rubygems.org"
22

3-
gem "fastlane"
3+
gem "fastlane"
4+
5+
plugins_path = File.join(File.dirname(__FILE__), 'fastlane', 'Pluginfile')
6+
eval_gemfile(plugins_path) if File.exist?(plugins_path)
7+
gem "abbrev", "~> 0.1.2"

Gemfile.lock

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ GEM
55
base64
66
nkf
77
rexml
8+
abbrev (0.1.2)
89
addressable (2.8.7)
910
public_suffix (>= 2.0.2, < 7.0)
1011
artifactory (3.0.17)
@@ -223,6 +224,7 @@ PLATFORMS
223224
x86_64-linux
224225

225226
DEPENDENCIES
227+
abbrev (~> 0.1.2)
226228
fastlane
227229

228230
BUNDLED WITH

app/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ dependencies {
2424
implementation(google.dagger.core)
2525
kapt(google.dagger.compiler)
2626
implementation(glide.core)
27-
annotationProcessor(glide.compiler)
27+
kapt(glide.compiler)
2828
implementation(retrofit.core)
2929
implementation(retrofit.converter.gson)
3030
implementation(okhttp3.logging.interceptor)

build-logic/dependencies/build.gradle.kts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,11 @@ dependencies {
1010
compileOnly(libs.android.tools.common)
1111
}
1212

13+
java {
14+
sourceCompatibility = JavaVersion.VERSION_17
15+
targetCompatibility = JavaVersion.VERSION_17
16+
}
17+
1318
tasks {
1419
validatePlugins {
1520
enableStricterValidation = true
@@ -19,7 +24,6 @@ tasks {
1924

2025
gradlePlugin {
2126
plugins {
22-
2327
register("androidApplication") {
2428
id = libs.plugins.app.android.application.get().pluginId
2529
implementationClass = "AndroidApplicationPlugin"

build-logic/dependencies/src/main/kotlin/AndroidApplicationPlugin.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ class AndroidApplicationPlugin : Plugin<Project> {
3333
versionName = libs.findVersionString("versionName")
3434
versionCode = libs.findVersionInt("versionCode")
3535

36-
// configureSigning(target)
36+
configureSigning(target)
3737
}
3838
}
3939

build-logic/dependencies/src/main/kotlin/com/stslex/splashgallery/KotlinAndroid.kt

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,14 @@ import com.stslex.splashgallery.AppExt.findVersionInt
1111
import com.stslex.splashgallery.AppExt.libs
1212
import org.gradle.api.JavaVersion
1313
import org.gradle.api.Project
14+
import org.gradle.api.plugins.JavaPluginExtension
15+
import org.gradle.jvm.toolchain.JavaLanguageVersion
16+
import org.gradle.kotlin.dsl.configure
1417
import org.gradle.kotlin.dsl.dependencies
1518
import org.gradle.kotlin.dsl.provideDelegate
1619
import org.gradle.kotlin.dsl.withType
1720
import org.jetbrains.kotlin.gradle.dsl.JvmTarget
21+
import org.jetbrains.kotlin.gradle.dsl.KotlinProjectExtension
1822
import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
1923
import org.jetbrains.kotlin.konan.properties.Properties
2024

@@ -54,14 +58,17 @@ private fun Project.configureKotlinAndroid(
5458
).let { properties ->
5559
setLocalProperties(properties)
5660
}
61+
5762
}
5863

5964
compileOptions {
6065
// Up to Java 11 APIs are available through desugaring
6166
// https://developer.android.com/studio/write/java11-minimal-support-table
6267
sourceCompatibility = JavaVersion.VERSION_17
6368
targetCompatibility = JavaVersion.VERSION_17
69+
6470
isCoreLibraryDesugaringEnabled = true
71+
6572
}
6673

6774
configureKotlin()
@@ -87,6 +94,16 @@ private fun Project.configureKotlin() {
8794
freeCompilerArgs.add("-opt-in=kotlin.RequiresOptIn")
8895
}
8996
}
97+
98+
extensions.configure<KotlinProjectExtension> {
99+
jvmToolchain(17)
100+
}
101+
extensions.configure<JavaPluginExtension> {
102+
toolchain {
103+
languageVersion.set(JavaLanguageVersion.of(17))
104+
}
105+
106+
}
90107
}
91108

92109
fun DefaultConfig.setLocalProperties(

0 commit comments

Comments
 (0)