Skip to content

Commit 42553ea

Browse files
authored
Merge pull request #30 from lawrencegripper/lg/defaulttobash
Default to /bin/bash on exec
2 parents d6baa3f + 9326eac commit 42553ea

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

cmd/devcontainer/devcontainer.go

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,15 +67,20 @@ func createListCommand() *cobra.Command {
6767

6868
func createExecCommand() *cobra.Command {
6969
cmd := &cobra.Command{
70-
Use: "exec DEVCONTAINER_NAME COMMAND [args...]",
70+
Use: "exec DEVCONTAINER_NAME COMMAND [args...] (args will default to /bin/bash if none provided)",
7171
Short: "Execute a command in a devcontainer",
7272
Long: "Execute a command in a devcontainer, similar to `docker exec`. Pass `?` as DEVCONTAINER_NAME to be prompted.",
7373
RunE: func(cmd *cobra.Command, args []string) error {
7474

75-
if len(args) < 2 {
75+
if len(args) < 1 {
7676
return cmd.Usage()
7777
}
7878

79+
// Default to executing /bin/bash
80+
if (len(args) == 1) {
81+
args = append(args, "/bin/bash")
82+
}
83+
7984
devcontainerName := args[0]
8085
devcontainerList, err := devcontainers.ListDevcontainers()
8186
if err != nil {

0 commit comments

Comments
 (0)