PHPstan leven 4

Signed-off-by: Jan Henckens <jan@henckens.be>

Author: janhenckens

phpstan.neon

@@ -2,6 +2,6 @@ includes:
     - vendor/craftcms/phpstan/phpstan.neon
 
 parameters:
-    level: 3
+    level: 4
     paths:
         - src

src/controllers/NodesController.php

@@ -249,7 +249,6 @@ public function actionAddSlideOut()
             ]);
 
             if (!$node->validate()) {
-                dd($node->getErrors());
                 return $this->asFailure(Craft::t('navigate', 'Oops, something went wrong here'), $node->toArray());
             }
 

src/extensions/NavigateExtension.php

@@ -35,7 +35,7 @@ public function getFunctions()
 
     /**
      * @param $url
-     * @param null $part
+     * @param string|null $part
      * @return mixed
      */
     public function parseUrl($url, $part = null)

src/services/NavigateService.php

@@ -170,7 +170,7 @@ public function handleAddNavigation(ConfigEvent $event)
     public function saveNavigation(NavigationModel $model)
     {
         $record = false;
-        if (isset($model->id)) {
+        if ($model->id) {
             $record = NavigationRecord::findOne([
                 'id' => $model->id,
             ]);

src/services/NodesService.php

@@ -263,7 +263,7 @@ public function getNodeTypes(NavigationModel $navigation)
 
     public function deleteNode(NodeModel $node)
     {
-        if (isset($node->id)) {
+        if ($node->id) {
             if (NodeRecord::deleteAll([
                 'id' => $node->id,
             ])) {
@@ -283,7 +283,7 @@ public function save(NodeModel $node)
     {
         $isNew = !$node->id;
 
-        if (isset($node->id)) {
+        if ($node->id) {
             $record = NodeRecord::findOne([
                 'id' => $node->id,
             ]);
@@ -324,7 +324,7 @@ public function move(NodeModel $node, $parent, $previousId)
     {
         /** @var NodeRecord $record */
         $record = NodeRecord::findOne(['id' => $node->id]);
-        if (!$record) {
+        if ($record === null) {
             return false;
         }
 

src/variables/NavigateVariable.php

@@ -31,13 +31,13 @@ class NavigateVariable
     // =========================================================================
     /**
      * @param $navHandle
-     * @param null $siteId since 2.6.0
+     * @param int|null $siteId since 2.6.0
      * @return mixed
      * @throws \craft\errors\SiteNotFoundException
      */
     public function raw($navHandle, $siteId = null)
     {
-        if ($siteId) {
+        if ($siteId === null) {
             $site = Craft::$app->getSites()->getSiteById($siteId);
             if (!$site) {
                 $siteId = Craft::$app->sites->getCurrentSite()->id;