Support for React Router v4?

[mikkelking]

I tried to use the component with React v4 router, but it doesn't work, because BrowserHistory is no longer available, so the require doesn't work:

In helpers.js

try { browserHistory = require('react-router').browserHistory } catch(e) {}

According to the React Router doco, you can access props.history.push(), but there is no reference to the route available to do it with...

I did work out a way using <Redirect>, by making use of the hook on the component:

        <Accounts.ui.LoginForm 
          onSignedInHook={ this.onSignedIn }/>

and updating the state in the callback:

  onSignedIn(event) {
    console.log('user signed in ',this.state);
    this.setState({loggedIn: true});
  }

And finally using the state to do a redirect

  render(){
      if (this.state.loggedIn) {
        return <Redirect push to="/wizard" />
      } else {

I'm not sure if there is a better way to do this

[firrae]

Just bumping this, this is the only thing blocking me from moving on and using this package instead of making my own.

@mikkelking have you looked at potentially making a PR for this?

[mikkelking]

@firrae I can do a PR, I think I found something else too that I fixed. Just let me know and I'll submit it

[firrae]

@mikkelking sadly I can't accept PRs, but I feel that might be the best way to get someone who can to look at this. If there's a proposed solution then that's huge points towards getting it fixed sooner 😄

[mikkelking]

@firrae If the original authors won't accept a PR then I could fork the repo and publish it under a different name, or you could do what I have done and put it in the packages folder under your project - not ideal, but it works. I'll make the PR in the next day or two and see what happens

[firrae]

@mikkelking the original authors had given more community members access to accept PRs last I knew, so hopefully we can get one of their attention to get this pulled in.

@timbrandin?

[wzard]

@firrae @timbrandin Any updates on react-router-v4 support?

[firrae]

@wzard I wish. I ended up moving to the package that's inside Meteor Chef's Pup. It can be included in non-pup based applications as well, but I wish this could get pulled in and further developed on 😢

[kolyasya]

@firrae can you provide a link to the package, please?

[firrae]

@kolyasya you have to strip it out of their packages as they don't seem to offer it as a module to download. Here is the link to their default login page where everything is linked: https://github.com/cleverbeagle/pup/blob/master/imports/ui/pages/Login/Login.js.

In my experience, you can move 99% of it to another Meteor+React application but the ones I've tested so far were done when they were very bare bones.