Merge branch 'release/6.3.4'

Author: titouanmathis

.github/workflows/tests.yml

@@ -12,33 +12,45 @@ on:
 
 jobs:
   phpcs:
-    name: PHPCS
-    runs-on: ubuntu-latest
+    name: phpcs
+    runs-on: macos-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        php-versions: ['8.1', '8.2', '8.3', '8.4']
     steps:
       - uses: actions/checkout@v4
 
-      - name: Cache Composer dependencies
-        uses: actions/cache@v2
+      - name: Setup PHP, with composer and xdebug
+        uses: shivammathur/setup-php@v2 #https://github.com/shivammathur/setup-php
+        with:
+          php-version: ${{ matrix.php-versions }}
+          coverage: xdebug
+
+      - name: Get composer cache directory
+        id: composer-cache
+        run: echo "::set-output name=dir::$(composer config cache-files-dir)"
+
+      - name: Cache composer dependencies
+        uses: actions/cache@v4
         with:
-          path: /tmp/composer-cache
-          key: ${{ runner.os }}-${{ hashFiles('**/composer.lock') }}
+          path: ${{ steps.composer-cache.outputs.dir }}
+          key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
+          restore-keys: ${{ runner.os }}-composer-
 
-      - uses: php-actions/composer@v5
+      - name: Install Composer dependencies
+        run: composer install --no-progress --prefer-dist --optimize-autoloader --ignore-platform-reqs
 
       - name: PHPCS
-        run: ./vendor/bin/phpcs
+        run: composer run lint:style
 
   phpstan:
-    name: PHPStan
-    runs-on: ubuntu-latest
+    name: phpstan
+    runs-on: macos-latest
     strategy:
       fail-fast: false
       matrix:
-        php-versions:
-          - '7.3'
-          - '7.4'
-          - '8.0'
-          - '8.1'
+        php-versions: ['8.1', '8.2', '8.3', '8.4']
     steps:
       - uses: actions/checkout@v4
 
@@ -53,32 +65,36 @@ jobs:
         run: echo "::set-output name=dir::$(composer config cache-files-dir)"
 
       - name: Cache composer dependencies
-        uses: actions/cache@v2
+        uses: actions/cache@v4
         with:
           path: ${{ steps.composer-cache.outputs.dir }}
           key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
           restore-keys: ${{ runner.os }}-composer-
 
       - name: Install Composer dependencies
-        run: composer install --no-progress --prefer-dist --optimize-autoloader
+        run: composer install --no-progress --prefer-dist --optimize-autoloader --ignore-platform-reqs
 
       - name: PHPStan
-        run: ./vendor/bin/phpstan
+        run: composer run lint:static
 
   test:
-    name: Unit test
     runs-on: ubuntu-latest
     strategy:
       fail-fast: false
       matrix:
-        php-versions:
-          - '7.3'
-          - '7.4'
-          - '8.0'
-          - '8.1'
+        php-versions: ['8.1', '8.2', '8.3', '8.4']
+    env:
+      PHP_VERSION: ${{ matrix.php-versions }}
     steps:
       - uses: actions/checkout@v4
 
+      - uses: actions/setup-node@v4
+        with:
+          node-version: 22
+          cache: 'npm'
+
+      - run: npx bun install
+
       - name: Setup PHP, with composer and xdebug
         uses: shivammathur/setup-php@v2 #https://github.com/shivammathur/setup-php
         with:
@@ -90,14 +106,18 @@ jobs:
         run: echo "::set-output name=dir::$(composer config cache-files-dir)"
 
       - name: Cache composer dependencies
-        uses: actions/cache@v2
+        uses: actions/cache@v4
         with:
           path: ${{ steps.composer-cache.outputs.dir }}
           key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
           restore-keys: ${{ runner.os }}-composer-
 
       - name: Install Composer dependencies
-        run: composer install --no-progress --prefer-dist --optimize-autoloader
+        run: composer install --no-progress --prefer-dist --optimize-autoloader --ignore-platform-reqs
+
+      - name: Install Pest v3
+        run: composer require pest/pest:^3.0
+        if: ${{ matrix.php-version == '8.4' }}
 
       - name: Pest
         run: php -v && XDEBUG_MODE=coverage ./vendor/bin/pest --coverage --coverage-clover='coverage.xml'
@@ -106,7 +126,8 @@ jobs:
         uses: codecov/codecov-action@v4
         with:
           token: ${{ secrets.CODECOV_TOKEN }}
-          directory: ./coverage.xml
+          env_vars: PHP_VERSION
+          file: ./coverage.xml
           flags: unittests
           fail_ci_if_error: false
           verbose: true

CHANGELOG.md

@@ -6,6 +6,12 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 
 ## [Unreleased]
 
+## [v6.3.4](https://github.com/studiometa/webpack-config/compare/6.3.3..6.3.4) (2025-05-06)
+
+### Changed
+
+- Replace exceptions by warnings ([#193](https://github.com/studiometa/webpack-config/pull/193), [fe283af](https://github.com/studiometa/webpack-config/commit/fe283af))
+
 ## [v6.3.3](https://github.com/studiometa/webpack-config/compare/6.3.2..6.3.3) (2025-01-23)
 
 ### Changed

composer.json

@@ -1,6 +1,6 @@
 {
   "name": "studiometa/webpack-config",
-  "version": "6.3.3",
+  "version": "6.3.4",
   "description": "PHP Helpers for @studiometa/webpack-config",
   "type": "library",
   "require": {
@@ -31,9 +31,16 @@
     }
   },
   "scripts": {
-    "phpstan": "phpstan",
-    "phpcs": "phpcs",
-    "phpcbf": "phpcbf",
+    "lint": [
+      "@lint:style",
+      "@lint:static"
+    ],
+    "lint:static": "phpstan",
+    "lint:style": "phpcs",
+    "fix": [
+      "@fix:style"
+    ],
+    "fix:style": "phpcbf",
     "pest": "pest"
   }
 }

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@studiometa/webpack-config-root",
-  "version": "6.3.3",
+  "version": "6.3.4",
   "private": true,
   "type": "module",
   "workspaces": [

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@studiometa/webpack-config-demo",
-  "version": "6.3.3",
+  "version": "6.3.4",
   "private": true,
   "type": "module",
   "scripts": {

packages/demo/package.json

@@ -28,25 +28,22 @@ class Manifest
     public function __construct(string $path, string $publicPath)
     {
         if (!file_exists($path)) {
-            throw new Exception(sprintf('Could not find a manifest in %s', $path));
+            trigger_error(sprintf('Could not find a manifest in %s', $path), E_USER_WARNING);
+            return;
         }
 
-        $content = null;
-
-        try {
-            $content = file_get_contents($path);
-        } catch (Exception $error) {
-            throw new Exception(sprintf('Could not read the manifest in %s', $path));
-        }
+        $content = file_get_contents($path);
 
         if (!$content) {
-            throw new Exception(sprintf('Could not read the manifest in %s', $path));
+            trigger_error(sprintf('Could not read the manifest in %s', $path), E_USER_WARNING);
+            return;
         }
 
         $json = json_decode($content, true);
 
         if (!is_array($json) || !key_exists('entrypoints', $json)) {
-            throw new Exception('Manifest schema is not valid.');
+            trigger_error('Manifest schema is not valid.', E_USER_WARNING);
+            return;
         }
 
         $this->manifest = (new Collection($json))->except('entrypoints');

packages/php/src/Manifest.php

@@ -6,22 +6,43 @@
     $this->manifest = new Manifest(__DIR__ . '/__stubs__/assets-manifest.json', '/public/');
 });
 
-it('should fail if no manifest file is found', function() {
-    expect(function() {
-        return new Manifest('/path/to/manifest.json', '/');
-    })->toThrow('Could not find a manifest in /path/to/manifest.json');
+it('should trigger warning if no manifest file is found', function() {
+    $error = null;
+    set_error_handler(function($errno, $errstr) use (&$error) {
+        $error = $errstr;
+        return true;
+    });
+    
+    new Manifest('/path/to/manifest.json', '/');
+    
+    restore_error_handler();
+    expect($error)->toBe('Could not find a manifest in /path/to/manifest.json');
 });
 
-it('should fail if the manifest file can not be read', function() {
-    expect(function() {
-        return new Manifest(__DIR__ . '/__stubs__/', '/');
-    })->toThrow(sprintf('Could not read the manifest in %s', __DIR__ . '/__stubs__/'));
+it('should trigger warning if the manifest file can not be read', function() {
+    $error = null;
+    set_error_handler(function($errno, $errstr) use (&$error) {
+        $error = $errstr;
+        return true;
+    });
+    
+    new Manifest(__DIR__ . '/__stubs__/', '/');
+    
+    restore_error_handler();
+    expect($error)->toBe(sprintf('Could not read the manifest in %s', __DIR__ . '/__stubs__/'));
 });
 
-it('should fail if the manifest file does not follow the correct schema', function() {
-    expect(function() {
-        return new Manifest(__DIR__ . '/__stubs__/invalid-manifest.json', '/');
-    })->toThrow('Manifest schema is not valid.');
+it('should trigger warning if the manifest file does not follow the correct schema', function() {
+    $error = null;
+    set_error_handler(function($errno, $errstr) use (&$error) {
+        $error = $errstr;
+        return true;
+    });
+    
+    new Manifest(__DIR__ . '/__stubs__/invalid-manifest.json', '/');
+    
+    restore_error_handler();
+    expect($error)->toBe('Manifest schema is not valid.');
 });
 
 it('should return the real path of an asset or null', function() {

packages/php/tests/ManifestTest.php

@@ -1,6 +1,6 @@
 {
   "name": "@studiometa/webpack-config-preset-markdown",
-  "version": "6.3.3",
+  "version": "6.3.4",
   "publishConfig": {
     "access": "public"
   },

packages/preset-markdown/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@studiometa/webpack-config-preset-prototyping",
-  "version": "6.3.3",
+  "version": "6.3.4",
   "publishConfig": {
     "access": "public"
   },