Set up Danger

Author: koji-1009

.circleci/config.yml

@@ -29,6 +29,23 @@ commands:
       - store_test_results:
           path: studyplus-android-sdk2/build/test-results
 
+  setup_bundle:
+    steps:
+      - restore_cache:
+          key: v1-danger-cache-{{ checksum "Gemfile.lock" }}
+      - run:
+          name: Bundle install for Danger and fastlane
+          command: bundle check || bundle install --path vendor/bundle --clean
+      - save_cache:
+          paths:
+            - vendor/bundle
+          key: v1-danger-cache-{{ checksum "Gemfile.lock" }}
+  run_danger:
+    steps:
+      - run:
+          name: Run danger
+          command: bundle exec danger
+
 jobs:
   run_test:
     executor:
@@ -37,8 +54,22 @@ jobs:
       - checkout
       - setup
       - unit_test
+  run_danger:
+    executor:
+      name: default
+    steps:
+      - checkout
+      - setup_bundle
+      - run_danger
 
 workflows:
   test:
     jobs:
-      - run_test
+      - run_test:
+          filters:
+            branches:
+              only:
+                - master
+  pull_request:
+    jobs:
+      - run_danger

.gitignore

@@ -54,3 +54,7 @@ captures/
 
 # External native build folder generated in Android Studio 2.2 and later
 .externalNativeBuild
+
+# Bundle
+.bundle/
+vendor/bundle

Dangerfile

@@ -0,0 +1,34 @@
+####
+#
+# github comment settings
+#
+####
+github.dismiss_out_of_range_messages
+
+####
+#
+# for PR
+#
+####
+# Make it more obvious that a PR is a work in progress and shouldn't be merged yet
+warn("PR is classed as Work in Progress") if github.pr_title.include? "[WIP]"
+
+# Warn when there is a big PR
+warn("Big PR") if git.lines_of_code > 500
+
+# Don't let testing shortcuts get into master by accident
+fail("fdescribe left in tests") if `grep -r fdescribe specs/ `.length > 1
+fail("fit left in tests") if `grep -r fit specs/ `.length > 1
+
+# Warn when PR has no assignees
+warn("A pull request must have some assignees") if github.pr_json["assignee"].nil?
+
+####
+#
+# Android Lint
+#
+####
+android_lint.gradle_task = "studyplus-android-sdk2:lint"
+android_lint.report_file = "studyplus-android-sdk2/build/reports/lint/lint-result.xml"
+android_lint.filtering = true
+android_lint.lint(inline_mode: true)

Gemfile

@@ -0,0 +1,8 @@
+# frozen_string_literal: true
+
+source "https://rubygems.org"
+
+git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
+
+gem "danger"
+gem 'danger-android_lint'

Gemfile.lock

@@ -0,0 +1,70 @@
+GEM
+  remote: https://rubygems.org/
+  specs:
+    addressable (2.5.2)
+      public_suffix (>= 2.0.2, < 4.0)
+    ansi (1.5.0)
+    ast (2.4.0)
+    claide (1.0.2)
+    claide-plugins (0.9.2)
+      cork
+      nap
+      open4 (~> 1.3)
+    colored2 (3.1.2)
+    cork (0.3.0)
+      colored2 (~> 3.1)
+    danger (6.0.6)
+      claide (~> 1.0)
+      claide-plugins (>= 0.9.2)
+      colored2 (~> 3.1)
+      cork (~> 0.1)
+      faraday (~> 0.9)
+      faraday-http-cache (~> 1.0)
+      git (~> 1.5)
+      kramdown (~> 2.0)
+      kramdown-parser-gfm (~> 1.0)
+      no_proxy_fix
+      octokit (~> 4.7)
+      terminal-table (~> 1)
+    danger-android_lint (0.0.7)
+      danger-plugin-api (~> 1.0)
+      oga
+    danger-plugin-api (1.0.0)
+      danger (> 2.0)
+    faraday (0.15.4)
+      multipart-post (>= 1.2, < 3)
+    faraday-http-cache (1.3.1)
+      faraday (~> 0.8)
+    git (1.5.0)
+    kramdown (2.1.0)
+    kramdown-parser-gfm (1.0.1)
+      kramdown (~> 2.0)
+    multipart-post (2.0.0)
+    nap (1.1.0)
+    no_proxy_fix (0.1.2)
+    octokit (4.14.0)
+      sawyer (~> 0.8.0, >= 0.5.3)
+    oga (2.15)
+      ast
+      ruby-ll (~> 2.1)
+    open4 (1.3.4)
+    public_suffix (3.0.3)
+    ruby-ll (2.1.2)
+      ansi
+      ast
+    sawyer (0.8.1)
+      addressable (>= 2.3.5, < 2.6)
+      faraday (~> 0.8, < 1.0)
+    terminal-table (1.8.0)
+      unicode-display_width (~> 1.1, >= 1.1.1)
+    unicode-display_width (1.5.0)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  danger
+  danger-android_lint
+
+BUNDLED WITH
+   2.0.1