Skip to content

Commit 2dda702

Browse files
須藤将史須藤将史
authored andcommitted
Add error handling for access token
1 parent d8061cf commit 2dda702

File tree

4 files changed

+14
-3
lines changed

4 files changed

+14
-3
lines changed

Demo/StudyplusSDKDemo/StudyplusSDK/SPLStudyplus.m

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,8 +141,8 @@ - (BOOL)openURL:(NSURL*)url
141141
}
142142

143143
if ([url.pathComponents[1] isEqualToString:@"success"]) {
144-
NSString *accessToken = url.pathComponents[2];
145-
NSString *username = url.pathComponents[3];
144+
NSString *accessToken = [url.pathComponents[2] stringByTrimmingCharactersInSet:[NSCharacterSet whitespaceAndNewlineCharacterSet]];
145+
NSString *username = [url.pathComponents[3] stringByTrimmingCharactersInSet:[NSCharacterSet whitespaceAndNewlineCharacterSet]];
146146
[self saveAccessToken:accessToken andUsername:username];
147147
[self.delegate studyplusDidConnect:self];
148148
} else if ([url.pathComponents[1] isEqualToString:@"fail"]) {

Demo/StudyplusSDKDemo/StudyplusSDK/SPLStudyplusAPIRequest.m

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,11 @@ - (void)postRequestWithPath:(NSString *)path
6565
completed:(void(^)(NSDictionary *response))completed
6666
failed:(void(^)(NSError *error))failed
6767
{
68+
if (!self.accessToken || self.accessToken.length == 0) {
69+
failed([SPLStudyplusError errorFromStudyplusErrorCode:SPLErrorCodeNoAccessToken]);
70+
return;
71+
}
72+
6873
[self sendRequestWithPath:path
6974
requestParams:requestParameter
7075
completed:completed

Demo/StudyplusSDKDemo/StudyplusSDK/SPLStudyplusError.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ typedef NS_ENUM(NSInteger, SPLErrorCode) {
3131
SPLErrorCodeNetworkUnavailable = 6000,
3232
SPLErrorCodeServerError = 7000,
3333
SPLErrorCodePostRecordFailed = 8000,
34+
SPLErrorCodeNoAccessToken = 9000,
3435
SPLErrorCodeUnknown = 90000
3536
};
3637

Demo/StudyplusSDKDemo/StudyplusSDK/SPLStudyplusError.m

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,12 @@ + (NSError*)errorFromStudyplusErrorCode:(SPLErrorCode)studyplusErrorCode
7070
error = [SPLStudyplusError errorWithCode:studyplusErrorCode
7171
localizedDescription:@"Failed to post study record. (400 bad request)"];
7272
break;
73-
73+
74+
case SPLErrorCodeNoAccessToken:
75+
error = [SPLStudyplusError errorWithCode:studyplusErrorCode
76+
localizedDescription:@"No access token"];
77+
break;
78+
7479
case SPLErrorCodeUnknown:
7580
error = [SPLStudyplusError errorWithCode:SPLErrorCodeUnknown
7681
localizedDescription:@"Unknown Error."];

0 commit comments

Comments
 (0)