Skip to content

Commit d115103

Browse files
committed
addr can not be nil after initial check
Signed-off-by: Jiri Podivin <[email protected]>
1 parent 038a5ec commit d115103

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

apis/network/v1beta1/netconfig_webhook.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -406,20 +406,20 @@ func valiateAddress(
406406

407407
// Validate IP Family for IPv4
408408
if k8snet.IsIPv4CIDR(ipPrefix) {
409-
if addr != nil && !k8snet.IsIPv4(addr) {
409+
if !k8snet.IsIPv4(addr) {
410410
allErrs = append(allErrs, field.Invalid(path, addrStr, errMixedAddressFamily))
411411
}
412412
}
413413

414414
// Validate IP Family for IPv6
415415
if k8snet.IsIPv6CIDR(ipPrefix) {
416-
if addr != nil && !k8snet.IsIPv6(addr) {
416+
if !k8snet.IsIPv6(addr) {
417417
allErrs = append(allErrs, field.Invalid(path, addrStr, errMixedAddressFamily))
418418
}
419419
}
420420

421421
// Validate addr in cidr
422-
if addr != nil && !ipPrefix.Contains(addr) {
422+
if !ipPrefix.Contains(addr) {
423423
allErrs = append(allErrs, field.Invalid(path, addrStr, fmt.Sprintf(errNotInCidr, ipPrefix.String())))
424424
}
425425

0 commit comments

Comments
 (0)