Merge pull request #14 from NimaSarajpoor/add_test

Add test for challenger and warning

Author: seanlaw

.flake8

@@ -0,0 +1,15 @@
+[flake8]
+ignore = 
+    E741,
+    W503,
+    E203,
+    D100,
+    D401,
+    D200,
+    D205,
+    D400,
+    D301
+max-line-length = 88
+docstring-convention=numpy
+per-file-ignores =
+    ./test.py:D101,D102,D103

.github/workflows/github-actions.yml

@@ -0,0 +1,60 @@
+name: Tests
+on:
+  push:
+    branches: main
+  pull_request:
+    branches: main
+
+jobs:
+  unit-testing:
+    defaults:
+      run:
+        # Set default shell to login-bash
+        # This is required to properly activate the conda environment
+        # https://github.com/conda-incubator/setup-miniconda?tab=readme-ov-file#use-a-default-shell
+        shell: bash -el {0}
+
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        os: [ubuntu-latest, macos-latest, windows-latest]
+    
+    steps:
+      - name: Install xmllint on Linux
+        if: runner.os == 'Linux'
+        run: sudo apt-get install libxml2-utils
+            
+      - name: Get Safe PYTHON_VERSION
+        run:  echo "PYTHON_VERSION=$(curl --location https://devguide.python.org/versions | xmllint --html --xpath '//section[@id="supported-versions"]//table/tbody/tr[count(//section[@id="supported-versions"]//table/tbody/tr[td[.="security"]]/preceding-sibling::*)]/td[1]/p/text()' - 2> /dev/null)" >> $GITHUB_ENV
+  
+      - name: Checkout Repository
+        uses: actions/checkout@v4
+
+      - name: Update environment.yml with PYTHON_VERSION
+        run: sed -r 's/- python[>=]+[0-9]+\.[0-9]+/- python==${{ env.PYTHON_VERSION }}/' environment.yml > environment_new.yml
+       
+      - name: Display environment_new.yml
+        run: cat environment_new.yml
+       
+      - name: Set up Miniconda and Install New Dependencies
+        uses: conda-incubator/setup-miniconda@v3
+        with:
+          environment-file: environment_new.yml
+        
+      - name : Remove environment_new.yml
+        run: rm -rf environment_new.yml
+       
+      - name : Display Conda Environments
+        run: conda env list
+       
+      - name: Display All Installed Packages
+        run: conda list
+       
+      - name: Display Python Version
+        run: python -c "import sys; print(sys.version)"
+            
+      - name: Show Full Numba Environment
+        run: python -m numba -s
+       
+      - name: Run Unit Tests and Coverage
+        run: ./test.sh

.gitignore

@@ -1,3 +1,4 @@
 __pycache__
 *csv
 .ipynb_checkpoints
+.coverage

environment.yml

@@ -8,11 +8,11 @@ dependencies:
   - numba>=0.59.1
   - fftw
   - pyfftw
-  - jax
   - panel
   - pandas>=0.20.0
   - flake8>=3.7.7
   - black>=22.1.0
   - jupyterlab>=3.0
   - matplotlib>=3.3.0
-  - isort>=5.11.0
+  - pytest>=4.4.1
+  - coverage>=4.5.3

sdp/njit_sdp.py

@@ -1,6 +1,5 @@
 import numpy as np
 from numba import njit
-import sdp
 
 
 @njit(fastmath=True)

sdp/numpy_fft_sdp.py

@@ -14,7 +14,8 @@ def sliding_dot_product(Q, T, order="F"):
     tmp = np.empty((2, shape), order=order)
     tmp[0, :m] = Q[::-1]
     tmp[0, m:] = 0.0
-    tmp[1, :] = T
+    tmp[1, :n] = T
+    tmp[1, n:] = 0.0
     fft_2d = np.fft.rfft(tmp, axis=-1)
 
-    return np.fft.irfft(np.multiply(fft_2d[0], fft_2d[1]))[m - 1 : n]
+    return np.fft.irfft(np.multiply(fft_2d[0], fft_2d[1]), n=shape)[m - 1 : n]