Fixed #1066 Permanently Remove Recompile

Author: seanlaw

stumpy/cache.py

@@ -156,40 +156,6 @@ def _get_cache():
     return [f.name for f in pathlib.Path(numba_cache_dir).glob("*nb*") if f.is_file()]
 
 
-def _recompile():
-    """
-    Recompile all njit functions
-
-    Parameters
-    ----------
-    None
-
-    Returns
-    -------
-    None
-
-    Notes
-    -----
-    If the `numba` cache is enabled, this results in saving (and/or overwriting)
-    the cached numba functions to disk.
-    """
-    for module_name, func_name in get_njit_funcs():
-        module = importlib.import_module(f".{module_name}", package="stumpy")
-        func = getattr(module, func_name)
-        try:
-            func.recompile()
-        except AttributeError as e:
-            if (
-                numba.config.DISABLE_JIT
-                and str(e) == "'function' object has no attribute 'recompile'"
-            ):
-                pass
-            else:  # pragma: no cover
-                raise
-
-    return
-
-
 def _save():
     """
     Save all njit functions
@@ -203,7 +169,6 @@ def _save():
     None
     """
     _enable()
-    _recompile()
 
     return
 

stumpy/fastmath.py

@@ -54,12 +54,15 @@ def _set(module_name, func_name, flag):
     module = importlib.import_module(f".{module_name}", package="stumpy")
     func = getattr(module, func_name)
     try:
-        func.targetoptions["fastmath"] = flag
-        func.recompile()
+        py_func = func.py_func  # Copy raw Python function (independent of `njit`)
+        njit_signature = func.targetoptions.copy()  # Copy the `njit` arguments
+        njit_signature.pop("nopython", None)  # Pop redundant `nopython` declaration
+        njit_signature["fastmath"] = flag  # Apply new `fastmath` flag
+        func = njit(py_func, **njit_signature)  # Assign `njit` function with new target
+        setattr(module, func_name, func)  # Monkey-patch `njit` into global space
     except AttributeError as e:
         if numba.config.DISABLE_JIT and (
-            str(e) == "'function' object has no attribute 'targetoptions'"
-            or str(e) == "'function' object has no attribute 'recompile'"
+            str(e) == "'function' object has no attribute 'py_func'"
         ):
             pass
         else:  # pragma: no cover

tests/test_precision.py

@@ -9,7 +9,7 @@
 from numba import cuda
 
 import stumpy
-from stumpy import cache, config, core, fastmath
+from stumpy import config, core, fastmath
 
 try:
     from numba.errors import NumbaPerformanceWarning
@@ -156,7 +156,6 @@ def test_snippets():
         fastmath._set(
             "core", "_calculate_squared_distance", {"nsz", "arcp", "contract", "afn"}
         )
-        cache._recompile()
 
         (
             cmp_snippets,
@@ -187,7 +186,6 @@ def test_snippets():
     if not numba.config.DISABLE_JIT:  # pragma: no cover
         # Revert fastmath flag back to their default values
         fastmath._reset("core", "_calculate_squared_distance")
-        cache._recompile()
 
 
 @pytest.mark.filterwarnings("ignore", category=NumbaPerformanceWarning)