Skip to content

Commit a505b87

Browse files
committed
Refactored code
1 parent ca5ee5d commit a505b87

File tree

3 files changed

+11
-19
lines changed

3 files changed

+11
-19
lines changed

stumpy/cache.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import ast
66
import importlib
77
import inspect
8-
import os
98
import pathlib
109
import site
1110
import warnings
@@ -118,8 +117,6 @@ def _clear(cache_dir=None):
118117
"""
119118
if cache_dir is not None: # pragma: no cover
120119
numba_cache_dir = str(cache_dir)
121-
elif "PYTEST_CURRENT_TEST" in os.environ:
122-
numba_cache_dir = "stumpy/__pycache__"
123120
else: # pragma: no cover
124121
site_pkg_dir = site.getsitepackages()[0]
125122
numba_cache_dir = site_pkg_dir + "/stumpy/__pycache__"
@@ -163,8 +160,6 @@ def _get_cache(cache_dir=None):
163160
warnings.warn(CACHE_WARNING)
164161
if cache_dir is not None: # pragma: no cover
165162
numba_cache_dir = str(cache_dir)
166-
elif "PYTEST_CURRENT_TEST" in os.environ:
167-
numba_cache_dir = "stumpy/__pycache__"
168163
else: # pragma: no cover
169164
site_pkg_dir = site.getsitepackages()[0]
170165
numba_cache_dir = site_pkg_dir + "/stumpy/__pycache__"
@@ -250,7 +245,7 @@ def save(cache_dir=None):
250245
else: # pragma: no cover
251246
warnings.warn(CACHE_WARNING)
252247

253-
if numba.config.CACHE_DIR != "":
248+
if numba.config.CACHE_DIR != "": # pragma: no cover
254249
msg = "Found user specified `NUMBA_CACHE_DIR`/`numba.config.CACHE_DIR`. "
255250
msg += "The `stumpy` cache files may not be saved/cleared correctly!"
256251
warnings.warn(msg)

stumpy/fastmath.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ def _set(module_name, func_name, flag):
6464
if numba.config.DISABLE_JIT and (
6565
str(e) == "'function' object has no attribute 'targetoptions'"
6666
):
67+
warnings.warn("Fastmath flags could not be set as Numba JIT is disabled")
6768
pass
6869
else: # pragma: no cover
6970
raise

tests/test_cache.py

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import numba
21
import numpy as np
32

43
from stumpy import cache, stump
@@ -13,22 +12,19 @@ def test_cache_save_after_clear():
1312
T = np.random.rand(10)
1413
m = 3
1514

16-
cache.save()
17-
stump(T, m)
18-
ref_cache = cache._get_cache()
15+
cache_dir = "stumpy/__pycache__"
1916

20-
if numba.config.DISABLE_JIT:
21-
assert len(ref_cache) == 0
22-
else: # pragma: no cover
23-
assert len(ref_cache) > 0
17+
cache.save(cache_dir)
18+
stump(T, m)
19+
ref_cache = cache._get_cache(cache_dir)
2420

25-
cache.clear()
26-
assert len(cache._get_cache()) == 0
21+
cache.clear(cache_dir)
22+
assert len(cache._get_cache(cache_dir)) == 0
2723

28-
cache.save()
24+
cache.save(cache_dir)
2925
stump(T, m)
30-
comp_cache = cache._get_cache()
26+
comp_cache = cache._get_cache(cache_dir)
3127

3228
assert sorted(ref_cache) == sorted(comp_cache)
3329

34-
cache.clear()
30+
cache.clear(cache_dir)

0 commit comments

Comments
 (0)