Potential fix for code scanning alert no. 5752: Comparison of narrow type with wide type in loop condition

bigfooted · github-advanced-security[bot] · web-flow · commit 19d0bd64b9dc · 2025-11-14T16:05:33.000+01:00
Co-authored-by: Copilot Autofix powered by AI &lt;62310815+github-advanced-security[bot]@users.noreply.github.com&gt;
diff --git a/Common/include/option_structure.inl b/Common/include/option_structure.inl
@@ -1383,7 +1383,7 @@ class COptionWallSpecies : public COptionBase {
     }
 
     // Calculate number of species for each marker
-    for (unsigned short i = 0; i < marker_indices.size(); i++) {
+    for (size_t i = 0; i < marker_indices.size(); i++) {
       unsigned short start_idx = marker_indices[i] + 1;  // Start after marker name
       unsigned short end_idx = (i + 1 < marker_indices.size()) ? marker_indices[i + 1] : totalVals;
       unsigned short entries = end_idx - start_idx;

Original file line number	Diff line number	Diff line change
`@@ -1383,7 +1383,7 @@ class COptionWallSpecies : public COptionBase {`
`1383`	`1383`	`}`
`1384`	`1384`
`1385`	`1385`	`// Calculate number of species for each marker`
`1386`		`- for (unsigned short i = 0; i < marker_indices.size(); i++) {`
	`1386`	`+ for (size_t i = 0; i < marker_indices.size(); i++) {`
`1387`	`1387`	`unsigned short start_idx = marker_indices[i] + 1; // Start after marker name`
`1388`	`1388`	`unsigned short end_idx = (i + 1 < marker_indices.size()) ? marker_indices[i + 1] : totalVals;`
`1389`	`1389`	`unsigned short entries = end_idx - start_idx;`