Fix code scanning alert no. 5107: Comparison of narrow type with wide type in loop condition

bigfooted · github-advanced-security[bot] · web-flow · commit 40e1d9761e1c · 2024-12-03T16:19:32.000+01:00
Co-authored-by: Copilot Autofix powered by AI &lt;62310815+github-advanced-security[bot]@users.noreply.github.com&gt;
diff --git a/SU2_CFD/include/solvers/CFVMFlowSolverBase.hpp b/SU2_CFD/include/solvers/CFVMFlowSolverBase.hpp
@@ -2230,7 +2230,7 @@ class CFVMFlowSolverBase : public CSolver {
     else if (val_source.size() > nVar)
       SU2_MPI::Error("Out-of-bounds source size used on solver.", CURRENT_FUNCTION);
     else {
-      for (unsigned short iVar=0; iVar < val_source.size(); iVar++)
+      for (size_t iVar=0; iVar < val_source.size(); iVar++)
         PointSource[val_point][iVar] = val_source[iVar];
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -2230,7 +2230,7 @@ class CFVMFlowSolverBase : public CSolver {`
`2230`	`2230`	`else if (val_source.size() > nVar)`
`2231`	`2231`	`SU2_MPI::Error("Out-of-bounds source size used on solver.", CURRENT_FUNCTION);`
`2232`	`2232`	`else {`
`2233`		`- for (unsigned short iVar=0; iVar < val_source.size(); iVar++)`
	`2233`	`+ for (size_t iVar=0; iVar < val_source.size(); iVar++)`
`2234`	`2234`	`PointSource[val_point][iVar] = val_source[iVar];`
`2235`	`2235`	`}`
`2236`	`2236`	`}`