Address CodeQL complaints

Author: bmunguia

SU2_CFD/include/gradients/computeMetrics.hpp

@@ -32,6 +32,7 @@
 #include <vector>
 #include <algorithm>
 #include <limits>
+#include <cmath>
 #include "../../../Common/include/parallelization/omp_structure.hpp"
 #include "../../../Common/include/linear_algebra/blas_structure.hpp"
 #include "../../../Common/include/toolboxes/geometry_toolbox.hpp"
@@ -171,7 +172,7 @@ void setPositiveDefiniteMetrics(CGeometry& geometry, const CConfig& config,
     /*--- Make positive definite by taking absolute value of eigenvalues ---*/
     /*--- Handle NaN and very small values that could cause numerical issues ---*/
     for (auto iDim = 0; iDim < nDim; iDim++) {
-      if (EigVal[iDim] != EigVal[iDim]) {
+      if (std::isnan(EigVal[iDim])) {
         /*--- NaN detected, set to small positive value ---*/
         EigVal[iDim] = eps;
       } else {
@@ -268,8 +269,6 @@ void normalizeMetrics(CGeometry& geometry, const CConfig& config,
   ScalarType A[nDim][nDim], EigVec[nDim][nDim], EigVal[nDim], work[nDim];
 
   for (auto iPoint = 0ul; iPoint < nPointDomain; ++iPoint) {
-    auto nodes = geometry.nodes;
-
     /*--- Decompose metric ---*/
     Tensor::get(metric, iPoint, iSensor, A, nDim);
     CBlasStructure::EigenDecomposition(A, EigVec, EigVal, nDim, work);

SU2_CFD/src/output/CFlowOutput.cpp

@@ -4132,7 +4132,6 @@ void CFlowOutput::LoadMeshAdaptationOutputs(const CConfig* config, const CSolver
                                             unsigned long iPoint) {
 
   const auto* Node_Flow = solver[FLOW_SOL]->GetNodes();
-  const auto* Node_Geo = geometry->nodes;
   if(config->GetCompute_Metric()) {
     // Common metric components for both 2D and 3D
     SetVolumeOutputValue("METRIC_XX", iPoint, Node_Flow->GetMetric(iPoint, 0));

SU2_CFD/src/output/filewriter/CParaviewXMLFileWriter.cpp

@@ -384,7 +384,6 @@ void CParaviewXMLFileWriter::WriteData(string val_filename){
       /*--- Resize buffer to accommodate tensor data ---*/
       dataBufferFloat.resize(myPoint*NTENSOR);
 
-      float val = 0.0;
       for (iPoint = 0; iPoint < myPoint; iPoint++) {
         dataBufferFloat[iPoint*NTENSOR + 0] = (float)dataSorter->GetData(VarCounter+0,iPoint); // XX
         dataBufferFloat[iPoint*NTENSOR + 1] = (float)dataSorter->GetData(VarCounter+2,iPoint); // YY