- Fixed some notation

- Remove unused variables

Author: rois1995

SU2_CFD/include/numerics/turbulent/turb_sources.hpp

@@ -642,7 +642,6 @@ class CSourcePieceWise_TurbSST final : public CNumerics {
   /*--- Closure constants ---*/
   const su2double sigma_k_1, sigma_k_2, sigma_w_1, sigma_w_2, beta_1, beta_2, beta_star, a1, alfa_1, alfa_2;
   const su2double prod_lim_const;
-  const su2double cTrans;
 
   /*--- Ambient values for SST-SUST. ---*/
   const su2double kAmb, omegaAmb;
@@ -727,7 +726,6 @@ class CSourcePieceWise_TurbSST final : public CNumerics {
         alfa_1(constants[8]),
         alfa_2(constants[9]),
         prod_lim_const(constants[10]),
-        cTrans(1.25),
         kAmb(val_kine_Inf),
         omegaAmb(val_omega_Inf) {
     /*--- "Allocate" the Jacobian using the static buffer. ---*/
@@ -909,6 +907,9 @@ class CSourcePieceWise_TurbSST final : public CNumerics {
 
       Residual[0] += pk * Volume;
       Residual[1] += pw * Volume;
+
+      /*--- Add the dissipation  terms to the residuals.---*/
+
       Residual[0] -= dk * Volume;
       Residual[1] -= dw * Volume;
 
@@ -931,5 +932,4 @@ class CSourcePieceWise_TurbSST final : public CNumerics {
 
     return ResidualType<>(Residual, Jacobian_i, nullptr);
   }
-
 };

SU2_CFD/include/variables/CTurbSAVariable.hpp

@@ -40,8 +40,6 @@ class CTurbSAVariable final : public CTurbVariable {
 
 private:
 
-  VectorType k, Omega;  /*!< \brief SST variables as computed through SA solution. */
-
 public:
   /*!
    * \brief Constructor of the class.

SU2_CFD/include/variables/CTurbSSTVariable.hpp

@@ -45,7 +45,6 @@ class CTurbSSTVariable final : public CTurbVariable {
   VectorType F2;    /*!< \brief Menter blending function for blending of k-w and k-eps. */
   VectorType CDkw;  /*!< \brief Cross-diffusion. */
   SST_ParsedOptions sstParsedOptions;
-
 public:
   /*!
    * \brief Constructor of the class.
@@ -88,5 +87,4 @@ class CTurbSSTVariable final : public CTurbVariable {
    * \brief Get the value of the cross diffusion of tke and omega.
    */
   inline su2double GetCrossDiff(unsigned long iPoint) const override { return CDkw(iPoint); }
-
 };

SU2_CFD/include/variables/CTurbVariable.hpp

@@ -37,14 +37,14 @@
  */
 class CTurbVariable : public CScalarVariable {
 protected:
-  VectorType muT; /*!< \brief Eddy viscosity. */
-  VectorType DES_LengthScale;
+  VectorType muT;             /*!< \brief Eddy viscosity. */
+  VectorType DES_LengthScale; /*!< \brief DES Length scale. */
 
 public:
   static constexpr size_t MAXNVAR = 2;
   VectorType turb_index;            /*!< \brief Value of the turbulence index for transition simulations. */
   VectorType intermittency;         /*!< \brief Value of the intermittency for the transition model. */
-  VectorType Vortex_Tilting;
+  VectorType Vortex_Tilting;        /*!< \brief Value of the vortex tilting measure for EDDES models. */
 
   /*!
    * \brief Constructor of the class.

SU2_CFD/src/solvers/CSolver.cpp

@@ -363,7 +363,6 @@ void CSolver::InitiatePeriodicComms(CGeometry *geometry,
 
   auto *Diff      = new su2double[nVar];
   auto *Und_Lapl  = new su2double[nVar];
-  auto *Vel_Lapl  = new su2double[nDim];
   auto *Sol_Min   = new su2double[nPrimVarGrad];
   auto *Sol_Max   = new su2double[nPrimVarGrad];
   auto *rotPrim_i = new su2double[nPrimVar];
@@ -969,6 +968,7 @@ void CSolver::InitiatePeriodicComms(CGeometry *geometry,
             }
 
             break;
+            
           default:
             SU2_MPI::Error("Unrecognized quantity for periodic communication.",
                            CURRENT_FUNCTION);
@@ -986,7 +986,6 @@ void CSolver::InitiatePeriodicComms(CGeometry *geometry,
 
   delete [] Diff;
   delete [] Und_Lapl;
-  delete [] Vel_Lapl;
   delete [] Sol_Min;
   delete [] Sol_Max;
   delete [] rotPrim_i;
@@ -1291,6 +1290,7 @@ void CSolver::CompletePeriodicComms(CGeometry *geometry,
                 limiter(iPoint, iVar) = min(limiter(iPoint, iVar), bufDRecv[buf_offset+iVar]);
 
               break;
+              
             default:
 
               SU2_MPI::Error("Unrecognized quantity for periodic communication.",

SU2_CFD/src/solvers/CTurbSASolver.cpp

@@ -235,8 +235,7 @@ void CTurbSASolver::Postprocessing(CGeometry *geometry, CSolver **solver_contain
     const su2double nu = mu/rho;
     const su2double nu_hat = nodes->GetSolution(iPoint,0);
     const su2double roughness = geometry->nodes->GetRoughnessHeight(iPoint);
-    const su2double wallDistance = geometry->nodes->GetWall_Distance(iPoint);
-    const su2double dist = wallDistance + rough_const * roughness;
+    const su2double dist = geometry->nodes->GetWall_Distance(iPoint) + rough_const * roughness;
 
     su2double Ji = nu_hat/nu;
     if (roughness > 1.0e-10)

SU2_CFD/src/solvers/CTurbSSTSolver.cpp

@@ -278,7 +278,7 @@ void CTurbSSTSolver::Postprocessing(CGeometry *geometry, CSolver **solver_contai
     const su2double omega = nodes->GetSolution(iPoint,1);
 
     const auto& eddy_visc_var = sstParsedOptions.version == SST_OPTIONS::V1994 ? VorticityMag : StrainMag;
-    su2double muT = max(0.0, rho * a1 * kine / max(a1 * omega, eddy_visc_var * F2));
+    const su2double muT = max(0.0, rho * a1 * kine / max(a1 * omega, eddy_visc_var * F2));
 
     nodes->SetmuT(iPoint, muT);
 
@@ -409,9 +409,11 @@ void CTurbSSTSolver::Source_Residual(CGeometry *geometry, CSolver **solver_conta
     }
 
     /*--- Compute the source term ---*/
+
     auto residual = numerics->ComputeResidual(config);
 
     /*--- Store the intermittency ---*/
+    
     if (config->GetKind_Trans_Model() != TURB_TRANS_MODEL::NONE) {
       nodes->SetIntermittency(iPoint, numerics->GetIntermittencyEff());
     }

SU2_CFD/src/variables/CTurbSAVariable.cpp

@@ -45,8 +45,4 @@ CTurbSAVariable::CTurbSAVariable(su2double val_nu_tilde, su2double val_muT, unsi
     Solution_time_n  = Solution;
     Solution_time_n1 = Solution;
   }
-
-
-  k.resize(nPoint) = su2double(0.0);
-  Omega.resize(nPoint) = su2double(0.0);
 }

SU2_CFD/src/variables/CTurbSSTVariable.cpp

@@ -51,7 +51,6 @@ CTurbSSTVariable::CTurbSSTVariable(su2double kine, su2double omega, su2double mu
   CDkw.resize(nPoint) = su2double(0.0);
 
   muT.resize(nPoint) = mut;
-
 }
 
 void CTurbSSTVariable::SetBlendingFunc(unsigned long iPoint, su2double val_viscosity,