Merge pull request #1736 from su2code/develop

Update master

Author: pcarruscag

.github/ISSUE_TEMPLATE/bug_report.md

@@ -7,14 +7,18 @@ assignees: ''
 
 ---
 
-**Describe the bug**
-*A clear and concise description of what the bug is and what you expect the behavior to be instead. If applicable, add screenshots to help explain your problem.*
+*If this is a general question or difficulty building/using the code, please open a "Discussion" instead.*
 
+**Describe the bug**
+*Give a clear and concise description of what the bug is and what you expect the behavior to be instead. Please provide enough instructions and data for a developer to reproduce the problem (config, mesh, commands, etc.). Please provide the smallest working example that reproduces the problem.*
 
 
-**To Reproduce**
-*Please provide a config file and mesh for a minimal example that recreates the problem.*
+**Bug report checklist**
+*Please make sure that you have followed the checklist below, many common problems can be solved by:*
 
+- [ ] Consulting the build instructions (https://su2code.github.io/docs_v7/Build-SU2-Linux-MacOS/).
+- [ ] Looking for similar problems on GitHub or CFD-Online (https://www.cfd-online.com/Forums/su2/).
+- [ ] Updating to the newest version of SU2 (either develop, master, or the pre-built executables https://su2code.github.io/download.html).
 
 
 **Desktop (please complete the following information):**

.github/dependabot.yml

@@ -0,0 +1,6 @@
+version: 2
+updates:
+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      interval: "weekly"

.github/pull_request_template.md

@@ -12,7 +12,7 @@
 *Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.*
 
 - [ ] I am submitting my contribution to the develop branch.
-- [ ] My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags, or simply --warnlevel=2 when using meson).
-- [ ] My contribution is commented and consistent with SU2 style.
+- [ ] My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
+- [ ] My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
 - [ ] I have added a test case that demonstrates my contribution, if necessary.
-- [ ] I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.
+- [ ] I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

.github/workflows/regression-arm64.yml

@@ -0,0 +1,13 @@
+name: Regression tests running on Linux ARM64
+
+on:
+  push:
+    branches:
+      - 'develop'
+
+jobs:
+  build_on_arm64:
+    name: Run the jobs on Linux ARM64
+    uses: './.github/workflows/regression.yml'
+    with:
+      runner: 'ARM64'

.github/workflows/regression.yml

@@ -9,6 +9,13 @@ on:
     branches: 
       - 'develop'
       - 'master'
+  workflow_call:
+    inputs:
+      runner:
+        description: 'The github runner to use'
+        default: 'ubuntu-latest'
+        required: false
+        type: string
 
 jobs:
   build:
@@ -31,30 +38,42 @@ jobs:
           - config_set: ForwardNoMPI
             flags: '-Denable-directdiff=true -Denable-normal=false -Dwith-mpi=disabled -Denable-tests=true --warnlevel=3 --werror'
           - config_set: BaseOMP
-            flags: '-Dwith-omp=true -Denable-mixedprec=true -Denable-tecio=false --warnlevel=3 --werror'
+            flags: '-Dwith-omp=true -Denable-mixedprec=true -Denable-pywrapper=true -Denable-tecio=false --warnlevel=3 --werror'
           - config_set: ReverseOMP
             flags: '-Denable-autodiff=true -Denable-normal=false -Dwith-omp=true -Denable-mixedprec=true -Denable-tecio=false --warnlevel=3 --werror'
           - config_set: ForwardOMP
             flags: '-Denable-directdiff=true -Denable-normal=false -Dwith-omp=true -Denable-mixedprec=true -Denable-tecio=false --warnlevel=3 --werror'
-    runs-on: ubuntu-latest
+    runs-on: ${{ inputs.runner || 'ubuntu-latest' }}
     steps:
       - name: Cache Object Files
-        uses: actions/cache@v1
+        uses: actions/cache@v3
         with:
           path: ccache
           key: ${{ matrix.config_set }}-${{ github.sha }}
           restore-keys: ${{ matrix.config_set }}
+      - name: Pre Cleanup 
+        uses: docker://ghcr.io/su2code/su2/build-su2:220614-1237
+        with:
+          entrypoint: /bin/rm
+          args: -rf install install_bin.tgz src ccache ${{ matrix.config_set }}
       - name: Build 
-        uses: docker://su2code/build-su2:20191105
+        uses: docker://ghcr.io/su2code/su2/build-su2:220614-1237
         with:
           args: -b ${{github.ref}} -f "${{matrix.flags}}"
+      - name: Compress binaries
+        run: tar -zcvf install_bin.tgz install/bin
       - name: Upload Binaries 
-        uses: actions/upload-artifact@v1
+        uses: actions/upload-artifact@v3
         with:
           name: ${{ matrix.config_set }}
-          path: install/bin
+          path: install_bin.tgz
+      - name: Post Cleanup
+        uses: docker://ghcr.io/su2code/su2/build-su2:220614-1237
+        with:
+          entrypoint: /bin/rm
+          args: -rf install install_bin.tgz src ccache ${{ matrix.config_set }}
   regression_tests:
-    runs-on: ubuntu-latest
+    runs-on: ${{ inputs.runner || 'ubuntu-latest' }}
     name: Regression Tests
     needs: build
     strategy:
@@ -79,22 +98,44 @@ jobs:
           - testscript: 'hybrid_regression_AD.py'
             tag: OMP
     steps:
-      - name: Download All artifact
-        uses: actions/download-artifact@v2
-      - name: Move Binaries
+      - name: Pre Cleanup
+        uses: docker://ghcr.io/su2code/su2/test-su2:220614-1237
+        with:
+          entrypoint: /bin/rm
+          args: -rf install install_bin.tgz src ccache ${{ matrix.config_set }}
+      - name: Download All artifacts
+        uses: actions/download-artifact@v3
+      - name: Uncompress and Move Binaries
         run: |
-          mkdir -p install/bin
-          if [ -d "${{format('Base{0}', matrix.tag)}}" ];    then cp -r ${{format('Base{0}', matrix.tag)}}/.    install/bin/; fi
-          if [ -d "${{format('Reverse{0}', matrix.tag)}}" ]; then cp -r ${{format('Reverse{0}', matrix.tag)}}/. install/bin/; fi
-          if [ -d "${{format('Forward{0}', matrix.tag)}}" ]; then cp -r ${{format('Forward{0}', matrix.tag)}}/. install/bin/; fi
-          chmod a+x install/bin/*
+          BIN_FOLDER="$PWD/install/bin"
+          mkdir -p $BIN_FOLDER
+          ls -lah $BIN_FOLDER
+          for type in Base Reverse Forward; do
+            TYPE_FOLDER="${type}${{matrix.tag}}"
+            echo "Processing '$TYPE_FOLDER' ..."
+            if [ -d $TYPE_FOLDER ]; then
+              pushd $TYPE_FOLDER
+              ls -lah
+              tar -zxvf install_bin.tgz
+              ls -lah install/bin/
+              cp -r install/bin/* $BIN_FOLDER;
+              popd; 
+            fi
+          done
+          chmod a+x $BIN_FOLDER/*
+          ls -lahR $BIN_FOLDER
       - name: Run Tests in Container
-        uses: docker://su2code/test-su2:20200303
+        uses: docker://ghcr.io/su2code/su2/test-su2:220614-1237
         with:
           # -t <Tutorials-branch> -c <Testcases-branch>
           args: -b ${{github.ref}} -t develop -c develop -s ${{matrix.testscript}}
+      - name: Cleanup
+        uses: docker://ghcr.io/su2code/su2/test-su2:220614-1237
+        with:
+          entrypoint: /bin/rm
+          args: -rf install install_bin.tgz src ccache ${{ matrix.config_set }}
   unit_tests:
-    runs-on: ubuntu-latest
+    runs-on: ${{ inputs.runner || 'ubuntu-latest' }}
     name: Unit Tests
     needs: build
     strategy:
@@ -109,26 +150,73 @@ jobs:
           - testdriver: 'test_driver_DD'
             tag: MPI
     steps:
+      - name: Pre Cleanup 
+        uses: docker://ghcr.io/su2code/su2/test-su2:220614-1237
+        with:
+          entrypoint: /bin/rm
+          args: -rf install install_bin.tgz src ccache ${{ matrix.config_set }}
       - name: Download Base
-        uses: actions/download-artifact@v1
+        uses: actions/download-artifact@v3
         with:
           name: ${{format('Base{0}', matrix.tag)}}
+          path: ${{format('Base{0}', matrix.tag)}}
       - name: Download Reverse
-        uses: actions/download-artifact@v1
+        uses: actions/download-artifact@v3
         with:
           name: ${{format('Reverse{0}', matrix.tag)}}
+          path: ${{format('Reverse{0}', matrix.tag)}}
       - name: Download Forward
-        uses: actions/download-artifact@v1
+        uses: actions/download-artifact@v3
         with:
           name: ${{format('Forward{0}', matrix.tag)}}
-      - name: Move Binaries
+          path: ${{format('Forward{0}', matrix.tag)}}
+      - name: Uncompress and Move Binaries
         run: |
-          mkdir -p install/bin
-          cp -r ${{format('Base{0}', matrix.tag)}}/. install/bin/
-          cp -r ${{format('Reverse{0}', matrix.tag)}}/. install/bin/
-          cp -r ${{format('Forward{0}', matrix.tag)}}/. install/bin/
-          chmod a+x install/bin/*
+          ls -lah
+          BIN_FOLDER="$PWD/install/bin"
+          mkdir -p $BIN_FOLDER
+          ls -laH $BIN_FOLDER
+          for type in Base Reverse Forward; do
+            TYPE_FOLDER="${type}${{matrix.tag}}"
+            if [ -d $TYPE_FOLDER ]; then
+              echo "Processing '$TYPE_FOLDER' ..."
+              pushd $TYPE_FOLDER
+              ls -lah
+              tar -zxvf install_bin.tgz
+              ls -laH install/bin/
+              cp -r install/bin/* $BIN_FOLDER;
+              popd;
+            else
+              echo "$TYPE_FOLDER does not exist!"
+            fi
+          done
+          find $BIN_FOLDER -type f -exec chmod a+x '{}' \;
+          ls -lahR $BIN_FOLDER
+          echo "cloning branch"
+          branch="${{github.ref}}"
+          name="SU2"
+          SRC_FOLDER="$PWD/src"
+          mkdir -p $SRC_FOLDER 
+          cd $SRC_FOLDER 
+          git clone --recursive --depth=1 --shallow-submodules https://github.com/su2code/SU2 $name
+          cd $name
+          git config --add remote.origin.fetch '+refs/pull/*/merge:refs/remotes/origin/refs/pull/*/merge'
+          git config --add remote.origin.fetch '+refs/heads/*:refs/remotes/origin/refs/heads/*'
+          git fetch origin --depth=1 $branch:$branch
+          git checkout $branch
+          git submodule update
+          echo $PWD
+          ls -lahR
+          cd ..
+          echo "done cloning"
+          echo $PWD
+          ls -lahR
       - name: Run Unit Tests
-        uses: docker://su2code/test-su2:20191031
+        uses: docker://ghcr.io/su2code/su2/test-su2:220614-1237
         with:
           entrypoint: install/bin/${{matrix.testdriver}}
+      - name: Post Cleanup
+        uses: docker://ghcr.io/su2code/su2/test-su2:220614-1237
+        with:
+          entrypoint: /bin/rm
+          args: -rf install install_bin.tgz src ccache ${{ matrix.config_set }}

.github/workflows/release-management.yml

@@ -23,7 +23,7 @@ jobs:
           - os_bin: macos64-mpi
             flags: '-Dcustom-mpi=true --cross-file=/hostfiles/hostfile_darwin_mpi'
           - os_bin: linux64
-            flags: '-Dwith-mpi=disabled --cross-file=/hostfiles/hostfile_linux'
+            flags: '-Dwith-mpi=disabled -Dstatic-cgns-deps=true --cross-file=/hostfiles/hostfile_linux'
           - os_bin: linux64-mpi
             flags: '-Dcustom-mpi=true --cross-file=/hostfiles/hostfile_linux_mpi'
     runs-on: ubuntu-latest
@@ -35,7 +35,7 @@ jobs:
           key: ${{ matrix.os_bin }}-${{ github.sha }}
           restore-keys: ${{ matrix.os_bin }}
       - name: Build
-        uses: docker://su2code/build-su2-cross:latest
+        uses: docker://ghcr.io/su2code/su2/build-su2-cross:220716-1459
         with:
           args: -b ${{ github.sha }} -f "${{matrix.flags}}"
       - name: Create Archive

AUTHORS.md

@@ -77,6 +77,7 @@ Giulio Gori
 Guillaume Bâty
 Harichand M V
 HL Kline
+HL Zhi
 IndianaStokes
 J. Sinsay
 JSmith36

Common/doc/docmain.hpp

@@ -2,7 +2,7 @@
  * \file docmain.hpp
  * \brief This file contains documentation for Doxygen and does not have any significance with respect to C++.
  * \author F. Palacios
- * \version 7.3.1 "Blackbird"
+ * \version 7.4.0 "Blackbird"
  *
  * SU2 Project Website: https://su2code.github.io
  *
@@ -26,7 +26,7 @@
  */
 
 /*! 
- * \mainpage SU2 version 7.3.1 "Blackbird"
+ * \mainpage SU2 version 7.4.0 "Blackbird"
  * SU2 suite is an open-source collection of C++ based software tools
  * to perform PDE analysis and PDE constrained optimization problems.  The toolset is designed with 
  * computational fluid dynamics and aerodynamic shape optimization in mind, but is extensible to