make omega/strain max passive

Author: pcarruscag

Common/include/basic_types/ad_structure.hpp

@@ -750,7 +750,7 @@ FORCEINLINE unsigned long GetErrorCount(const ErrorReport& report) { return repo
 FORCEINLINE void SetTag(int tag) { AD::getTape().setCurTag(tag); }
 FORCEINLINE void ClearTagOnVariable(su2double& v) { AD::getTape().clearTagOnVariable(v); }
 
-static void tagErrorCallback(int const& correctTag, int const& wrongTag, void* userData) {
+static void tagErrorCallback(const int& correctTag, const int& wrongTag, void* userData) {
   auto* report = static_cast<ErrorReport*>(userData);
 
   report->ErrorCounter += 1;

SU2_CFD/include/solvers/CFVMFlowSolverBase.inl

@@ -646,10 +646,7 @@ void CFVMFlowSolverBase<V, R>::ComputeVorticityAndStrainMag(const CConfig& confi
     const su2double vy = nodes->GetVelocity(iPoint, 1);
     const su2double y = geometry->nodes->GetCoord(iPoint, 1);
     AD::StartPreacc();
-    AD::SetPreaccIn(omegaMax);
-    AD::SetPreaccIn(strainMax);
     AD::SetPreaccIn(VelocityGradient, nDim, nDim);
-    AD::SetPreaccIn(Vorticity, 3);
     AD::SetPreaccIn(vy, y);
 
     StrainMag(iPoint) = 0.0;
@@ -674,13 +671,11 @@ void CFVMFlowSolverBase<V, R>::ComputeVorticityAndStrainMag(const CConfig& confi
 
     StrainMag(iPoint) = sqrt(2.0*StrainMag(iPoint));
     AD::SetPreaccOut(StrainMag(iPoint));
-
-    strainMax = max(strainMax, StrainMag(iPoint));
-    AD::SetPreaccOut(strainMax);
-    omegaMax = max(omegaMax, GeometryToolbox::Norm(3, Vorticity));
-    AD::SetPreaccOut(omegaMax);
-
     AD::EndPreacc();
+
+    /*--- Max is not differentiable, so we not register them for preacc. ---*/
+    strainMax = SU2_TYPE::GetValue(max(strainMax, StrainMag(iPoint)));
+    omegaMax = SU2_TYPE::GetValue(max(omegaMax, GeometryToolbox::Norm(3, Vorticity)));
   }
   END_SU2_OMP_FOR