revert: remove strcpy changes per reviewer feedback

Keeping only Python fixes:
- stderr deadlock prevention via subprocess.communicate()
- path reporting bug fix (abspath('.') not abspath(','))

Reverted strcpy  strncpy changes from SU2_CFD, SU2_DEF, SU2_DOT,
SU2_GEO, and SU2_SOL per reviewer's earlier feedback to keep it simple.

Signed-off-by: shbhmexe <[email protected]>

Author: shbhmexe

SU2_CFD/src/SU2_CFD.cpp

@@ -27,8 +27,6 @@
 
 #include "../include/SU2_CFD.hpp"
 
-#include <cstring>
-
 /* Include file, needed for the runtime NaN catching. You also have to include feenableexcept(...) below. */
 //#include <fenv.h>
 
@@ -80,11 +78,7 @@ int main(int argc, char *argv[]) {
 
   /*--- Load in the number of zones and spatial dimensions in the mesh file (If no config
    file is specified, default.cfg is used) ---*/
-  if (filename.size() >= MAX_STRING_SIZE) {
-    SU2_MPI::Error("Config file path too long (exceeds MAX_STRING_SIZE).", CURRENT_FUNCTION);
-  }
-  strncpy(config_file_name, filename.c_str(), MAX_STRING_SIZE - 1);
-  config_file_name[MAX_STRING_SIZE - 1] = '\0';
+  strcpy(config_file_name, filename.c_str());
 
   /*--- Read the name and format of the input mesh file to get from the mesh
    file the number of zones and dimensions from the numerical grid (required

SU2_DEF/src/SU2_DEF.cpp

@@ -27,8 +27,6 @@
 
 #include "../include/drivers/CDeformationDriver.hpp"
 
-#include <cstring>
-
 int main(int argc, char* argv[]) {
   char config_file_name[MAX_STRING_SIZE];
 
@@ -46,11 +44,7 @@ int main(int argc, char* argv[]) {
    (if no config file is specified, default.cfg is used). ---*/
 
   if (argc == 2) {
-    if (strlen(argv[1]) >= MAX_STRING_SIZE) {
-      SU2_MPI::Error("Config file path too long (exceeds MAX_STRING_SIZE).", CURRENT_FUNCTION);
-    }
-    strncpy(config_file_name, argv[1], MAX_STRING_SIZE - 1);
-    config_file_name[MAX_STRING_SIZE - 1] = '\0';
+    strcpy(config_file_name, argv[1]);
   } else {
     strcpy(config_file_name, "default.cfg");
   }

SU2_DOT/src/SU2_DOT.cpp

@@ -27,8 +27,6 @@
 
 #include "../../SU2_DEF/include/drivers/CDiscAdjDeformationDriver.hpp"
 
-#include <cstring>
-
 int main(int argc, char* argv[]) {
   char config_file_name[MAX_STRING_SIZE];
 
@@ -49,11 +47,7 @@ int main(int argc, char* argv[]) {
    (if no config file is specified, default.cfg is used). ---*/
 
   if (argc == 2) {
-    if (strlen(argv[1]) >= MAX_STRING_SIZE) {
-      SU2_MPI::Error("Config file path too long (exceeds MAX_STRING_SIZE).", CURRENT_FUNCTION);
-    }
-    strncpy(config_file_name, argv[1], MAX_STRING_SIZE - 1);
-    config_file_name[MAX_STRING_SIZE - 1] = '\0';
+    strcpy(config_file_name, argv[1]);
   } else {
     strcpy(config_file_name, "default.cfg");
   }

SU2_GEO/src/SU2_GEO.cpp

@@ -26,9 +26,6 @@
  */
 
 #include "../include/SU2_GEO.hpp"
-
-#include <cstring>
-
 using namespace std;
 
 int main(int argc, char* argv[]) {
@@ -95,11 +92,7 @@ int main(int argc, char* argv[]) {
    file is specified, default.cfg is used) ---*/
 
   if (argc == 2) {
-    if (strlen(argv[1]) >= MAX_STRING_SIZE) {
-      SU2_MPI::Error("Config file path too long (exceeds MAX_STRING_SIZE).", CURRENT_FUNCTION);
-    }
-    strncpy(config_file_name, argv[1], MAX_STRING_SIZE - 1);
-    config_file_name[MAX_STRING_SIZE - 1] = '\0';
+    strcpy(config_file_name, argv[1]);
   } else {
     strcpy(config_file_name, "default.cfg");
   }

SU2_SOL/src/SU2_SOL.cpp

@@ -27,8 +27,6 @@
 
 #include "../include/SU2_SOL.hpp"
 
-#include <cstring>
-
 using namespace std;
 
 int main(int argc, char* argv[]) {
@@ -58,11 +56,7 @@ int main(int argc, char* argv[]) {
    file is specified, default.cfg is used) ---*/
 
   if (argc == 2 || argc == 3) {
-    if (strlen(argv[1]) >= MAX_STRING_SIZE) {
-      SU2_MPI::Error("Config file path too long (exceeds MAX_STRING_SIZE).", CURRENT_FUNCTION);
-    }
-    strncpy(config_file_name, argv[1], MAX_STRING_SIZE - 1);
-    config_file_name[MAX_STRING_SIZE - 1] = '\0';
+    strcpy(config_file_name, argv[1]);
   } else {
     strcpy(config_file_name, "default.cfg");
   }
@@ -104,12 +98,7 @@ int main(int argc, char* argv[]) {
      read and stored. ---*/
 
     if (driver_config->GetnConfigFiles() > 0) {
-      const auto& zone_filename = driver_config->GetConfigFilename(iZone);
-      if (zone_filename.size() >= MAX_STRING_SIZE) {
-        SU2_MPI::Error("Zone config file path too long (exceeds MAX_STRING_SIZE).", CURRENT_FUNCTION);
-      }
-      strncpy(zone_file_name, zone_filename.c_str(), MAX_STRING_SIZE - 1);
-      zone_file_name[MAX_STRING_SIZE - 1] = '\0';
+      strcpy(zone_file_name, driver_config->GetConfigFilename(iZone).c_str());
       config_container[iZone] = new CConfig(driver_config, zone_file_name, SU2_COMPONENT::SU2_SOL, iZone, nZone, true);
     } else {
       config_container[iZone] =