add some const

Author: pcarruscag

Common/include/CConfig.hpp

@@ -1146,8 +1146,8 @@ class CConfig {
   jst_coeff[2],          /*!< \brief artificial dissipation (flow) array for the COption class. */
   ffd_coeff[3],          /*!< \brief artificial dissipation (flow) array for the COption class. */
   mixedout_coeff[3],     /*!< \brief default mixedout algorithm coefficients for the COption class. */
-  rampMotionFrame_coeff[3], /*!< \brief ramp motion frame coefficients for the COption class. */
-  rampOutlet_coeff[3],   /*!< \brief ramp outlet value coefficients for the COption class. */
+  rampMotionFrameCoeff[3], /*!< \brief ramp motion frame coefficients for the COption class. */
+  rampOutletCoeff[3],   /*!< \brief ramp outlet value coefficients for the COption class. */
   jst_adj_coeff[2],      /*!< \brief artificial dissipation (adjoint) array for the COption class. */
   mesh_box_length[3],    /*!< \brief mesh box length for the COption class. */
   mesh_box_offset[3],    /*!< \brief mesh box offset for the COption class. */
@@ -5121,31 +5121,19 @@ class CConfig {
    */
   bool GetRampMotionFrame(void) const { return RampMotionFrame; }
 
-  /*!
-   * \brief Get coeff for ramping the frame of motion (translation/rotation) [TURBO ONLY]
-   * \return coeff Ramp for frame of motion
-  */
-  su2double GetRampMotionFrame_Coeff(unsigned short iCoeff) const { return rampMotionFrame_coeff[iCoeff];}
-
   /*!
    * \brief Get outflow ramp option.
    * \return Ramp outflow option.
    */
   bool GetRampOutflow(void) const { return RampOutlet; }
 
-  /*!
-   * \brief Get coeff for ramping the Giles boundary outflow (pressure/mass flow) [TURBO ONLY]
-   * \return coeff Ramp for Giles outflow
-  */
-  su2double GetRampOutflow_Coeff(unsigned short iCoeff) const { return rampOutlet_coeff[iCoeff]; }
-
   /*!
    * \brief General interface for accessing ramp coefficient information
    * \return coeff for ramps
   */
-  su2double GetRamp_Coeff(RAMP_TYPE ramp_flag, RAMP_COEFF val_coeff) {
-    if (ramp_flag == RAMP_TYPE::GRID) return rampMotionFrame_coeff[val_coeff];
-    else if (ramp_flag == RAMP_TYPE::BOUNDARY) return rampOutlet_coeff[val_coeff];
+  su2double GetRampCoeff(RAMP_TYPE ramp_flag, RAMP_COEFF val_coeff) const {
+    if (ramp_flag == RAMP_TYPE::GRID) return rampMotionFrameCoeff[val_coeff];
+    else if (ramp_flag == RAMP_TYPE::BOUNDARY) return rampOutletCoeff[val_coeff];
     else return 0;
   };
 
@@ -6148,11 +6136,11 @@ class CConfig {
    * \brief General interface for setting the rate of motion in grid ramps
    * \param[in] ramp_flag - flag for type of ramp
    * \param[in] val - new value of rate of motion
-  */
+   */
   void SetRate(su2double val) {
     if (RampRotatingFrame) Rotation_Rate[2] = val;
     else if (RampTranslationFrame) Translation_Rate[1] = val;
-  };
+  }
 
   /*!
    * \brief Get the rotation rate of the marker.
@@ -6251,13 +6239,13 @@ class CConfig {
    * \brief Generic interface for retrieving final value of a turbomachinery ramp
    * \return Final value of a specified ramp
    */
-  su2double GetFinalValue(RAMP_TYPE ramp_flag) {
+  su2double GetFinalValue(RAMP_TYPE ramp_flag) const {
     if (ramp_flag == RAMP_TYPE::GRID && RampRotatingFrame) return FinalRotation_Rate_Z;
     else if (ramp_flag == RAMP_TYPE::GRID && RampTranslationFrame) return FinalTranslation_Rate_Y;
     else if (ramp_flag == RAMP_TYPE::BOUNDARY && RampOutletPressure) return FinalOutletPressure;
     else if (ramp_flag == RAMP_TYPE::BOUNDARY && RampOutletMassFlow) return FinalOutletMassFlow;
     else return 0.0;
-  };
+  }
 
   /*!
    * \brief Get the Harmonic Balance frequency pointer.

Common/src/CConfig.cpp

@@ -1640,18 +1640,18 @@ void CConfig::SetConfig_Options() {
   addDoubleArrayOption("MIXEDOUT_COEFF", 3, mixedout_coeff);
   /*!\brief RAMP_MOTION_FRAME\n DESCRIPTION: option to ramp up or down the frame of motion velocity value*/
   addBoolOption("RAMP_MOTION_FRAME", RampMotionFrame, false);
-  rampMotionFrame_coeff[0] = 100.0; rampMotionFrame_coeff[1] = 1.0; rampMotionFrame_coeff[2] = 1000.0;
+  rampMotionFrameCoeff[0] = 100.0; rampMotionFrameCoeff[1] = 1.0; rampMotionFrameCoeff[2] = 1000.0;
   /*!\brief RAMP_MOTION_FRAME_COEFF \n DESCRIPTION: the 1st coeff is the staring outlet value,
    * the 2nd coeff is the number of iterations for the update, 3rd is the number of total iteration till reaching the final outlet pressure value */
-  addDoubleArrayOption("RAMP_MOTION_FRAME_COEFF", 3, rampMotionFrame_coeff);
+  addDoubleArrayOption("RAMP_MOTION_FRAME_COEFF", 3, rampMotionFrameCoeff);
   /* DESCRIPTION: AVERAGE_MACH_LIMIT is a limit value for average procedure based on the mass flux. */
   addDoubleOption("AVERAGE_MACH_LIMIT", AverageMachLimit, 0.03);
   /*!\brief RAMP_OUTLET\n DESCRIPTION: option to ramp up or down the Giles outlet value*/
   addBoolOption("RAMP_OUTLET", RampOutlet, false);
-  rampOutlet_coeff[0] = 100000.0; rampOutlet_coeff[1] = 1.0; rampOutlet_coeff[2] = 1000.0;
+  rampOutletCoeff[0] = 100000.0; rampOutletCoeff[1] = 1.0; rampOutletCoeff[2] = 1000.0;
   /*!\brief RAMP_OUTLET_COEFF \n DESCRIPTION: the 1st coeff is the staring outlet value,
    * the 2nd coeff is the number of iterations for the update, 3rd is the number of total iteration till reaching the final outlet pressure value */
-  addDoubleArrayOption("RAMP_OUTLET_COEFF", 3, rampOutlet_coeff);
+  addDoubleArrayOption("RAMP_OUTLET_COEFF", 3, rampOutletCoeff);
   /*!\brief MARKER_MIXINGPLANE \n DESCRIPTION: Identify the boundaries in which the mixing plane is applied. \ingroup Config*/
   addStringListOption("MARKER_MIXINGPLANE_INTERFACE", nMarker_MixingPlaneInterface, Marker_MixingPlaneInterface);
   /*!\brief TURBULENT_MIXINGPLANE \n DESCRIPTION: Activate mixing plane also for turbulent quantities \ingroup Config*/
@@ -4435,28 +4435,28 @@ void CConfig::SetPostprocessing(SU2_COMPONENT val_software, unsigned short val_i
   if(GetGrid_Movement() && RampRotatingFrame && !DiscreteAdjoint){
     FinalRotation_Rate_Z = Rotation_Rate[2];
     if(abs(FinalRotation_Rate_Z) > 0.0){
-      Rotation_Rate[2] = rampMotionFrame_coeff[RAMP_COEFF::INITIAL_VALUE];
+      Rotation_Rate[2] = rampMotionFrameCoeff[RAMP_COEFF::INITIAL_VALUE];
     }
   }
 
   if(GetGrid_Movement() && RampTranslationFrame && !DiscreteAdjoint){
     FinalTranslation_Rate_Y = Translation_Rate[1];
     if(abs(FinalTranslation_Rate_Y) > 0.0){
-      Translation_Rate[1] = rampMotionFrame_coeff[RAMP_COEFF::INITIAL_VALUE];
+      Translation_Rate[1] = rampMotionFrameCoeff[RAMP_COEFF::INITIAL_VALUE];
     }
   }
 
   if(RampOutletPressure && !DiscreteAdjoint){
     for (iMarker = 0; iMarker < nMarker_Giles; iMarker++){
       if (Kind_Data_Giles[iMarker] == STATIC_PRESSURE || Kind_Data_Giles[iMarker] == STATIC_PRESSURE_1D || Kind_Data_Giles[iMarker] == RADIAL_EQUILIBRIUM ){
         FinalOutletPressure = Giles_Var1[iMarker];
-        Giles_Var1[iMarker] = rampOutlet_coeff[RAMP_COEFF::INITIAL_VALUE];
+        Giles_Var1[iMarker] = rampOutletCoeff[RAMP_COEFF::INITIAL_VALUE];
       }
     }
     for (iMarker = 0; iMarker < nMarker_Riemann; iMarker++){
       if (Kind_Data_Riemann[iMarker] == STATIC_PRESSURE || Kind_Data_Riemann[iMarker] == RADIAL_EQUILIBRIUM){
         FinalOutletPressure = Riemann_Var1[iMarker];
-        Riemann_Var1[iMarker] = rampOutlet_coeff[RAMP_COEFF::INITIAL_VALUE];
+        Riemann_Var1[iMarker] = rampOutletCoeff[RAMP_COEFF::INITIAL_VALUE];
       }
     }
   }
@@ -4465,7 +4465,7 @@ void CConfig::SetPostprocessing(SU2_COMPONENT val_software, unsigned short val_i
     for (iMarker = 0; iMarker < nMarker_Giles; iMarker++){
       if (Kind_Data_Giles[iMarker] == MASS_FLOW_OUTLET){
         FinalOutletMassFlow = Giles_Var1[iMarker];
-        Giles_Var1[iMarker] = rampOutlet_coeff[RAMP_COEFF::INITIAL_VALUE];
+        Giles_Var1[iMarker] = rampOutletCoeff[RAMP_COEFF::INITIAL_VALUE];
       }
     }
   }

SU2_CFD/src/iteration/CFluidIteration.cpp

@@ -264,20 +264,20 @@ void CFluidIteration::UpdateRamp(CGeometry**** geometry_container, CConfig** con
   auto* geometry = geometry_container[iZone][INST_0][ZONE_0];
 
   std::string msg = "\nUpdated rotating frame grid velocities for zone ";
-  if (ramp_flag == RAMP_TYPE::GRID && config->GetKind_GridMovement() == ENUM_GRIDMOVEMENT::STEADY_TRANSLATION) 
+  if (ramp_flag == RAMP_TYPE::GRID && config->GetKind_GridMovement() == ENUM_GRIDMOVEMENT::STEADY_TRANSLATION)
     msg = "\nUpdated translation frame grid velocities for zone ";
 
   if (config_container[ZONE_0]->GetMultizone_Problem())
     iter = config_container[ZONE_0]->GetOuterIter();
 
   /*-- Update grid velocities (ROTATING_FRAME, STEADY_TRANSLATION)*/
   if (ramp_flag == RAMP_TYPE::GRID && config->GetGrid_Movement()) {
-    const auto ini_vel = config->GetRamp_Coeff(ramp_flag, RAMP_COEFF::INITIAL_VALUE);
-    const long unsigned rampFreq = SU2_TYPE::Int(config->GetRamp_Coeff(ramp_flag, RAMP_COEFF::UPDATE_FREQ));
-    const long unsigned finalRamp_Iter = SU2_TYPE::Int(config->GetRamp_Coeff(ramp_flag, RAMP_COEFF::FINAL_ITER));
-    
-    // Two options needed as if finalRamp_Iter % rampFreq != 0 final value is not set correctly 
-    if((iter % rampFreq == 0 && iter < finalRamp_Iter) || (iter == finalRamp_Iter)){   
+    const auto ini_vel = config->GetRampCoeff(ramp_flag, RAMP_COEFF::INITIAL_VALUE);
+    const long unsigned rampFreq = SU2_TYPE::Int(config->GetRampCoeff(ramp_flag, RAMP_COEFF::UPDATE_FREQ));
+    const long unsigned finalRamp_Iter = SU2_TYPE::Int(config->GetRampCoeff(ramp_flag, RAMP_COEFF::FINAL_ITER));
+
+    // Two options needed as if finalRamp_Iter % rampFreq != 0 final value is not set correctly
+    if((iter % rampFreq == 0 && iter < finalRamp_Iter) || (iter == finalRamp_Iter)){
       const auto final_vel =  config->GetFinalValue(ramp_flag);
       if(fabs(final_vel) > 0.0) {
         const auto vel = ini_vel + iter * (final_vel - ini_vel)/finalRamp_Iter;
@@ -299,9 +299,9 @@ void CFluidIteration::UpdateRamp(CGeometry**** geometry_container, CConfig** con
 
   // Boundary ramps (pressure/mass flow)
   if (ramp_flag == RAMP_TYPE::BOUNDARY){
-    const auto outVal_ini = config->GetRamp_Coeff(ramp_flag, RAMP_COEFF::INITIAL_VALUE);
-    const long unsigned rampFreq = SU2_TYPE::Int(config->GetRamp_Coeff(ramp_flag, RAMP_COEFF::UPDATE_FREQ));
-    const long unsigned finalRamp_Iter = SU2_TYPE::Int(config->GetRamp_Coeff(ramp_flag, RAMP_COEFF::FINAL_ITER));
+    const auto outVal_ini = config->GetRampCoeff(ramp_flag, RAMP_COEFF::INITIAL_VALUE);
+    const long unsigned rampFreq = SU2_TYPE::Int(config->GetRampCoeff(ramp_flag, RAMP_COEFF::UPDATE_FREQ));
+    const long unsigned finalRamp_Iter = SU2_TYPE::Int(config->GetRampCoeff(ramp_flag, RAMP_COEFF::FINAL_ITER));
     const auto outVal_final = config->GetFinalValue(ramp_flag);
 
     if ((iter % rampFreq == 0 && iter < finalRamp_Iter) || (iter == finalRamp_Iter)) {

SU2_CFD/src/solvers/CSolver.cpp

@@ -3604,7 +3604,7 @@ void CSolver::LoadInletProfile(CGeometry **geometry,
     // are stored in p_value and t_value and the flow direction in flow_dir_or_vel, while for a
     // supersonic inlet the static conditions are stored in p_value and t_value and the flow
     // velocity in flow_dir_or_vel.
-    su2double p_value, t_value;
+    su2double p_value{}, t_value{};
     const su2double* flow_dir_or_vel = nullptr;
 
     if (KIND_MARKER == INLET_FLOW) {