Move registration of muT back to RegisterSolutionExtra, add comments.

Author: oleburghardt

SU2_CFD/include/solvers/CSolver.hpp

@@ -3513,13 +3513,6 @@ class CSolver {
    */
   inline virtual void RegisterOutput(CGeometry *geometry_container, CConfig *config) { }
 
-  /*!
-   * \brief A virtual member.
-   * \param[in] input - Boolean whether In- or Output should be registered.
-   * \param[in] config - The particular config.
-   */
-  inline virtual void RegisterComplementary(bool input, const CConfig* config) {  }
-
   /*!
    * \brief A virtual member.
    * \param[in] geometry - The geometrical definition of the problem.

SU2_CFD/include/solvers/CTurbSolver.hpp

@@ -144,6 +144,7 @@ class CTurbSolver : public CScalarSolver<CTurbVariable> {
    * \brief Register additional In- or Outputs for RANS.
    * \param[in] input - Boolean whether In- or Output should be registered.
    * \param[in] config - The particular config.
+   * \returns The number of extra variables.
    */
-  void RegisterComplementary(bool input, const CConfig* config) final;
+  unsigned long RegisterSolutionExtra(bool input, const CConfig* config) final;
 };

SU2_CFD/include/variables/CVariable.hpp

@@ -2150,7 +2150,7 @@ class CVariable {
   /*!
    * \brief A virtual member.
    */
-  inline virtual void RegisterEddyViscosity(bool input) { }
+  inline void RegisterEddyViscosity(bool input) { }
 
   /*!
    * \brief A virtual member.

SU2_CFD/src/solvers/CDiscAdjSolver.cpp

@@ -162,10 +162,8 @@ void CDiscAdjSolver::RegisterSolution(CGeometry *geometry, CConfig *config) {
   /*--- Boolean true indicates that an input is registered ---*/
   direct_solver->GetNodes()->RegisterSolution(true);
 
-  direct_solver->RegisterSolutionExtra(true, config);
-
   /*--- Register quantities that are no solver variables but further inputs/outputs of the (outer) iteration. ---*/
-  direct_solver->RegisterComplementary(true, config);
+  direct_solver->RegisterSolutionExtra(true, config);
 
   if (time_n_needed)
     direct_solver->GetNodes()->RegisterSolution_time_n();
@@ -303,8 +301,6 @@ void CDiscAdjSolver::RegisterOutput(CGeometry *geometry, CConfig *config) {
   direct_solver->GetNodes()->RegisterSolution(false);
 
   direct_solver->RegisterSolutionExtra(false, config);
-
-  direct_solver->RegisterComplementary(false, config);
 }
 
 void CDiscAdjSolver::ExtractAdjoint_Solution(CGeometry *geometry, CConfig *config, bool CrossTerm) {

SU2_CFD/src/solvers/CTurbSolver.cpp

@@ -237,8 +237,11 @@ void CTurbSolver::Impose_Fixed_Values(const CGeometry *geometry, const CConfig *
 
 }
 
-void CTurbSolver::RegisterComplementary(bool input, const CConfig* config) {
+unsigned long CTurbSolver::RegisterSolutionExtra(bool input, const CConfig* config) {
 
   /*--- Register muT as input/output of a RANS iteration. ---*/
   nodes->RegisterEddyViscosity(input);
+
+  /*--- We don't need to save adjoint values for muT. ---*/
+  return 0;
 }