run shellcheck and incorporate shellcheck in gh actions

Author: blaiseper

.github/workflows/docker-tests.yml

@@ -10,13 +10,22 @@ concurrency:
   cancel-in-progress: ${{ github.ref != 'refs/heads/main' }}
 
 jobs:
+  shellcheck:
+    name: Shellcheck
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Run ShellCheck
+      - uses: actions/checkout@v4
+      run: find . -type f -name "*.sh" -exec shellcheck {} +
+
   tests:
     name: Validate Platform Installation
     runs-on: ubuntu-latest
 
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Install Platform
         run: |

install-and-launch.sh

@@ -444,7 +444,7 @@ install_sublime() {
 
     if [ "$clone_platform" = "true" ]; then
         print_info "Cloning Sublime Platform repo..."
-        if ! git clone -b $remote_branch --depth=1 https://github.com/sublime-security/sublime-platform.git; then
+        if ! git clone -b "$remote_branch" --depth=1 https://github.com/sublime-security/sublime-platform.git; then
             print_error "Failed to clone Sublime Platform repo\n"
             printf "Troubleshooting tips: https://docs.sublimesecurity.com/docs/quickstart-docker#troubleshooting\n\n"
             printf "You may need to run the following command before retrying installation:\n\n"